From 15f0963f51b0ec97d524cac7a017ccd8da956c48 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Thu, 20 Jul 2017 12:35:09 +0200 Subject: [PATCH] Fix a typo, in the `Catalog.numPages` getter, than prevents shadowing from working correctly Looking at the blame, it seems that this typo was present even before PR 700 (almost six years ago). The result of using `'num'`, rather than the *correct* `'numPages'` string, is that the `Catalog.numPages` getter isn't actually being shadowed. --- src/core/obj.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/obj.js b/src/core/obj.js index 3581e57aa..19aa890b9 100644 --- a/src/core/obj.js +++ b/src/core/obj.js @@ -168,7 +168,7 @@ var Catalog = (function CatalogClosure() { 'page count in top level pages object is not an integer' ); // shadow the prototype getter - return shadow(this, 'num', obj); + return shadow(this, 'numPages', obj); }, get destinations() { function fetchDestination(dest) {