From a429e88c3bf8727aeb6412dd2afbd197c9b76e11 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Wed, 1 Oct 2014 11:42:06 +0200 Subject: [PATCH] Fix inconsistencies in the preference names used by PDFViewerApplication Since `preferenceSidebarViewOnLoad` is an enumeration value, it seems better to initialize it with the default one instead of a boolean. `preferencesPdfBugEnabled` uses a superfluous "s", which is a typo I made when I introduced it. --- web/viewer.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/web/viewer.js b/web/viewer.js index ea07765ab..d4b449df9 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -104,8 +104,8 @@ var PDFViewerApplication = { animationStartedPromise: null, mouseScrollTimeStamp: 0, mouseScrollDelta: 0, - preferenceSidebarViewOnLoad: false, - preferencesPdfBugEnabled: false, + preferenceSidebarViewOnLoad: SidebarView.NONE, + preferencePdfBugEnabled: false, isViewerEmbedded: (window.parent !== window), url: '', @@ -222,7 +222,7 @@ var PDFViewerApplication = { self.preferenceSidebarViewOnLoad = value; }), Preferences.get('pdfBugEnabled').then(function resolved(value) { - self.preferencesPdfBugEnabled = value; + self.preferencePdfBugEnabled = value; }), Preferences.get('disableTextLayer').then(function resolved(value) { if (PDFJS.disableTextLayer === true) { @@ -1485,7 +1485,7 @@ function webViewerInitialized() { //#if !PRODUCTION if (true) { //#else -//if (PDFViewerApplication.preferencesPdfBugEnabled) { +//if (PDFViewerApplication.preferencePdfBugEnabled) { //#endif // Special debugging flags in the hash section of the URL. var hash = document.location.hash.substring(1);