Browse Source

Remove ids from viewer page and thumbnail divs

The id, and parsing it for the page number, is replaced by the
data-page-number attribute (added here for thumbnails).
Dave House 8 years ago
parent
commit
52360694b0
No known key found for this signature in database
GPG Key ID: 28734DBB852AB21D
  1. 1
      web/pdf_page_view.js
  2. 2
      web/pdf_thumbnail_view.js
  3. 3
      web/pdf_thumbnail_viewer.js

1
web/pdf_page_view.js

@ -112,7 +112,6 @@ var PDFPageView = (function PDFPageViewClosure() {
this.annotationLayer = null; this.annotationLayer = null;
var div = document.createElement('div'); var div = document.createElement('div');
div.id = 'pageContainer' + this.id;
div.className = 'page'; div.className = 'page';
div.style.width = Math.floor(this.viewport.width) + 'px'; div.style.width = Math.floor(this.viewport.width) + 'px';
div.style.height = Math.floor(this.viewport.height) + 'px'; div.style.height = Math.floor(this.viewport.height) + 'px';

2
web/pdf_thumbnail_view.js

@ -124,8 +124,8 @@ var PDFThumbnailView = (function PDFThumbnailViewClosure() {
this.anchor = anchor; this.anchor = anchor;
var div = document.createElement('div'); var div = document.createElement('div');
div.id = 'thumbnailContainer' + id;
div.className = 'thumbnail'; div.className = 'thumbnail';
div.setAttribute('data-page-number', this.id);
this.div = div; this.div = div;
if (id === 1) { if (id === 1) {

3
web/pdf_thumbnail_viewer.js

@ -87,7 +87,8 @@ var PDFThumbnailViewer = (function PDFThumbnailViewerClosure() {
if (selected) { if (selected) {
selected.classList.remove('selected'); selected.classList.remove('selected');
} }
var thumbnail = document.getElementById('thumbnailContainer' + page); var thumbnail = document.querySelector(
'div.thumbnail[data-page-number="' + page + '"]');
if (thumbnail) { if (thumbnail) {
thumbnail.classList.add('selected'); thumbnail.classList.add('selected');
} }

Loading…
Cancel
Save