Browse Source

Prevent Firefox from warning about |unreachable code after return statement|

*This is a follow-up to PR 5966.*

Now that https://bugzilla.mozilla.org/show_bug.cgi?id=1151931 has landed, we're unfortunately in a situation where Firefox warns about `unreachable code after return statement` multiple times when using the PDF.js code in `node make server` mode.

I'm really sorry about the churn in this code!
However I don't think it's a good idea to let Firefox continue to printing these warnings in the console, since it increases the risk of missing actual errors.
Jonas Jenwald 10 years ago
parent
commit
66b12974c9
  1. 32
      web/viewer.js

32
web/viewer.js

@ -598,10 +598,12 @@ var PDFViewerApplication = {
}, },
fallback: function pdfViewFallback(featureId) { fallback: function pdfViewFallback(featureId) {
//#if !(FIREFOX || MOZCENTRAL) //#if !PRODUCTION
/* jshint -W027 */ if (true) {
return; return;
//#else }
//#endif
//#if (FIREFOX || MOZCENTRAL)
// Only trigger the fallback once so we don't spam the user with messages // Only trigger the fallback once so we don't spam the user with messages
// for one PDF. // for one PDF.
if (this.fellback) { if (this.fellback) {
@ -1037,8 +1039,9 @@ var PDFViewerApplication = {
} }
//#if !PRODUCTION //#if !PRODUCTION
/* jshint -W027 */ if (true) {
return; return;
}
//#endif //#endif
//#if (FIREFOX || MOZCENTRAL) //#if (FIREFOX || MOZCENTRAL)
var versionId = String(info.PDFFormatVersion).slice(-1) | 0; var versionId = String(info.PDFFormatVersion).slice(-1) | 0;
@ -1316,8 +1319,9 @@ var PDFViewerApplication = {
} }
//#if !PRODUCTION //#if !PRODUCTION
/* jshint -W027 */ if (true) {
return; return;
}
//#endif //#endif
//#if (FIREFOX || MOZCENTRAL) //#if (FIREFOX || MOZCENTRAL)
FirefoxCom.request('reportTelemetry', JSON.stringify({ FirefoxCom.request('reportTelemetry', JSON.stringify({
@ -1694,8 +1698,9 @@ document.addEventListener('pagerendered', function (e) {
} }
//#if !PRODUCTION //#if !PRODUCTION
/* jshint -W027 */ if (true) {
return; return;
}
//#endif //#endif
//#if (FIREFOX || MOZCENTRAL) //#if (FIREFOX || MOZCENTRAL)
FirefoxCom.request('reportTelemetry', JSON.stringify({ FirefoxCom.request('reportTelemetry', JSON.stringify({
@ -1716,8 +1721,9 @@ document.addEventListener('textlayerrendered', function (e) {
var pageView = PDFViewerApplication.pdfViewer.getPageView(pageIndex); var pageView = PDFViewerApplication.pdfViewer.getPageView(pageIndex);
//#if !PRODUCTION //#if !PRODUCTION
/* jshint -W027 */ if (true) {
return; return;
}
//#endif //#endif
//#if (FIREFOX || MOZCENTRAL) //#if (FIREFOX || MOZCENTRAL)
if (pageView.textLayer && pageView.textLayer.textDivs && if (pageView.textLayer && pageView.textLayer.textDivs &&
@ -1805,7 +1811,7 @@ window.addEventListener('hashchange', function webViewerHashchange(evt) {
} }
}); });
//#if !(FIREFOX || MOZCENTRAL || CHROME) //#if GENERIC
window.addEventListener('change', function webViewerChange(evt) { window.addEventListener('change', function webViewerChange(evt) {
var files = evt.target.files; var files = evt.target.files;
if (!files || files.length === 0) { if (!files || files.length === 0) {

Loading…
Cancel
Save