From 6cb77d65809babc94f96e7758789b29da8769a91 Mon Sep 17 00:00:00 2001 From: Xiliang Chen Date: Thu, 21 Jan 2016 11:39:30 +1300 Subject: [PATCH] fix outline may jump to previous page issue --- web/pdf_viewer.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/web/pdf_viewer.js b/web/pdf_viewer.js index 46ee55d99..a771cf636 100644 --- a/web/pdf_viewer.js +++ b/web/pdf_viewer.js @@ -627,7 +627,13 @@ var PDFViewer = (function pdfViewer() { pageView.viewport.convertToViewportPoint(x + width, y + height) ]; var left = Math.min(boundingRect[0][0], boundingRect[1][0]); - var top = Math.min(boundingRect[0][1], boundingRect[1][1]); + // Some pdf generator will generate a large top value (e.g. 10000) + // for outline destination + // which exceeds the hight of the page + // Therefore we have to ensure top is not less 0 + // otherwise viewer will scroll to previous page + // See PR 6903 and bug 874482 for more discussion + var top = Math.max(Math.min(boundingRect[0][1], boundingRect[1][1]), 0); scrollIntoView(pageView.div, { left: left, top: top }); },