Browse Source

Actually skip pages included in the `skipPages` array when running tests, rather than creating empty 1x1 canvases (issue 8241)

Considering how extremely simple this patch turned out to be, I'm almost worried that I completely misunderstood why the current code looks like it does...
Jonas Jenwald 8 years ago
parent
commit
9d62ff80ca
  1. 15
      test/driver.js

15
test/driver.js

@ -446,18 +446,9 @@ var Driver = (function DriverClosure() { // eslint-disable-line no-unused-vars
if (task.skipPages && task.skipPages.indexOf(task.pageNum) >= 0) { if (task.skipPages && task.skipPages.indexOf(task.pageNum) >= 0) {
this._log(' Skipping page ' + task.pageNum + '/' + this._log(' Skipping page ' + task.pageNum + '/' +
task.pdfDoc.numPages + '... '); task.pdfDoc.numPages + '...\n');
task.pageNum++;
// Empty the canvas this._nextPage(task);
this.canvas.width = 1;
this.canvas.height = 1;
ctx = this.canvas.getContext('2d', {alpha: false});
ctx.save();
ctx.fillStyle = 'white';
ctx.fillRect(0, 0, 1, 1);
ctx.restore();
this._snapshot(task, '');
return; return;
} }

Loading…
Cancel
Save