Merge pull request #6679 from Snuffleupagus/better-openExternalLinksInNewWindow-deprecation-comments

Improve the comment and deprecation warning for `PDFJS.openExternalLinksInNewWindow`

src/display/api.js

@@ -173,6 +173,9 @@ PDFJS.maxCanvasPixels = (PDFJS.maxCanvasPixels === undefined ?
 /**
  * (Deprecated) Opens external links in a new window if enabled.
  * The default behavior opens external links in the PDF.js window.
+ *
+ * NOTE: This property has been deprecated, please use
+ *       `PDFJS.externalLinkTarget = PDFJS.LinkTarget.BLANK` instead.
  * @var {boolean}
  */
 PDFJS.openExternalLinksInNewWindow = (

src/shared/util.js

@@ -360,10 +360,10 @@ var LinkTargetStringMap = [
 ];
 
 function isExternalLinkTargetSet() {
-//#if GENERIC
+//#if !MOZCENTRAL
   if (PDFJS.openExternalLinksInNewWindow) {
-    warn('PDFJS.openExternalLinksInNewWindow is deprecated, ' +
+    deprecated('PDFJS.openExternalLinksInNewWindow, please use ' +
-         'use PDFJS.externalLinkTarget instead.');
+               '"PDFJS.externalLinkTarget = PDFJS.LinkTarget.BLANK" instead.');
     if (PDFJS.externalLinkTarget === LinkTarget.NONE) {
       PDFJS.externalLinkTarget = LinkTarget.BLANK;
     }