Too rash. Fixes gjslint errors

web/viewer.js

@@ -26,7 +26,7 @@ var Cache = function cacheCache(size) {
 };
 
 // Settings Manager - This is a utility for saving settings
-// First we see if localStorage is available, which isn't pt. in FF due to bug #495747
+// First we see if localStorage is available, FF bug #495747
 // If not, we use FUEL in FF and fallback to Cookies for other browsers.
 var Settings = (function settingsClosure() {
   var isCookiesEnabled = (function() {
@@ -53,15 +53,17 @@ var Settings = (function settingsClosure() {
         localStorage.setItem(name, val);
       } else if (isCookiesEnabled) {
         var cookieString = name + '=' + escape(val);
-        var expire = (new Date((new Date().getTime())+1000*60*60*24*365)).toGMTString();
+        var expire = new Date();
-        cookieString += '; expires='+expire;
+        expire.setTime(expire.getTime() + 1000 * 60 * 60 * 24 * 365);
+        cookieString += '; expires=' + expire.toGMTString();
         document.cookie = cookieString;
       }
     },
 
     get: function settingsGet(name, defaultValue) {
       if (location.protocol == 'chrome:' && !isLocalStorageEnabled) {
-        return Application.prefs.getValue(extPrefix + '.' + name, defaultValue); 
+        var preferenceName = extPrefix + '.' + name;
+        return Application.prefs.getValue(preferenceName, defaultValue);
       } else if (isLocalStorageEnabled) {
         return localStorage.getItem(name) || defaultValue;
       } else if (isCookiesEnabled) {
@@ -885,10 +887,8 @@ function updateViewarea() {
 
 window.addEventListener('scroll', function webViewerScroll(evt) {
   updateViewarea();
-  var id;
+  var fingerprint = PDFView.pages[0].content.pdf.fingerprint;
-  if((id = PDFView.pages[0].content.pdf.fingerprint)) {
+  Settings.set(fingerprint + '.scroll', window.pageYOffset);
-    Settings.set(id+'.scroll', window.pageYOffset);
-  }
 }, true);