Browse Source

Merge pull request #8028 from Snuffleupagus/tests-prevent-console-errors

Prevent browser console errors during testing
Tim van der Meij 8 years ago committed by GitHub
parent
commit
ec26a7e565
  1. 5
      src/display/font_loader.js
  2. 4
      test/driver.js
  3. 10
      test/font/fontutils.js
  4. 3
      test/unit/testreporter.js

5
src/display/font_loader.js

@ -61,7 +61,10 @@ FontLoader.prototype = { @@ -61,7 +61,10 @@ FontLoader.prototype = {
clear: function fontLoaderClear() {
var styleElement = this.styleElement;
if (styleElement) {
styleElement.parentNode.removeChild(styleElement);
if (styleElement.parentNode) {
// Prevent "TypeError: styleElement.parentNode is null" during testing.
styleElement.parentNode.removeChild(styleElement);
}
styleElement = this.styleElement = null;
}
if (typeof PDFJSDev === 'undefined' || !PDFJSDev.test('MOZCENTRAL')) {

4
test/driver.js

@ -251,7 +251,7 @@ var rasterizeAnnotationLayer = (function rasterizeAnnotationLayerClosure() { @@ -251,7 +251,7 @@ var rasterizeAnnotationLayer = (function rasterizeAnnotationLayerClosure() {
/**
* @class
*/
var Driver = (function DriverClosure() {
var Driver = (function DriverClosure() { // eslint-disable-line no-unused-vars
/**
* @constructs Driver
* @param {DriverOptions} options
@ -685,5 +685,3 @@ var Driver = (function DriverClosure() { @@ -685,5 +685,3 @@ var Driver = (function DriverClosure() {
return Driver;
})();
exports.Driver = Driver;

10
test/font/fontutils.js

@ -19,7 +19,7 @@ @@ -19,7 +19,7 @@
var base64alphabet =
'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=';
function decodeFontData(base64) {
function decodeFontData(base64) { // eslint-disable-line no-unused-vars
var result = [];
var bits = 0, bitsLength = 0;
@ -62,7 +62,7 @@ function encodeFontData(data) { @@ -62,7 +62,7 @@ function encodeFontData(data) {
return buffer;
}
function ttx(data, callback) {
function ttx(data, callback) { // eslint-disable-line no-unused-vars
var xhr = new XMLHttpRequest();
xhr.open('POST', '/ttx');
@ -82,13 +82,9 @@ function ttx(data, callback) { @@ -82,13 +82,9 @@ function ttx(data, callback) {
xhr.send(encodedData);
}
function verifyTtxOutput(output) {
function verifyTtxOutput(output) { // eslint-disable-line no-unused-vars
var m = /^<error>(.*?)<\/error>/.exec(output);
if (m) {
throw m[1];
}
}
exports.decodeFontData = decodeFontData;
exports.ttx = ttx;
exports.verifyTtxOutput = verifyTtxOutput;

3
test/unit/testreporter.js

@ -1,5 +1,6 @@ @@ -1,5 +1,6 @@
'use strict';
// eslint-disable-next-line no-unused-vars
var TestReporter = function(browser, appPath) {
function send(action, json, cb) {
var r = new XMLHttpRequest();
@ -74,5 +75,3 @@ var TestReporter = function(browser, appPath) { @@ -74,5 +75,3 @@ var TestReporter = function(browser, appPath) {
setTimeout(sendQuitRequest, 500);
};
};
exports.TestReporter = TestReporter;

Loading…
Cancel
Save