pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	e229c21ce1	Remove unnecessary `xref` parameters from various method signatures in `PartialEvaluator`, since `this.xref` is already available in the relevant scope For reasons I don't pretend to understand, we're passing around `xref` arguments to a bunch of methods despite `this.xref` being available in `PartialEvaluator`. This patch is a small first small step towards cleaning up the, often unwieldy, signatures of methods in `PartialEvaluator`.	8 years ago
Jonas Jenwald	e40fd63bd3	In `src/core/evaluator.js`, convert a couple of `if (!someVariable) { error(...); }` instances to `assert(someVariable);` instead Rather than, in a number of places, basically duplicating the logic of `assert` we can simply utilize the function directly instead.	8 years ago
Jonas Jenwald	5c0c122a7d	Ensure that the `XMLHttpRequest` is `open`ed before attempting to set the `responseType` in the `DOMCMapReaderFactory`, since IE fails otherwise (issue 8193) I really cannot understand why this change is necessary, since modern browsers such as Firefox and Chrome work just fine with the old code. Hence this is patch is yet another "hack" that's needed just because IE apparently cannot just work like you'd expect. For consistency, the Node factory used in the CMap unit-tests is changed as well. Fixes 8193.	8 years ago
Jonas Jenwald	3705e5e459	Use a proper `MessageHandler` for `PartialEvaluator.getTextContent` to avoid errors for fonts relying on built-in CMap files (PR 8064 follow-up) My apologies for inadvertently breaking this in PR 8064; apparently we don't have any tests that cover this use-case :( Without this patch `getTextContent` will fail if called before `getOperatorList`, since loading of fonts during text-extraction may require fetching of built-in CMap files. Please note: The `text` test added here, which uses an already existing PDF file, fails without this patch.	8 years ago
Rob Wu	49af56f730	Rethrow MissingDataException when needed In core/document.js: `PDFDocument.prototype.parse` accesses a dictionary property, which could throw if the underlying data is not yet available. In core/obj.js: `get Catalog.prototype.metadata` calls `stream.getBytes`, which can throw MissingDataException too when the stream is a ChunkedStream.	8 years ago
Jonas Jenwald	8527d27eae	Ensure that `PDFDocument.documentInfo` doesn't fail during document load, when the entire XRef table hasn't been fetched yet (issue 8180) Similar to other `try-catch` statements in `/core` code, we must re-throw `MissingDataException` to prevent issues with missing data during document loading. Note that I'm not sure if/how we can test this, which is why the patch doesn't include any test(s). Fixes 8180.	8 years ago
Jonas Jenwald	d6d0f778aa	Don't read past the EOI marker for JPEG images with non-default restart interval (issue 7828) After browsing through (a version of) the JPEG specification, see https://www.w3.org/Graphics/JPEG/itu-t81.pdf, I hope that this patch makes sense. Note that while issue 7828 became a problem after PR 7661, it isn't really a regression from than PR. The explanation is rather that we're now relying on `core/jpg.js` instead of the Native Image decoder in more situations than before, which thus exposed an existing issue in our JPEG decoder. Another factor also seems to be that in many JPEG images, the DRI (Define Restart Interval) marker isn't present, in which case this bug won't manifest either. According to https://www.w3.org/Graphics/JPEG/itu-t81.pdf#page=89 (at the bottom of the page): "NOTE – The final restart interval may be smaller than the size specified by the DRI marker segment, as it includes only the number of MCUs remaining in the scan." Furthermore, according to https://www.w3.org/Graphics/JPEG/itu-t81.pdf#page=39 (in the middle of the page): "[...] If restart is enabled and the restart interval is defined to be Ri, each entropy-coded segment except the last one shall contain Ri MCUs. The last one shall contain whatever number of MCUs completes the scan." Based on the above, it thus seem to me that we should simply ensure that we're not attempting to continue to parse Scan data once we've found all MCUs (Minimum Coded Unit) of the image. Fixes 7828.	8 years ago
Jonas Jenwald	be1a6f294f	Try to recover when encountering JPEG markers with too short marker lengths (issue 8169) The issue with the JPEG image in question, is that the COM (Comment) marker has an incorrect length entry. Fixes 8169.	8 years ago
Jonas Jenwald	a7c19d9cbb	Adjust the `yoda` ESLint rule to apply to inequalities as well I happened to notice that some inequalities had the wrong order, and was surprised since I thought that the `yoda` rule should have caught that. However, reading http://eslint.org/docs/rules/yoda#options a bit more closely than previously, it's quite obvious that the `onlyEquality` option does exactly what its name suggests. Hence I think that it makes sense to adjust the options such that only ranges are allowed instead.	8 years ago
Jonas Jenwald	098a56270d	Normalize the `BBox` entry in Tiling Pattern dictionaries (issue 8117) According to the PDF specification, see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.3982967, the `BBox` entry should have the form `[left, bottom, right, top]`. Since some PDF generators apparently violates the specification, we normalize the `BBox` to ensure that the pattern is (correctly) rendered. Fixes 8117.	8 years ago
Tim van der Meij	936d3c0698	Widget annotations: do not crash if `Parent` is not a dictionary during field name construction (issue 8143)	8 years ago
Jason O. Jensen	d230784ac3	Handle cff fonts with erroneous stackSize	8 years ago
Jonas Jenwald	9bed87f5dc	Return `undefined` instead of `Dict.empty` from `Page.getInheritedPageProp` for non-existent properties to prevent possible future bugs This is something that I noticed while working on PR 8126, which is (more) fallout from PR 6065. In general, it's actually not correct to return `Dict.empty` as the default value for non-existent properties. Please note that a prior PR, see https://github.com/mozilla/pdf.js/pull/5957#issuecomment-103112698, asked for that behaviour but I don't think that's right. Obviously for properties that are (or should) be `Dict`s it makes sense, however certain properties can be e.g. Strings or Arrays instead. In the latter case, returning `Dict.empty` is just plain wrong, and it's quite fascinating that this hasn't caused any errors in practice. (The existing validation in the various getters has actually saved us here.) Also, when looking at this code again, it seemed unnecessary to duplicate the `MAX_LOOP_COUNT` check since we could just return immediately instead.	8 years ago
Yury Delendik	e7cc07cc11	Moves checkProblematicCharRanges to font_spec.js	8 years ago
Job van der Weiden	a05115d2ec	Network: use the current location to prevent errors when using CSP headers When using content security headers to restrict connections to the same origin, you may not make connections to `example.com`. This feature detection also works with a request to the current location.	8 years ago
Jonas Jenwald	4a0ff5dbf7	Ensure that we don't ignore `0` values in `Page.getInheritedPageProp` (issue 8125) It appears that I accidentally broke this in PR 6065, sorry about that! The issue in this particular PDF file is that there's `/Rotate` entries on different levels of the `/Pages` tree. We're supposed to use the `/Rotate` entry in the `/Page` dict (which is `0`), but because of an incorrect condition we instead ended up with the one from the `/Pages` dict (which is `180`). Fixes 8125.	8 years ago
Tim van der Meij	0739f90707	Annotations: move operator list addition logic to `src/core/document.js` Ideally, the `Annotation` class should not have anything to do with the page's operator list. How annotations are added to the page's operator list is logic that belongs in `src/core/document.js` instead where the operator list is constructed. Moreover, some comments have been added to clarify the intent of the code.	8 years ago
Jonas Jenwald	2a7e5b8a54	Support the `newWindow` flag in white-listed `app.launchURL` JavaScript actions (PR 7794 follow-up) A simple follow-up to PR 7794, which let's us add support for the `newWindow` parameter; refer to https://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/js_api_reference.pdf#G5.1507380. The patch also fixes an embarrassing oversight regarding the placement of the case-insensitive flag, and also allows arbitrary white-space at the beginning of JS actions.	8 years ago
Yury Delendik	5b50e0d414	Replaces RequireJS to SystemJS.	8 years ago
Tim van der Meij	8990de8614	Interactive forms: make choice widget options inheritable (issue 8094) Even though the PDF specification does not state that `Opt` fields are inheritable, in practice there are PDF generators that let annotations inherit the options from a parent.	8 years ago
Jonas Jenwald	14cc6acb90	Ensure that `Dict`s found in Object Streams are assigned an `objId` in `XRef.fetch` This fixes something that I noticed while working with the code in `Catalog.getPageDict` when debugging issue 8088. Note that while I don't have an example where this patch really matters, given that e.g. `PartialEvaluator.hasBlendModes` depends on the `objId` to avoid cyclic references this patch could potentially help for some PDF files.	8 years ago
Yury Delendik	51767d63fe	Init PDFWorker via MesssagePort.	8 years ago
Jonas Jenwald	1ce295541c	Always check all Kids nodes, in `Catalog.getPageDict`, to avoid getting stuck in an empty node further down in the Pages tree (issue 8088) As discussed on IRC, we need to check all nodes at the bottom of the tree to ensure that we find the correct `Page` dict. Furthermore, this patch also gets rid of the caching present in a previous version, since it's not clear if that really helps. Note that this patch purposely adds an `eq` test, using a reduced test-case, so that we can be sure that the algorithm actually finds the correct `Page` dict for each `pageIndex`. Fixes 8088.	8 years ago
Yury Delendik	facefb0c79	Move compatibility code to the shared/compatibility.js.	8 years ago
Jonas Jenwald	9082f08e37	Enable running the `cmap` unit-tests on Travis by utilizing a `NodeCMapReaderFactory`	8 years ago
Jonas Jenwald	111419a64a	Cache built-in binary CMap files in the worker (issue 4794)	8 years ago
Jonas Jenwald	769c1450b7	[api-minor] Refactor fetching of built-in CMaps to utilize a factory on the `display` side instead, to allow users of the API to provide a custom CMap loading factory (e.g. for use with Node.js) Currently the built-in CMap files are loaded in `src/core/cmap.js` using `XMLHttpRequest` directly. For some environments that might be a problem, hence this patch refactors that to instead use a factory to load built-in CMaps on the main thread and message the data to the worker thread. This is inspired by other recent work, e.g. the addition of the `CanvasFactory`, and to a large extent on the IRC discussion starting at http://logs.glob.uno/?c=mozilla%23pdfjs&s=12+Oct+2016&e=12+Oct+2016#c53010.	8 years ago
Tim van der Meij	26fc79d51d	Annotations: refactor setting the normal appearance stream Previously, we had a function called `getDefaultAppearance`. This name, however, is misleading as the method gets the normal appearance (in the `N` entry) and not the default appearance (in the `DA` entry). Moreover, it was not entirely clear how it works just from reading the code. It primarily lacks comments and explicit error case handling. This patch improves the situation by fixing the issues mentioned above and making this function a proper method of the `Annotation` class, just like e.g., `setColor` and `setBorderStyle`.	8 years ago
Jonas Jenwald	ce072022c1	Always choose a (3, 1) cmap table for TrueType fonts that have an encoding specified, regardless of the Symbolic font flag (bug 1337429) This patch basically reverts one aspect of TrueType (3, 1) cmap parsing to the state prior to PR 4259. After that PR, a number of regressions occurred in this particular code-path, which necessitated a number of follow-ups such as PRs 5703, 5743, and 6425. The empirical data suggests, at least to me, that we should always prefer a (3, 1) cmap for TrueType fonts when they have an encoding, regardless of the Symbolic font flag. Obviously this patch passes all unit/font/reference tests locally, and I made sure that all the PRs mentioned above landed with test-cases included. However, in my opinion, there's still a very real possibility that this patch could potentially cause new regressions. Given that the PDF file in bug 1337429 has been broken for almost three years before anyone noticed, and considering that the code-path in question has been the source of numerous regressions, I do not intend to request uplift of this patch to previous Firefox versions (assuming that it's even accepted). Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1337429.	8 years ago
Yury Delendik	fa0e559fe2	New node.js check to protect from webpack.	8 years ago
Jonas Jenwald	23c62cc321	Consume the current character when encountering illegal characters in `Lexer.getObject`, in order to prevent infinite loops during reading of streams (issue 8061) Please note: The rendering of the PDF file in issue 8061 first regressed in PR 7039, and then PR 7493 exacerbated the problem even further by causing an infinite loop. In this particular case, when errors were encountered inside of the `Lexer.getObject` method itself, we didn't advance the stream position. This thus caused an inifinite loop in `parseCMap`, since the exact same character was then parsed over and over again. Fixes 8061.	8 years ago
pmysore1	af8292058f	Font ascent descent calculation fix	8 years ago
Yury Delendik	7d9941d870	Fixes pdf.combined.js for webpack.	8 years ago
Jonas Jenwald	63f13773e7	Use `ChildNode.remove` instead of `ChildNode.ParentNode.removeChild` in a couple of places (bug 1334831, issue 8008) Re: [bug 1334831](https://bugzilla.mozilla.org/show_bug.cgi?id=1334831) and issue 8008. Note that according to the specification, see https://dom.spec.whatwg.org/#interface-childnode, the `remove` method shouldn't throw. This is also consistent with e.g. the Firefox implementation, see http://searchfox.org/mozilla-central/rev/d3307f19d5dac31d7d36fc206b00b686de82eee4/dom/base/nsINode.cpp#1852. Obviously this isn't supported in IE (because that would be too easy), however we can easily polyfill it to avoid having to WONTFIX the bug/issue.	8 years ago
Yury Delendik	a048519fa1	Replace copyright headers; changes UMD to CommonJS.	8 years ago
Yury Delendik	eb4c88cd44	Replacing custom bundling with webpack2.	8 years ago
vkuryakov	4e181e59ef	Interactive forms: values for radio buttons (issue #6995 )	8 years ago
Mukul Mishra	41d092d04b	Fixes behaviour of DOMCanvasFactory to return {canvas, context}.	8 years ago
Jonas Jenwald	9c34d0aa8c	[api-minor] Add a `getDocument` parameter that allows disabling of the `NativeImageDecoder` (e.g. for use with Node.js) Note that I initially tried to add this as a parameter to the `PDFPageProxy.render` method, such that it could be passed to `PartialEvaluator.getOperatorList`. However, given all the different code-paths that call `getOperatorList` (there's a bunch only in `annotation.js`), this seemed to very quickly become unwieldy and thus difficult to maintain compared to simply using the existing `evaluatorOptions`.	8 years ago
Mukul Mishra	32817633c9	Fix #7798 : Refactor scratch canvas usage. Fixes extra canvas create calls. Fixes unnecessary call of `new DOMCanvasFactory`. Fixes undefined error of DOMCanvasFactory. Fixes failures in some of the tests. Fixes expected behaviour. Remove unused vars.	8 years ago
Jonas Jenwald	e416032b38	Prevent browser console errors during testing The `Driver._cleanup` method is removing all stylesheets between test runs, which causes "TypeError: styleElement.parentNode is null" console errors in `FontLoader.clear`. As can also be seen during various tests, some of the changes I made in PR 7972 unfortunately causes console errors. It seems that I didn't test this properly, since it should have been obvious to me that while tests are triggered using Node.js, the files in question are run within the browser. My apologies for not testing this thoroughly, and for causing unnecessary churn in the code!	8 years ago
Jonas Jenwald	bc736fdc7d	Adjust the `brace-style` ESLint rule to disallow single lines (and also enable `no-iterator`) See http://eslint.org/docs/rules/brace-style. Having the opening/closing braces on the same line can often make the code slightly more difficult to read, in particular for `if`/`else if` statements, compared to using new lines. This patch also, for consistency with `mozilla-central`, enables the [`no-iterator`](http://eslint.org/docs/rules/no-iterator) rule. Note that this rule didn't require a single code change.	8 years ago
Jonas Jenwald	f7d99ccc26	Remove the unused `isStream` property on various `Stream`s This property was added all the way back in PR 542, but hasn't actually been relied upon ever since PR 692. Note that there's a `isStream()` utility function which replaced the property years ago, hence the `isStream` property is now dead code.	8 years ago
Jonas Jenwald	c102232275	Append the contents of `FileAttachment` annotations to the attachments view of the sidebar, for easier access to the embedded files Other PDF viewers, e.g. Adobe Reader, seem to append `FileAttachment`s to their attachments views. One obvious difference in PDF.js is that we cannot append all the annotations on document load, since that would require parsing every page. Despite that, it still seems like a good idea to add `FileAttachment`s, since it's thus possible to access all the various types of attachments from a single place. Note: With the previous patch we display a notification when a `FileAttachment` is added to the sidebar, which thus makes appending the contents of these annotations to the sidebar slightly more visible/useful.	8 years ago
Tim van der Meij	95732279b6	Remove usage of `mozFillRule` The non-standard `mozFillRule` has been removed in Firefox 51 [1, 2]. Instead, a parameter of the standard methods should be used. Note that this is supported in all major browsers for a long time now, so there should be no need keeping this Firefox-specific code around. [1] https://developer.mozilla.org/en-US/Firefox/Releases/51 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=826619	8 years ago
Jonas Jenwald	52e0f51917	Enable the `no-unused-vars` ESLint rule Please see http://eslint.org/docs/rules/no-unused-vars; note that this patch purposely uses the same rule options as in `mozilla-central`, such that it fixes part of issue 7957. It wasn't, in my opinion, entirely straightforward to enable this rule compared to the already existing rules. In many cases a `var descriptiveName = ...` format was used (more or less) to document the code, and I choose to place the old variable name in a trailing comment to not lose that information. I welcome feedback on these changes, since it wasn't always entirely easy to know what changes made the most sense in every situation.	8 years ago
Jonas Jenwald	50c2856097	Move `EOF`/`isEOF` from core/parser.js to core/primitives.js Given the nature of `EOF` and `isEOF`, it seems to me that they really ought to be placed in `core/primitives.js` instead. In general, it doesn't seem great to have to depend on the entire `core/parser.js` file for such simple primitives/helper functions. In particular, while `core/ps_parser.js` is completely separate from `core/parser.js` with regards to its function, it still depends on the latter for just one primitive. Note that compared to e.g. PR 7389, this will not reduce the number of dependencies for `core/ps_parser`, however the new dependency IMHO makes more sense.	8 years ago
Jonas Jenwald	f000417ce0	[Firefox addon] Stop bundling `src/core/network.js` into the `FIREFOX`/`MOZCENTRAL` builds (PR 7322 follow-up) PR 7322 added the `PdfJsNetwork.jsm` file, instead of the general `src/core/network.js` file for the Firefox addon. However, `make.js` wasn't updated to actually stop including the now obsolete network file.	8 years ago
Jonas Jenwald	f77c52291e	Enable the `no-empty-pattern`/`no-floating-decimal`/`no-self-compare`/`no-delete-var`/`no-new-object` ESLint rules The following rules required no code changes: http://eslint.org/docs/rules/no-empty-pattern http://eslint.org/docs/rules/no-floating-decimal http://eslint.org/docs/rules/no-delete-var http://eslint.org/docs/rules/no-new-object There was just one change needed in order to enable: http://eslint.org/docs/rules/no-self-compare; which I think helps readability a lot, since that comparison makes no sense until you realize that we push `NaN` onto the `stack` in some cases and furthermore that `NaN !== NaN`.	8 years ago
Yury Delendik	fc2d8c15e8	Adds noopener and nofollow to rel attribute of hyperlinks.	8 years ago

1 2 3 4 5 ...

2770 Commits (0423bb69e92173f3018adc81fb9b59bee071c987)