pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	fce31c3f83	Ensure that the loadingBar isn't displayed again when the entire file has already been fetched This could only (potentially) happen when `disableAutoFetch` is used.	8 years ago
Jonas Jenwald	20d6286cce	Add support for, the API property, PageMode in the viewer (issue 8657) Note that the PageMode, as specified in the API, will only be honoured when either: the user hasn't set the `sidebarViewOnLoad` preference to a non-default value, or a non-default `sidebarView` entry doesn't exist in the view history, or the "pagemode" hash parameter is included in the URL. Since this is new functionality, the patch also includes a preference (`disablePageMode`), to make it easy to opt-out of this functionality if the user/implementor so wishes.	8 years ago
Jonas Jenwald	f7c4ed4bc3	Refactor reading from the `ViewHistory` in `PDFViewerApplication.load`	8 years ago
Jonas Jenwald	e1536251d5	Convert `PDFViewer` to an ES6 class	8 years ago
Jonas Jenwald	49333ddd44	Move the `hasEqualPageSizes` getter from `PDFViewerApplication` and into `PDFViewer` instead Since the method needs to access properties that are directly available inside of `PDFViewer`, it seems simpler to just have it live there.	8 years ago
Rob Wu	19549bb7d6	[CRX] Integrate cursorToolOnLoad pref + migration logic Add UI for the cursorToolOnLoad pref in the UI of the Chrome extension. Add logic to migrate the enableHandToolOnLoad pref to cursorToolOnLoad. For past values in the mutable extension storage area: 1. If enableHandToolOnLoad=true, save cursorToolOnLoad=1. 2. Remove enableHandToolOnLoad. For the managed extension storage, which is immutable since it is based on administrative policies, use the following logic: 1. If enableHandToolOnLoad=true and cursorToolOnLoad=0 (default). set cursorToolOnLoad=0 and assume enableHandToolOnLoad=false. 2. As usual, managed preferences can (and will) be overridden by the user. The first migration logic is in extensions/chromium/options/migration.js and can be removed after a few months / less than many years. The second migration logic is in web/chromecom.js, and should be kept around for a long while (many years). The need for this migration logic arises from the change by: https://github.com/mozilla/pdf.js/pull/7635	8 years ago
Jonas Jenwald	8ba8072937	Convert `PDFLinkService` to an ES6 class	8 years ago
Christian Myksvoll	95093a5276	Check for undefined url (#8640 ) * Check for undefined new URL(file, window.location.href) throws the following error in IE11 + iPad Safari: Unable to get property 'replace' of undefined or null reference * Adapting previous change to pdf.js code standards Added curly braces * Moved check for undefined above try/catch	8 years ago
Yury Delendik	52460687ca	Fixes pdf.js library source detection.	8 years ago
Nimesh Solanki	e004b3cfab	update inconsistent names	8 years ago
Rob Wu	742ed3d1c9	Remove __pdfjsdev_webpack__, use webpack options `__pdfjsdev_webpack__` was used to skip evaluating part of an AST, in order to not mangle some `require` symbols. This commit removes `__pdfjsdev_webpack__`, and: - Uses `__non_webpack_require__` when one wants the output to contain `require` instead of `__webpack_require__`. - Adds options to the webpack config to prevent "polyfills" for some Node.js-specific APIs to be added. - Use `// eslint-disable-next-line no-undef` instead of `/* globals ... */` for variables that are not meant to be used globally.	8 years ago
Jonas Jenwald	c253ee9ab8	Ensure that the document is rendered on load, no matter what happens, by always calling `PDFViewer.update` after the initial position has been set	8 years ago
Jonas Jenwald	8391aacb89	Remove the scale-not-initialized hack from `webViewerResize` (in app.js) Since we no longer, after PR 8555, allow changing the scale until the document is loaded, that hack is no longer necessary. Furthermore, no part of that event handling function needs to run unless a document is loaded. The reason that this hack was initially added, is that previously the `ViewHistory` might be updated before `PDFViewerApplication.setInitialView` had run (in some cases leading to incorrect inital document scale). Since that is no longer possible, this is now dead code.	8 years ago
Jonas Jenwald	9c95614bb6	Ensure that `PDFFindBar._adjustWidth` is called in all situations where the width of the findbar might have changed After PR 8394, where the l10n service was converted to be asynchronous, we're no longer calling `_adjustWidth` after updating the `findMsg` label. Hence it's currently possible that the width of the findbar won't be correct. The solution is simple though, just call `_adjustWidth` after the `findMsg` label has been (asynchronously) updated. Another existing issue, which was an oversight in PR 8132, is that `PDFFindBar.updateResultsCount` may be called directly from `PDFFindController`. In that case, we're not calling `_adjustWidth` at all, which means that the findbar may also not have the correct width. The simple solution here is to always call `_adjustWidth` at the end of `updateResultsCount` (which is why we no longer need the `_adjustWidth` call at the end of `updateUIState`).	8 years ago
Jonas Jenwald	cb0009dab4	Actually reset the `findResultsCount` label, in addition to hiding it, when no matches are found Currently we're only hiding the label, but not actually resetting it until a new match is found. Obviously it's being hidden, but it seems that it really ought to be completely reset as well (since e.g. `PDFFindBar.reset` won't technically reset all state otherwise).	8 years ago
Jonas Jenwald	614e8cf295	Change `var` to `let`, and use object destructuring, in a couple of previously class converted `web/*.js` files Note that these files were among the first to be converted to ES6 classes, so it probably makes sense to do another pass to bring them inline with the most recent ES6 conversions.	8 years ago
Jonas Jenwald	d64ac95a91	ES6-ify the code in `web/app.js` and `web/viewer.js` The changes consist mostly of changing `var` to `let`/`const`, and using shorthand method signatures.	8 years ago
Tim van der Meij	19f56ec5c1	Convert the text layer builder to ES6 syntax	8 years ago
Jonas Jenwald	f6369fc87c	ES6-ify the code in `web/ui_utils.js` These changes consists mainly of replacing `var` with `let`/`const`, adding a couple of default parameters to function signatures, and finally converting `EventBus`/`ProgressBar` to proper classes.	8 years ago
Jonas Jenwald	d4b93bec96	Remove the `selectScaleOption` helper function, in `Toolbar._updateUIState`, and simply inline its code instead After PR 8510, we now always lookup the localized `page_scale_percent` string to prevent any possible ordering issues. Since the scaleSelect dropdown is updated asynchronous, there's really no point in having a helper function any more, hence this code can rather be placed inline in `Toolbar._updateUIState`.	8 years ago
Jonas Jenwald	426e26c63b	Don't use a hidden canvas when constructing the `zoomLayer` in `PDFPageView.update` This is an existing issue that I noticed while testing PR 8552. When zooming or rotation occurs, we'll try to use the current canvas as a (CSS transformed) preview until the page has been completely re-drawn. If you manage to change the scale (or rotation) very quickly, it's possible that `PDFPageView.update` can be called before a previous `render` operation has progressed far enough to remove the `hidden` property from the canvas. The result is thus that a page may be entirely black during zooming or rotation, which doesn't look very good. This effect can be a bit difficult to spot, but it does manifest even in the default viewer.	8 years ago
Jonas Jenwald	83673a12d7	Stop tracking the rotation in `PDFViewerApplication` and directly use `PDFViewer.pagesRotation` instead Part of the rotation handling code, in what's now `web/app.js`, hasn't really changed since before the viewer was split into multiple files/components. Similar to other properties, such as current page/scale, we should probably avoid tracking state in multiple places. Hence I'm suggesting that we don't store the rotation in `PDFViewerApplication`, and access the value in `PDFViewer` instead. Since `PDFViewerApplication.pageRotation` has existed for a very long time, a getter was added to avoid outright breaking third-party code that may depend on it.	8 years ago
Jonas Jenwald	735b58c3d5	Don't allow setting various properties, such as `currentPageNumber`/`currentScale`/`currentScaleValue`/`pagesRotation`, before `{PDFViewer, PDFThumbnailViewer}.setDocument` has been called Currently a number of these properties do not work correctly if set before calling `setDocument`; please refer to the discussion starting in https://github.com/mozilla/pdf.js/pull/8539#issuecomment-309706629. Rather than trying to have some of these methods working, but not others, it seems much more consistent to simply always require that `setDocument` has been called.	8 years ago
Yury Delendik	18e1f3d29b	Ensure canvas is really hidden when used with pdfjs-dist. Avoids black background flickering in such examples as components/simpleviewer.html	8 years ago
Tim van der Meij	d4e0aa4031	Convert the toolbar to ES6 syntax	8 years ago
Jonas Jenwald	4aab3cef4a	Remove a redundant `PDFViewer.currentScale` call from `PDFViewerApplication.load` Since this call occurs before the `PDFViewer.setDocument` call, it won't actually cause any scale change. Furthermore, moving it should not be necessary, since the `scale` is already used as the fallback case in `PDFViewerApplication.setInitialView` (provided it's non-zero, which isn't even the case in the default viewer). Hence this patch should cause no functional changes at all, since it simply removes a piece of unnecessary code.	8 years ago
Mukul Mishra	0c13d0ff46	Adds Streams API in getTextContent to stream data. This patch adds Streams API support in getTextContent so that we can stream data in chunks instead of fetching whole data from worker thread to main thread. This patch supports Streams API without changing the core functionality of getTextContent. Enqueue textContent directly at getTextContent in partialEvaluator. Adds desiredSize and ready property in streamSink.	8 years ago
Jonas Jenwald	e4d032c5c7	Reset `pageRotation` and `downloadComplete` in `PDFViewerApplication.close` Currently, these properties are reset in what appears to be somewhat arbitrary locations (within the `load` and `open` methods respectively). The explanation is probably that both of these properties predates the existence of any centralized clean-up code in the viewer. Hence I think that it makes sense to move the resetting of these properties to the `close` method, since that improves the overview of what's actually cleaned-up/reset when changing documents in the viewer.	8 years ago
curiosity26	8326304271	Allow for unbinding of events in web application Hold bound event listeners for later unbinding ES6 styling More ES6 styling and code cleanup Remove 4 space indents and remove delete statements.	8 years ago
Jonas Jenwald	70d6550002	Remove `PDFPageView.updatePosition` since it's not actually necessary This method is currently called from `PDFViewer._scrollUpdate` on every scroll event in the viewer. However, I cannot see why this code is now necessary (assuming that it once was), since text-selection and searching still works exactly the same way with this patch as with the current `master`. When `PDFPageView.updatePosition` is called, the page can be in either of these states: 1. The page hasn't been rendered, in which case the `textLayer` property doesn't exist yet. 2. The page is currently rendering, meaning that the `textLayer` property exists. Given that the `textContent` won't be fetched until the page has been successfully rendered, `TextLayerBuilder.render` will return immediately and effectively be a no-op (since there's nothing to render yet). 3. The has been been rendered, and the `textLayer` is currently rendering. 4. The page, and its `textLayer`, has been completely rendered. In this case, `TextLayerBuilder.render` will return immediately and effectively be a no-op. Here, only the third case seem to require any further analysis: When scrolling occurs while the `textLayer` is rendering, `TextLayerBuilder.render` will via a helper method call `TextLayerRenderTask.cancel` (in src/display/text_layer.js) to stop processing. However, due to the run-to-completion nature of JavaScript, once `TextLayerRenderTask._render` has been invoked `appendText` will always run.[1] So even though we cancel rendering of pending `textLayer`s during scrolling, via the repeated `TextLayerBuilder.render` calls from within the `PDFPageView.updatePosition` method, that does not prevent us from running the code inside of `TextLayerRenderTask._render` over and over for the same page; which all seems very inefficient to me.[2] All this will thus have the effect of delaying the actual rendering of a `textLayer` ever so slightly while scrolling in the viewer. However, it does so at the expense of potentially hundreds of unnecessary `appendText` calls.[3] Hence it seems to me that it's less resource intensive overall to simply let rendering of the `textLayer` complete, once it has started. Obviously, we still abort all rendering of a page, and its `textLayer`, when it's being destroyed (e.g. by being evicted from the page cache). In case that there's any worry that the patch could affect e.g. highlighting of search results, please note that the existing code in `TextLayerBuilder.render` already calls `updateMatches` when the `TextLayerTask` resolves successfully. I'm sorry that this became quite long, but to try and summarize: `PDFPageView.updatePosition` doesn't actually do anything in most cases. In the one case where it matters, it seems that it's actually doing more harm than good; which is why I'm proposing that we just remove it. --- [1] Although we may be able to skip the `render` call, provided that it happens after a `timeout` (as is the case in the default viewer). [2] With current work being done to support streaming of `TextContent`, we'd also need to add just as many duplicate API calls to `PDFPageView.updatePosition`. [3] The number of duplicate `appendText` calls is directly proportional not only to the scroll speed, but also to the number of pages in the document.	8 years ago
Jonas Jenwald	75edb859ce	Refactor the `selectScaleOption` function, in `Toolbar._updateUIState`, to prevent any possible future display glitches Since the localization service is now asynchronous, depending on the load the browser is under, there's a small risk that the lookup of the 'page_scale_percent' string could be delayed slightly. If the scale would change a couple of times in very quick succession, there's perhaps a theoretical possibility that the Zoom dropdown would display an incorrect value. Consider the following, somewhat contrived, theoretical example of two zoom commands being executed right after one another: ```javascript PDFViewerApplication.pdfViewer.currentScale = 1.23; PDFViewerApplication.pdfViewer.currentScaleValue = 'page-width'; ``` Only the `currentScale` call will currently trigger a l10n lookup in `selectScaleOption`. However, as far as I understand, there's no guarantee that the l10n string is resolved before `selectScaleOption` is called again as a result of the `currentScaleValue` call. This thus has the possibility of putting the Zoom dropdown into an inconsistent state, since it's currently updated synchronously for one code-path and asynchronously for another. To avoid these issues, I'm proposing that we always update the Zoom dropdown asynchronously, such that we can guarantee that the ordering is correct.	8 years ago
Jonas Jenwald	2971f522d4	Prevent the Zoom dropdown from intermittently displaying an incorrect custom scale in Firefox (PR 8394 follow-up) After PR 8394, at least in Firefox, the Zoom dropdown now frequently displays an old custom scale instead of the correct one. To see this behaviour, the following STR works for me: 1. Open https://mozilla.github.io/pdf.js/web/viewer.html. 2. Zoom in, by clicking on the corresponding button in the toolbar. 3. Run `PDFViewerApplication.pdfViewer.currentScaleValue` in the console. 4. Compare what's displayed in the Zoom dropdown with what's printed in the console. (If no difference can be observed, try repeating steps 2 through 4 a couple of times.) I really don't understand why this happens, but it seems that waiting until a custom scale has been set before selecting it fixes things in Firefox (and works fine in e.g. Chrome as well). Note that this patch thus makes this particular piece of the code consistent with the state prior to PR 8394.	8 years ago
Jonas Jenwald	3f2d5cfcc3	Prevent console errors when clicking to change page while in Presentation Mode (issue 8498) The click handler used in Presentation Mode didn't check if the first/last page was already reached, which after PR 7529 now causes an unnecessary console error. Hence we should simply use the already existing `_goToPreviousPage`/`_goToNextPage` methods instead, since they do the necessary bounds checking. Fixes 8498.	8 years ago
Tim van der Meij	9a95d91b92	Convert the find controller to ES6 syntax Moreover, rename `FindStates` to `FindState` since enumeration names are usually not in plural, for readability and consistency with the ones in `src/shared/util.js`.	8 years ago
Tim van der Meij	733a58a315	Convert the thumbnail view to ES6 syntax	8 years ago
Tim van der Meij	a682d77e71	Convert the thumbnail viewer to ES6 syntax	8 years ago
Jonas Jenwald	223c429357	Fix inconsistent spacing and trailing commas in objects in `web/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/web/pdf_thumbnail_view.js b/web/pdf_thumbnail_view.js index 002dbf29..1de4e530 100644 --- a/web/pdf_thumbnail_view.js +++ b/web/pdf_thumbnail_view.js @@ -420,8 +420,8 @@ var PDFThumbnailView = (function PDFThumbnailViewClosure() { setPageLabel: function PDFThumbnailView_setPageLabel(label) { this.pageLabel = (typeof label === 'string' ? label : null); - this.l10n.get('thumb_page_title', { page: this.pageId, }, 'Page {{page}}'). - then((msg) => { + this.l10n.get('thumb_page_title', { page: this.pageId, }, + 'Page {{page}}').then((msg) => { this.anchor.title = msg; }); diff --git a/web/secondary_toolbar.js b/web/secondary_toolbar.js index 160e0410..6495fc5e 100644 --- a/web/secondary_toolbar.js +++ b/web/secondary_toolbar.js @@ -65,7 +65,8 @@ class SecondaryToolbar { { element: options.printButton, eventName: 'print', close: true, }, { element: options.downloadButton, eventName: 'download', close: true, }, { element: options.viewBookmarkButton, eventName: null, close: true, }, - { element: options.firstPageButton, eventName: 'firstpage', close: true, }, + { element: options.firstPageButton, eventName: 'firstpage', + close: true, }, { element: options.lastPageButton, eventName: 'lastpage', close: true, }, { element: options.pageRotateCwButton, eventName: 'rotatecw', close: false, }, @@ -76,7 +77,7 @@ class SecondaryToolbar { { element: options.cursorHandToolButton, eventName: 'switchcursortool', eventDetails: { tool: CursorTool.HAND, }, close: true, }, { element: options.documentPropertiesButton, - eventName: 'documentproperties', close: true, } + eventName: 'documentproperties', close: true, }, ]; this.items = { firstPage: options.firstPageButton, ```	8 years ago
Jonas Jenwald	1d4e96b0b5	Add a stub `createL10n` to `DefaultExternalServices` in app.js It appears that this was simply forgotten in PR 8394.	8 years ago
Yury Delendik	5438ce9b98	Wraps mozL10n to async calls; splits firefox and generic l10n libs.	8 years ago
Yury Delendik	66c8893815	Removes last UMDs from the modules.	8 years ago
Tim van der Meij	6dfdff2f03	Convert the page view to ES6 syntax	8 years ago
Jonas Jenwald	92529e2b11	Refactor the `getTempCanvas` function in `pdf_thumbnail_view.js` to a factory, in preparation for ES6 conversion of the thumbnail related code This patch intends to simplify future ES6 refactoring of the thumbnail code, since the current code isn't going to work well together with proper `Class`es.	8 years ago
Tim van der Meij	e7a04fc82d	Convert the overlay manager to ES6 syntax	8 years ago
Tim van der Meij	836695986c	Add icons for the new "Select tool" button Also adds the Dutch localizations for the new select/hand tool buttons.	8 years ago
Jonas Jenwald	36c2791296	Unify handling of various cursor tools, e.g. the current Hand Tool and a possible future Zoom Tool, in a new `PDFCursorTools` module With the current way that the `HandTool` is implemented, if someone would try to also add a Zoom tool (as issue 1260 asks for) that probably wouldn't work very well given that you'd then have two cursor tools which may not play nice together. Hence this patch, which attempts to refactor things so that it should be simpler to add e.g. a Zoom tool as well (given that that issue is marked as "good-beginner-bug", and I'm not sure if that really applies considering the current state of the code). Note that I personally have no interest in implementing a Zoom tool (similar to Adobe Reader) since I wouldn't use it, but I figured that it can't hurt to make this code a bit more future proof.	8 years ago
Jonas Jenwald	0ddf52aca5	Remove the special handling for `nameddest`s that look like standard pageNumbers PR 7341 added special handling for `nameddest`s that look like pageNumbers, to prevent issues since we previously incorrectly supported specifying a pageNumber directly in the hash; i.e. `#10` versus the correct `#page=10` format. Since this behaviour wasn't correct, PR 7757 fixed and deprecated the old format, which means that we no longer need to maintain the `nameddest` hack in multiple files.	8 years ago
Jonas Jenwald	972eca56a1	Refactor and ES6-ify `PDFLinkService.navigateTo` This patch replaces a `var self = this;` statement with arrow functions, and `var` with `let` in `PDFLinkService.navigateTo`. Furthermore, when I started looking at this method, it quickly became clear that its code is somewhat of a mess. Since I'm one of the persons that have touched this code over the years, I figured that it'd be a good idea to try and clean it up a bit.	8 years ago
Jonas Jenwald	a9e5bc91fb	Replace unnecessary `var self = this` statements with arrow functions in `web/pdf_page_view.js` and `web/pdf_thumbnail_view.js` Also replaces `var` with `let` in code that's touched in the patch. Please note that this should be completely safe, for two separate reasons, since trying to access let in a scope where it's not defined is first of all a runtime error and second of all an ESLint error (thanks to the `no-undef` rule).	8 years ago
Jonas Jenwald	9efd11c5c9	Replace unnecessary `var self = this` statements with arrow functions in `web/pdf_find_controller.js`	8 years ago
Jonas Jenwald	c750514903	Simplify `extractText` in `web/pdf_find_controller.js` Currently this method first uses a loop to build a temporary array to hold Promises, which are then resolved from a recursive helper function once the textContent is fetched for each page. To me, this is unncessarily complicated, since we can do everything within one loop by simply chaining the asynchronous calls to retrieve the textContent. (Note that this guarantees that the textContent of the pages is still fetched sequentially.)	8 years ago

1 2 3 4 5 ...

2047 Commits (0c95bc7d839f778528e4b5c9480ba1a642f74313)