pdfjs-dist

8740 Commits

1 Branch

1804 Tags

126 MiB

Tree: 1c253e6e1d

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	39cba5d25d	Remove `PDFThumbnailViewer_ensureThumbnailVisible` Functionality wise, `ensureThumbnailVisible` is essentially just a shorthand for `scrollThumbnailIntoView`. (And note that `PDFViewer` doesn't implement a `ensurePageVisible` method.) The only remaining usage of `PDFThumbnailViewer_ensureThumbnailVisible` is inside `PDFPresentationMode`, which introduces an otherwise unnecessary `PDFThumbnailViewer` dependency there. We're already relying on the `presentationmodechanged` event, in various files, to track the state of Presentation Mode. Thus we can simply listen for that event in `PDFSidebar` too, and update the thumbnails if necessary.	9 years ago
Jonas Jenwald	67a1dfcfb5	Move the sidebar related code from viewer.js into `PDFSidebar` The sidebar code has, except for minor fixes/additions (such as attachments), been largely untouch for years. To avoid having a bunch of sidebar code sprinkled throughout viewer.js, this patch moves the sidebar code into a separate file (pdf_sidebar.js), similar to how most other functionality has been moved in the last few years. Besides simply moving code around, this patch also has the added benefit that we now keep track of the sidebar state (not just opened/closed). This now makes it possible to handle both `Preferences` and `ViewHistory` settings for the sidebar state in a cleaner way, preventing strange and confusing interactions between the two.	9 years ago

Author

SHA1

Message

Date

Jonas Jenwald

39cba5d25d

Remove `PDFThumbnailViewer_ensureThumbnailVisible`

Functionality wise, `ensureThumbnailVisible` is essentially just a shorthand for `scrollThumbnailIntoView`. (And note that `PDFViewer` doesn't implement a `ensurePageVisible` method.)

The only remaining usage of `PDFThumbnailViewer_ensureThumbnailVisible` is inside `PDFPresentationMode`, which introduces an otherwise unnecessary `PDFThumbnailViewer` dependency there.

We're already relying on the `presentationmodechanged` event, in various files, to track the state of Presentation Mode. Thus we can simply listen for that event in `PDFSidebar` too, and update the thumbnails if necessary.

9 years ago

Jonas Jenwald

67a1dfcfb5

Move the sidebar related code from viewer.js into `PDFSidebar`

The sidebar code has, except for minor fixes/additions (such as attachments), been largely untouch for years.
To avoid having a bunch of sidebar code sprinkled throughout viewer.js, this patch moves the sidebar code into a separate file (pdf_sidebar.js), similar to how most other functionality has been moved in the last few years.

Besides simply moving code around, this patch also has the added benefit that we now keep track of the sidebar state (not just opened/closed).
This now makes it possible to handle both `Preferences` *and* `ViewHistory` settings for the sidebar state in a cleaner way, preventing strange and confusing interactions between the two.

9 years ago

2 Commits (1c253e6e1d44237e12ed165d03c50576f732dcf4)