pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Doug Thayer	0f9f0f8a9b	Cache PdfJs's enabled setting for delayed init See Bug 1389443 for more information. This allows us to register PdfJs without waiting for file IO in nsHandlerService to finish. Once that file IO is finished, we can set everything up properly and double-check the registration.	8 years ago
Brendan Dahl	5834ef6ff2	Bug 1353029 - Pass PdfJs.enabled into child on change.	8 years ago
Jonas Jenwald	4f48c8198c	Fix inconsistent spacing and trailing commas in objects in `extensions/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/extensions/firefox/content/PdfStreamConverter.jsm b/extensions/firefox/content/PdfStreamConverter.jsm index ea91a71a..0d59dad1 100644 --- a/extensions/firefox/content/PdfStreamConverter.jsm +++ b/extensions/firefox/content/PdfStreamConverter.jsm @@ -773,7 +773,8 @@ class RequestListener { response = function sendResponse(aResponse) { try { var listener = doc.createEvent("CustomEvent"); - let detail = Cu.cloneInto({ response: aResponse, }, doc.defaultView); + let detail = Cu.cloneInto({ response: aResponse, }, + doc.defaultView); listener.initCustomEvent("pdf.js.response", true, false, detail); return message.dispatchEvent(listener); } catch (e) { ```	8 years ago
Mark Banner	2e9ae50a3a	Use eslint-plugin-mozilla and the webextensions environment to avoid defining globals in each file.	8 years ago
Jonas Jenwald	cf87c9bba2	[Firefox addon] Upstream changes from: Bug 1356569 - Remove optional trailing parameters (issue 8310) In https://bugzilla.mozilla.org/show_bug.cgi?id=1355216, the third parameter of `Services.obs.addObserver` was made optional. However, omitting it in Firefox versions without that patch causes failures that completely prevents the addon from working (it won't even load). As far as I can tell, there isn't any way to detect ahead of time if the third parameter can be safely omitted, hence we're forced to fallback to manually checking the version number :-( Note: Since the `PdfJs.jsm` file is only used in the `MOZCENTRAL` build, we at least don't need to add any compatibility hacks there.	8 years ago
Andrew McCreight	740e1ab450	Skip PdfJs.enabled check in bootstrap-enabled. If we only invoke the bootstrap-enabled script when PdfJs.enabled is true, then we don't need to check it again in the script. This avoids a sync IPC call to the parent process. It also keeps PdfJs.jsm from importing PdfjsContentUtils.jsm in the child process until it is actually needed, which is one steps towards not loading it until it is really needed.	8 years ago
Jonas Jenwald	a5d5b970af	[Firefox addon] Enforce double quotes, using ESLint, to avoid linting errors in mozilla-central (issue 7957) Given that this patch causes a lot of churn in the addon code, I wouldn't really mind if we ultimately decide against doing this and just add a rule exception in mozilla-central instead.[1] --- [1] Note that I used the ESLint `--fix` option, hence writing this commit message actually took longer time than the creation of the patch :-)	8 years ago
Jonas Jenwald	54a64863e2	[Bug 1330147] removeObserver calls should not supply a third parameter This is yet another very recent change that we were not notified about. Upstream changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1330147, specifically https://hg.mozilla.org/mozilla-central/rev/8e0b7bc5fd71.	8 years ago
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
klemens	6f03f62327	trivial spelling fixes	9 years ago
Yury Delendik	df10513e10	Moves DEFAULT_PREFENCES into JSON format.	9 years ago
Manas	a2ba1b8189	Uses editorconfig to maintain consistent coding styles Removes the following as they unnecessary /* -- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -- / / vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */	10 years ago
Jonas Jenwald	26ec36ba4c	Upstream changes from Bug 1202902 - Give loader scripts and XUL frame scripts a lexical scope that doesn't break everything? One of the patches in https://bugzilla.mozilla.org/show_bug.cgi?id=1202902, specifically [`Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff)`](https://hg.mozilla.org/mozilla-central/rev/380817d573cd), touches PDF.js code. Unfortunately it was landed upstream without, as far as I can tell, notifying us about it. This patch uplifts the relevant changes to avoid future merge conflicts, and for consistency also tweaks `PdfJs-stub.jsm`.	10 years ago
Yury Delendik	4f3f983a21	Removes PdfRedirector.js and PlayPreview support.	10 years ago
Yury Delendik	0b5330781c	Bug 1179262 - Remove PlayPreview registration from PDF Viewer.	10 years ago
Collin Anderson	54e984c763	cleaned whitespace	10 years ago
Jonas Jenwald	9ed3e1e545	Fix code style in extensions/firefox/content/PdfJs.jsm	11 years ago
Jim Mathies	b399f19426	Bug 1064496 review changes	11 years ago
Jim Mathies	f2096fe23f	Firefox pdf viewer support for e10s (Bug 942707).	11 years ago
Yury Delendik	b39f0c311c	Refactors history and how the database is stored	11 years ago
Jonas Jenwald	3fee5345b9	[Firefox] Only load 'PdfStreamConverter' and 'PdfRedirector' when PDF.js is enabled	11 years ago
Jonas Jenwald	f6cfab0061	[Firefox] Stop importing default_preferences.js as a module and include it instead	11 years ago
Jonas Jenwald	c158894d94	Improve handling of preferences in Firefox	11 years ago
Brendan Dahl	b8f7bcaf02	Use only one resource url for moz central build.	11 years ago
jmozmoz	4cd33bf460	Really call unregister for _pdfRedirectorFactory (fixing issue #3598 )	12 years ago
Brendan Dahl	7eae88669a	Bug 879161 - Fix pdf.js mimetype check.	12 years ago
Vladan Djeric	0fae231526	Avoid triggering plugin list initialization on startup (Bugzilla 881575)	12 years ago
Yury Delendik	853e4625bf	Fixes pdf application switching in FF22/23 (redo)	12 years ago
Yury Delendik	6e975d431b	Fixes PDF application switch in Firefox.	12 years ago
Yury Delendik	dc12d33f4d	Adding PlayPreview API support to pdf.js/mozilla-central	12 years ago
Brendan Dahl	b42136f8f9	Fix migration for upgraded profiles.	13 years ago
Brendan Dahl	2a7312836c	Add comment for migration.	13 years ago
Brendan Dahl	eea7f90c7f	Fix the first run code and make it possible to run multiple times.	13 years ago
Brendan Dahl	332ae4ce41	Change to the Apache v2 license.	13 years ago
Brendan Dahl	da94701c7b	Addresses review feedback from mozilla central. See bugzilla bug 752676.	13 years ago
Brendan Dahl	121040a5dc	Make pdf.js the default pdf viewer for moz central. Update the tests to reflect this.	13 years ago
Brendan Dahl	3d7f01d9ca	Add global pref to enable/disable. Control pdf.js in application preferences. Add Artur's mochi tests.	13 years ago

37 Commits (47789b51c3b02b298f765e534b17e25ee786bd1f)