akira/pdfjs-dist - pdfjs-dist - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Jonas Jenwald	96fb0c0370	Call the `reset()` methods in the `PDFAttachmentViewer` and `PDFOutlineViewer` constructors Rather than duplicating initialization code, we can just call `this.reset()` instead (which is also similar to other existing code, e.g. `PDFViewer`). This will also help ensure that the DOM is completely reset, before any outline items or attachments are displayed.	8 years ago
Jonas Jenwald	614e8cf295	Change `var` to `let`, and use object destructuring, in a couple of previously class converted `web/*.js` files Note that these files were among the first to be converted to ES6 classes, so it probably makes sense to do another pass to bring them inline with the most recent ES6 conversions.	8 years ago
Jonas Jenwald	223c429357	Fix inconsistent spacing and trailing commas in objects in `web/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/web/pdf_thumbnail_view.js b/web/pdf_thumbnail_view.js index 002dbf29..1de4e530 100644 --- a/web/pdf_thumbnail_view.js +++ b/web/pdf_thumbnail_view.js @@ -420,8 +420,8 @@ var PDFThumbnailView = (function PDFThumbnailViewClosure() { setPageLabel: function PDFThumbnailView_setPageLabel(label) { this.pageLabel = (typeof label === 'string' ? label : null); - this.l10n.get('thumb_page_title', { page: this.pageId, }, 'Page {{page}}'). - then((msg) => { + this.l10n.get('thumb_page_title', { page: this.pageId, }, + 'Page {{page}}').then((msg) => { this.anchor.title = msg; }); diff --git a/web/secondary_toolbar.js b/web/secondary_toolbar.js index 160e0410..6495fc5e 100644 --- a/web/secondary_toolbar.js +++ b/web/secondary_toolbar.js @@ -65,7 +65,8 @@ class SecondaryToolbar { { element: options.printButton, eventName: 'print', close: true, }, { element: options.downloadButton, eventName: 'download', close: true, }, { element: options.viewBookmarkButton, eventName: null, close: true, }, - { element: options.firstPageButton, eventName: 'firstpage', close: true, }, + { element: options.firstPageButton, eventName: 'firstpage', + close: true, }, { element: options.lastPageButton, eventName: 'lastpage', close: true, }, { element: options.pageRotateCwButton, eventName: 'rotatecw', close: false, }, @@ -76,7 +77,7 @@ class SecondaryToolbar { { element: options.cursorHandToolButton, eventName: 'switchcursortool', eventDetails: { tool: CursorTool.HAND, }, close: true, }, { element: options.documentPropertiesButton, - eventName: 'documentproperties', close: true, } + eventName: 'documentproperties', close: true, }, ]; this.items = { firstPage: options.firstPageButton, ```	8 years ago
Yury Delendik	66c8893815	Removes last UMDs from the modules.	8 years ago
Tim van der Meij	93520172f6	Convert the attachments/outline view to ES6 syntax	8 years ago
Yury Delendik	8e681ce3e2	Change amd to cjs path in ES6 modules	8 years ago
Jonas Jenwald	b2c3f8f081	Convert a number of `import * as pdfjsLib from 'pdfjs-web/pdfjs';` cases to only specify the necessary imports Rather than always importing everything from the `web/pdfjs.js`, similar to all other imports we can just choose what we actually need.	8 years ago
Jonas Jenwald	3b35c15d42	Convert the files in the `/web` folder to ES6 modules Note that as discussed on IRC, this makes the viewer slightly slower to load only in `gulp server` mode, however the difference seem slight enough that I think it will be fine.	8 years ago
Jonas Jenwald	468ed1b9a1	Ensure that the `outlineWithDeepNesting` CSS class is removed when resetting `PDFOutlineViewer`, to prevent incorrect alignment if a new document is opened	8 years ago
Jonas Jenwald	e07cb8638e	Get rid of `element.removeChild(element.firstChild)` usage (bug 1345253) Instead of just upstreaming the changes from [bug 1345253](https://bugzilla.mozilla.org/show_bug.cgi?id=1345253) as-is, it seemed better to simply get rid of the loops altogether and use the same approach as in `PDFViewer`/`PDFThumbnailViewer`.	8 years ago
Jonas Jenwald	d5e3b2fbf0	Update `PDFOutlineViewer_bindLink` to look more like `LinkAnnotationElement_bindLink`	9 years ago
Jonas Jenwald	e64bc1fd13	Move parsing of destination dictionaries to a helper function This not only reduces code duplication, but it also allow us to easily support the same kind of URLs we currently do for Link annotations in the Outline as well.	9 years ago
Yury Delendik	32ce369d88	Fixes some static analysis warnings and recommendations * Useless conditional * Superfluous trailing arguments * Useless assignment to local variable * Misspelled identifier * JSDoc tag for non-existent parameter	9 years ago
Yury Delendik	7fd3db9977	Adds EventBus.	9 years ago
Yury Delendik	4165cedc9f	Replace pdfjsLib with module that represents pdf.js.	9 years ago
Yury Delendik	006e8fb59d	Introduces UMD headers to the web/ folder.	9 years ago
Yury Delendik	1e3e14e6b2	Exposes all functional members via lib exports and use them in viewer.	9 years ago
Tim van der Meij	f4bb23a66b	Correct a minor name issue in the outline viewer code	9 years ago
Jonas Jenwald	9b126711cd	Add support for bold/italic styled outline items in the viewer	9 years ago
Jonas Jenwald	21f048234d	Refactor how `PDFOutlineView`/`PDFAttachmentView` is initialized in viewer.js, rename the classes, and refactor their `render` methods Changes `PDFOutlineView`/`PDFAttachmentView` to be initialized once, since we're always creating them, and refactor their `render` methods to instead pass in the `outline`/`attachments`. For consistency with other "classes", the `PDFOutlineView`/`PDFAttachmentView` are renamed to `PDFOutlineViewer`/`PDFAttachmentViewer`. Also, make sure that the outline/attachments are reset when the document is closed. Currently we keep the old ones around until the `getOutline`/`getAttachments` API calls are resolved for a new document.	9 years ago
Jonas Jenwald	9bcbd4d872	Add a default title for outline items, to prevent display issues if the title is missing Open http://www.puolustusvoimat.fi/wcm/61ba4180411e702ea19ee9e364705c96/luonnonmuonaohjelmalumo1985.pdf?MOD=AJPERES#pagemode=bookmarks. Note how the outline looks entirely empty, but hovering over it you'll see that there are entries present. There's two separate issues here, first of all the fact that you cannot visually make out the outline items, and secondly that the lack of text means that the clickable area becomes too small. In Adobe Reader this issue is somewhat mitigated, since they use an icon for every item. For PDF.js, the easist way to address this seems to be making use of a default title. This issue should be very rare in practice, but given the simplicity of the solution I think that we should fix this.	9 years ago
Jonas Jenwald	0030a82dc3	[api-minor] Add support for URLs in the document outline Re: issue 5089. (Note that since there are other outline features that we currently don't support, e.g. bold/italic text and custom colours, I thus think we can keep the referenced issue open.)	9 years ago
Jonas Jenwald	97c10e9c08	Strip `null` (\x00) characters from the URLs in LinkAnnotations (issue 6832) Apparently some PDF files can have annotations with `URI` entries ending with `null` characters, thus breaking the links. To handle this edge-case of bad PDFs, this patch moves the already existing utility function from `ui_utils.js` into `util.js`, in order to fix those URLs. Fixes 6832.	9 years ago
Manas	a2ba1b8189	Uses editorconfig to maintain consistent coding styles Removes the following as they unnecessary /* -- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -- / / vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */	10 years ago
Jonas Jenwald	b7d1bed463	Add a utility function, for the viewer, that removes `null` (\x00) characters (issue 6416) Since some browsers render `null` characters, and others don't, this patch adds a way to remove them to prevent display issues in the viewer UI. Given that documents may contain very long outlines, I've added a utility function to avoid creating a lot of unnecessary `RegExp` objects. To avoid any future issues, this utility function is used for both the outline and the attachments. Fixes 6416.	10 years ago
Rob Wu	7c992243fd	Allow outline to be collapsed / shown via icon. - This commit adds a '>' before every outline item that has subitems. - Click on the '>' to collapse all subitems under that item (which turns the '>' in a 'v'). - Shift + click expands/collapses all descendant items under that tree. - Double-clicking on the "Show Document Outline" button in the toolbar expands/collapses all outline items.	10 years ago
Jonas Jenwald	94cc731616	Add custom \|outlineloaded\| and \|attachmentsloaded\| events to the viewer (bug 1112947)	10 years ago
Tim van der Meij	f4dbc99483	Add JSDoc comments to PDFOutlineView	10 years ago
Tim van der Meij	ea1d37eb0d	Refactor PDFAttachmentView to be more class-like and to separate functionality into methods	10 years ago
Tim van der Meij	b17da309ed	Rename DocumentOutlineView to PDFOutlineView	10 years ago
Tim van der Meij	3eeb571425	Rename document_outline_view.js to pdf_outline_view.js	10 years ago
Yury Delendik	44779f14b0	Renames and refactors PDFView to PDFViewerApplication.	11 years ago
Tim van der Meij	1e119e093b	Move DocumentOutlineView to its own file	11 years ago