pdfjs-dist

8933 Commits

1 Branch

1804 Tags

126 MiB

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	6260fc09a3	Attempt to recover valid `format 3` FDSelect data from broken CFF fonts (bug 1146106) According to the CFF specification, see http://partners.adobe.com/public/developer/en/font/5176.CFF.pdf#G3.46884, for `format 3` FDSelect data: "The first range must have a ‘first’ GID of 0". Since the PDF file (attached in the bug) violates that part of the specification, this patch tries to recover valid FDSelect data to prevent OTS from rejecting the font. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1146106.	9 years ago
Jonas Jenwald	c9b6de3b16	Prevent adding invalid values in `CFFDict_setByKey` (bug 1068432) In the font in question, there are a couple of `topDict` entries that have invalid values (`0xF 0xF`, i.e. just eof markers without any actual numbers). This causes the `parseFloatOperand` function, inside `CFFParser_parseDict`, to return `NaN`. Currently we pass this broken font onto the browser, which OTS unsurprisingly rejects. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1068432.	9 years ago
Jonas Jenwald	29c4a604af	Split the font_spec.js unit-tests into cff_parser_spec.js and type1_parser_spec.js Re: issue 7261. Given the we have `gulp fonttest`, which tests the `fonts.js` functionality at a higher level, and that we have a lot of font specific reference tests, I'm not convinced that we also need unit-tests for it.	9 years ago

Author

SHA1

Message

Date

Jonas Jenwald

6260fc09a3

Attempt to recover valid `format 3` FDSelect data from broken CFF fonts (bug 1146106)

According to the CFF specification, see http://partners.adobe.com/public/developer/en/font/5176.CFF.pdf#G3.46884, for `format 3` FDSelect data: "The first range must have a ‘first’ GID of 0".
Since the PDF file (attached in the bug) violates that part of the specification, this patch tries to recover valid FDSelect data to prevent OTS from rejecting the font.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1146106.

Jonas Jenwald

c9b6de3b16

Prevent adding invalid values in `CFFDict_setByKey` (bug 1068432)

In the font in question, there are a couple of `topDict` entries that have invalid values (`0xF 0xF`, i.e. just eof markers without any actual numbers).
This causes the `parseFloatOperand` function, inside `CFFParser_parseDict`, to return `NaN`. Currently we pass this broken font onto the browser, which OTS unsurprisingly rejects.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1068432.

Jonas Jenwald

29c4a604af

Split the font_spec.js unit-tests into cff_parser_spec.js and type1_parser_spec.js

Re: issue 7261.

Given the we have `gulp fonttest`, which tests the `fonts.js` functionality at a higher level, and that we have *a lot* of font specific reference tests, I'm not convinced that we *also* need unit-tests for it.

3 Commits (51e46fa1a79ce69bb48be5d8b047e7213e22482c)