pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	36c2791296	Unify handling of various cursor tools, e.g. the current Hand Tool and a possible future Zoom Tool, in a new `PDFCursorTools` module With the current way that the `HandTool` is implemented, if someone would try to also add a Zoom tool (as issue 1260 asks for) that probably wouldn't work very well given that you'd then have two cursor tools which may not play nice together. Hence this patch, which attempts to refactor things so that it should be simpler to add e.g. a Zoom tool as well (given that that issue is marked as "good-beginner-bug", and I'm not sure if that really applies considering the current state of the code). Note that I personally have no interest in implementing a Zoom tool (similar to Adobe Reader) since I wouldn't use it, but I figured that it can't hurt to make this code a bit more future proof.	8 years ago
Mark Banner	2e9ae50a3a	Use eslint-plugin-mozilla and the webextensions environment to avoid defining globals in each file.	8 years ago
Jonas Jenwald	7560f12a17	Enable the `object-shorthand` ESLint rule Please see http://eslint.org/docs/rules/object-shorthand. Unfortunately, based on commit `9276d1dcd9`, it seems that we still need to maintain compatibility with old Node.js versions, hence certain files/directories that are executed in Node.js are currently exempt from this rule. Furthermore, since the files specific to the Chromium extension are not run through Babel, the `/extensions/chromium/` directory is also exempt from this rule.	8 years ago
Yury Delendik	25873e92f0	Enable babel translation to enable ES module support.	8 years ago
Jonas Jenwald	a7c19d9cbb	Adjust the `yoda` ESLint rule to apply to inequalities as well I happened to notice that some inequalities had the wrong order, and was surprised since I thought that the `yoda` rule should have caught that. However, reading http://eslint.org/docs/rules/yoda#options a bit more closely than previously, it's quite obvious that the `onlyEquality` option does exactly what its name suggests. Hence I think that it makes sense to adjust the options such that only ranges are allowed instead.	8 years ago
Rob Wu	ece44d36e8	Allow automatic print rotation via enablePrintAutoRotate	8 years ago
Rob Wu	d9f90d595d	[CRX] Recognize blob and data-URLs in the router When a blob or data-URL is opened with the extension, viewer.html rewrites the URL. But when the viewer is refreshed (e.g. F5), Chrome would fail to display the viewer because the extension router was not set up to recognize such URLs. Now it is.	8 years ago
Jonas Jenwald	4046d67fde	Enable the `no-else-return` ESLint rule Using `else` after `return` is not necessary, and can often lead to unnecessarily cluttered code. By using the `no-else-return` rule in ESLint we can avoid this pattern, see http://eslint.org/docs/rules/no-else-return.	8 years ago
Jonas Jenwald	c850968fa7	Remove `globals` that are now unnecessary thanks to the use of various ESLint environments (e.g. Node, ShellJS, Jasmine)	8 years ago
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
Jonas Jenwald	28e50cfa21	Fix errors reported by the `space-infix-ops` ESLint rule http://eslint.org/docs/rules/space-infix-ops	8 years ago
Jonas Jenwald	ad915f8af1	Fix errors reported by the `comma-spacing` ESLint rule http://eslint.org/docs/rules/comma-spacing	8 years ago
Yury Delendik	f7d6f3a739	Adds SVG rendering capabilities to the PDFViewer.	9 years ago
Jonas Jenwald	f461fd64aa	Add support for PageLabels in the viewer This patch implements the page label functionality in a similar way as Adobe Reader. For documents with page labels, if a non-existent page label is entered we'll try to fallback to the page number instead. The patch also includes a preference (`disablePageLabels`), to make it easy to opt-out of using page labels if the user/implementor so wishes. The way that `get/set currentPageLabel` is implemented in `PDFViewer`, is as wrappers for the corresponding `get/set currentPageNumber` functions, since that seemed like the cleanest solution. The page labels are purposely only added to the page controls in the viewer UI, and not stored in e.g. the `ViewHistory`. Since doing so would mean adding unnecessary code complexity, without any real added value, and would also mean delaying the inital loading of PDF documents. Note that this patch will ignore page labels if they are identical to standard page numbering, since in this case displaying the page labels adds no value (but only UI noise). The reason for handling this case specially, is that in practice a surprising number of PDF files include "pointless" page labels.	9 years ago
Rob Wu	ae74e1bbd6	Deduct file type from content-disposition A user encountered a response that looks like: URL: some gibberish Headers: Content-Type: application/octet-stream Content-Disposition: attachment; filename="something.pdf" In the Chrome extension, the "attachment" content disposition is almost always ignored (i.e. the PDF Viewer will try to view it anyway). So we need to fall back to the Content-Disposition header if the URL check is inconclusive.	9 years ago
Jonas Jenwald	e12c48b73f	Add a `enhanceTextSelection` preference Please note that this is a hack, but I think that it should be OK for now to atleast get the preference landed. Refer to the code comment for further information. Re: issue 7584 and PR 7586.	9 years ago
Tim van der Meij	e686db250c	Render interactive form (AcroForm) text widget annotations This patch is the first step towards implementing support for interactive forms (AcroForms). It makes it possible to render text widget annotations exactly like Adobe Reader/Acrobat. Everything we implement for AcroForms is disabled by default using a preference, mainly because it is not ready to use yet, but has to implemented in many steps to avoid complexity. The preference allows us to work with the code while not exposing the behavior by default. Mainly storing entered values and printing them is still absent, which would be minimal requirements for enabling this by default.	9 years ago
Tim van der Meij	a2525a8ba3	Revert "Add a `enhanceTextSelection` preference to the viewer" This reverts commit `15e45d772f`.	9 years ago
Jonas Jenwald	15e45d772f	Add a `enhanceTextSelection` preference to the viewer	9 years ago
Peter Dave Hello	625d637297	optimize png images using zopflipng	9 years ago
Rob Wu	08ad551a01	Force inline block display style for <object>. Test: 1. Build the Chrome extension and load it. 2. Visit https://robwu.nl/pdfjs/object-embed.html 3. Verify that all displayed blocks have the same width and height as the reference ("Expected dimension").	9 years ago
Rob Wu	60438399e0	Fix typo in telemetry.js, follow-up to #7370	9 years ago
Rob Wu	724308c57a	Add opt-out telemetry to the Chrome extension Privacy policy: https://github.com/Rob--W/pdfjs-telemetry#privacy-policy Unit tests (offline): ``` node test/chromium/test-telemetry.js ``` Server tests (requires that Nginx is installed): ``` git clone https://github.com/Rob--W/pdfjs-telemetry.git cd pdfjs-telemetry/ python testserver.py TestHttp TestHttps ``` Integration test (extension + server): - Build the extension - Edit build/chromium/telemetry.js and remove the check for chrome.runtime.id. - Start Chrome (preferably a new profile): chromium --user-data-dir=/tmp/pdftest --no-first-run - Open chrome://net-internals#events - Visit chrome://extensions and enable Developer mode. - Load unpacked extension, select build/chromium. - Go to the chrome://net-internals tab and filter on pdfjs.robwu.nl. - Click on URL_REQUEST and verify that the server replied with 204. - Reload the extension. - Verify that chrome://net-internals did not contain a new log request.	9 years ago
Rob Wu	0be8e72d6f	Support syncing of settings in Chrome extension Use chrome.storage.sync to store preferences instead of chrome.storage.local, to allow settings to be synchronized if the user chooses to sign in in Chrome and enables synchronization of extension preferences.	9 years ago
Tim van der Meij	fdfaa43f5e	Resolve a regression in the Chromium extension's preferences handling Commit `df10513e10` unfortunately broke the options dialog of the Chromium extension because the logic required to work with the preference was not added. This patch adds the required logic to show the preference in the options dialog and to persist it to the preferences storage. Verified using Chromium 50 on Arch Linux.	9 years ago
Yury Delendik	df10513e10	Moves DEFAULT_PREFENCES into JSON format.	9 years ago
Rob Wu	9394fc133c	Remove support for frames in old Chromium versions Frames are only supported (via redirectUrl) in Chrome 35.0.1911.0+	9 years ago
Rob Wu	fc658a718c	Remove streamsPrivate usage This was only ever useful for the Opera extension because the API requires a whitelisted extension ID. Opera ditched PDF.js from their extension gallery, so we don't need to keep this in the tree.	9 years ago
Rob Wu	b45e6a7cc9	Don't use shadow DOM for rendering <object>/<embed> Multiple shadow roots are not supported any more in Chrome 51+ (https://crbug.com/603448#c6), so this patch changes the way that PDFs are rendered in `<embed>` / `<object>` tags. I used shadow roots because their content is not visible from the web page, so the odds of conflicts were minimal. Now I have to render the PDF frame directly in the page, which can be observed from the page (unfortunately). Now the following happens when an embedded PDF tag is detected: - `<embed>` tags: The type and src attributes are updated. - `<object>` tags: The type attribute is changed and the fallback content is set and displayed.	9 years ago
Rob Wu	0ec82d4a50	Allow local PDF files to be viewed in local frames The Chrome extension enforces that local files cannot be embedded in non-local web pages. The previous check was too strict (because the origin of a file:-URL is "null"), and prevented local PDF from being viewed in local files). This patch fixes that problem, by querying the actual tab URL via the background page. Steps to verify: 1. Create a HTML file: `<iframe src=test.pdf width=100% height=100%>` 2. Build and load the extension. 3. Allow file access to the extension at `chrome://extensions` 4. Open the HTML file from a file:// URL. 5. VERIFY: The extension should attempt to load the PDF file. 6. Now open the following (replace ID with the extension ID, which you can find at `chrome://extensions`): `data:text/html,<iframe src="chrome-extension://ID/file:///test.pdf">` 7. VERIFY: The next error should be displayed: "Refused to load a local file in a non-local page for security reasons."	9 years ago
Manas	a2ba1b8189	Uses editorconfig to maintain consistent coding styles Removes the following as they unnecessary /* -- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -- / / vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */	10 years ago
Rob Wu	32e7a8adba	Don't reload after updating if a tab is in use	10 years ago
Rob Wu	4ac8863e30	Restore extension tab after reload Work-around for https://crbug.com/511670	10 years ago
Rob Wu	775d4e69cf	Teach users how to enable access to local files.	10 years ago
Rob Wu	ffbe669730	[CRX] Respect download requests in main frame When the URL contains "=download", respect the Content-Disposition header in the Chrome extension.	10 years ago
Rob Wu	4367dd5130	[CRX] Ignore PDFs from responses to POST requests As explained in https://github.com/mozilla/pdf.js/issues/6174#issuecomment-118502802. To verify that this patch works: 1. Build the Chrome extension (node make chromium) 2. Load the Chrome extension (at chrome://extensions) 3. Visit https://robwu.nl/pdfjs/issue6174/. 4. Verify that PDF.js is not used to load the PDF. Either Chrome's default PDF Viewer is used, or the PDF is offered as a file download.	10 years ago
Rob Wu	adb2f8ae21	[CRX] Add Referer request header if needed This patch adds the Referer request header to PDF requests if the original PDF request included the Referer header.	10 years ago
Rob Wu	1b043bfd5a	Chrome extension: Add options page	10 years ago
Tim van der Meij	6f3ae49b8c	Adds pdfBugEnabled to the Chrome extension preferences	11 years ago
Yury Delendik	c3f191a27c	Implement streaming using moz-chunk-arraybuffer	11 years ago
Rob Wu	7938081e81	streamsPrivate API change. Since 25 February 2014 (crbug.com/345882)	11 years ago
Rob Wu	1055350425	Chrome extension: Isolate pageAction logic Remove pageAction logic from extension router, and put it in a separate file. The pageAction URL parsing logic has been simplified, and all pageAction-related files have been moved to a separate directory.	11 years ago
Rob Wu	4a399a0173	Disable spellcheck in Chromium's URL popup These red waves below a URL are quite useless and only distracting.	11 years ago
Rob Wu	a1671fa512	Preserve reference fragment in Chromium URL router Because removed reference fragments are no longer automatically copied thanks to https://code.google.com/p/chromium/issues/detail?id=354653	11 years ago
Tim van der Meij	c29faaa22d	Use strict equalities in make.js, external/* and extensions/*	11 years ago
Rob Wu	8bb96db3a0	Use CSS.supports instead of '..' in ....style document.documentElement.style is null in some XML documents. The previous snippet caused the following error: Uncaught TypeError: Cannot use 'in' operator to search for 'animation' in null To fix this bug, `'animation' in document.documentElement.style` has been replaced with `CSS.supports('animation', '9s')`. This method was introduced in Chromium 28, but it is not necessary to detect whether this method is supported because the required createShadowRoot method for embeds is not available in Chromium 32 and earlier.	11 years ago
Rob Wu	00746011a3	Managed preferences for Chrome administrators Implement support for managed preferences. This feature allows users (administrators) to easily change the default settings of the PDF Viewer for all Chrome or Chromium browsers within their organization. External resources for end users (administrators) - http://www.chromium.org/administrators/ - http://www.chromium.org/administrators/configuring-policy-for-extensions - http://www.chromium.org/administrators/windows-quick-start - http://www.chromium.org/administrators/mac-quick-start - http://www.chromium.org/administrators/linux-quick-start - http://www.chromium.org/administrators/policy-templates Administrators can read one of the previous links to learn more about creating policies. We want to auto-generate these templates, but there are no public tools for doing that. It will be added in the future, see: https://code.google.com/p/chromium/issues/detail?id=389061 Resources for PDF.js/extension developers - http://cs.chromium.org/file:policy_templates.json - https://developer.chrome.com/extensions/manifest/storage	11 years ago
Rob Wu	87dacba9a6	Feature detection after downgrading the browser. If a user downgrades from Chromium 35+ to 34, then the PDF Viewer extension will not work any more because the extension assumes that certain features were available based on the cached feature detection results. To resolve this problem, all feature detection scripts run again if the browser was downgraded.	11 years ago
Rob Wu	3fdd334a73	<object> / <embed> support in Chromium extension	11 years ago
Rob Wu	d126be9a61	Allow unsafe-eval to fix font renderer in crx Fixes #4660	11 years ago

1 2

93 Commits (5438ce9b9826fabcdc1638223869dfb17925bd0c)