akira/pdfjs-dist - pdfjs-dist - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Jonas Jenwald	5fa9cca8dd	Refactor `PDFViewer` to extend an abstract `BaseViewer` class This patch introduces an abstract `BaseViewer` class, that the existing `PDFViewer` then extends. Please note: This lays the necessary foundation for the next patch.	8 years ago
Jonas Jenwald	d7198d3e17	Rename `web/pdf_viewer.js` to `web/base_viewer.js` Please note that the only reason for this change is to try and improve reviewability of later patches, by keeping the diffs more manageable.	8 years ago
Jonas Jenwald	6c3856c841	Ignore 'change' events that didn't originate in the viewer (issue 8915) Rather that registering a 'change' event listener on the `window`, which will thus (unnecessarily) fire in a number of other situations such as e.g. when the user changes the pageNumber or the current search term, we could/should just register it directly on the dynamically created `fileInput` DOM element instead. I can see no really compelling reason why we actually need to listen for `file` changes on the `window` itself, and this way we're also able to keep the `fileInput` related code confined to one part of the code which should aid readability. Furthermore, in custom deployments, there's less risk that we're going to interfere with "outside" code this way. Finally, preprocessor guards were added to the `webViewerOpenFile` function, since that code doesn't make sense in e.g. the extension builds.	8 years ago
Jonas Jenwald	e135c03123	Store the rotation in the `PDFHistory`	8 years ago
Jonas Jenwald	44d5138d0f	Store the rotation in the `ViewHistory` (issue 5927)	8 years ago
Jonas Jenwald	5565a6f8bf	Slightly refactor the pages rotation handling code in the viewer This changes both `PDFViewer` and `PDFThumbnailViewer` to return early in the `pagesRotation` setters if the rotation doesn't change. It also fixes an existing issue, in `PDFViewer`, that would cause errors if the rotation changes before the scale has been set to a non-default value. Finally, in preparation for subsequent patches, it also refactors the rotation code in `web/app.js` to update the thumbnails and trigger rendering with the new `rotationchanging` event.	8 years ago
Jonas Jenwald	39a77c76ad	Assign a dummy value to the `docBaseUrl` API parameter in non-`PRODUCTION` mode This ensures that relative links are displayed when using the viewer in `gulp server` mode, in an effort to aid development/debugging.	8 years ago
Jonas Jenwald	133d06e9a4	Re-write `PDFHistory` from scratch This patch completely re-implements `PDFHistory` to get rid of various bugs currently present, and to hopefully make maintenance slightly easier. Most of the interface is similar to the existing one, but it should be somewhat simplified. The new implementation should be more robust against failure, compared to the old one. Previously, it was too easy to end up in a state which basically caused the browser history to lock-up, preventing the user from navigating back/forward. (In the new implementation, the browser history should not be updated rather than breaking if things go wrong.) Given that the code has to deal with various edge-cases, it's still not as simple as I would have liked, but it should now be somewhat easier to deal with. The main source of complication in the code is actually that we allow the user to change the hash of a already loaded document (we'll no longer try to navigate back-and-forth in this case, since the next commit contains a workaround). In the new code, there's also a lot more comments (perhaps too many?) to attempt to explain the logic. This is something that the old implementation was serverly lacking, which is a one of the reasons why it was so difficult to maintain. One particular thing to note is that the new code uses the `pagehide` event rather than `beforeunload`, since the latter seems to be a bad idea based on https://bugzilla.mozilla.org/show_bug.cgi?id=1336763.	8 years ago
Jonas Jenwald	28ce3b6185	Rip out the current implementation of `PDFHistory` The current implementation of `PDFHistory` contains a number of smaller bugs, which are very difficult to address without breaking other parts of its code. Possibly the main issue with the current implementation, is that I wrote it quite some time ago, and at the time my understanding of the various edge-cases the code has to deal with was quite limited. Currently `PDFHistory` may, despite most of those cases being fixed, in certain edge-cases lock-up the browser history, essentially preventing the user from navigating back/forward. Hence rather than trying to iterate on `PDFHistory` to make it better, the only viable approach is unfortunately rip it out in its entirety and re-write it from scratch.	8 years ago
Jonas Jenwald	028d7c0950	Ensure that `PDFViewerApplication.error` outputs proper messages in FIREFOX/MOZCENTRAL builds It appears that this accidentally broke with PR 8394. Currently, the following will be printed in the console: ``` An error occurred while loading the PDF. [object Promise],[object Promise] ``` With this patch we'll again get proper output, e.g. something with this format: ``` An error occurred while loading the PDF. PDF.js v? (build: ?) Message: unknown encryption method ```	8 years ago
Jonas Jenwald	870a8f6c35	Remove the ability to pass a `scale` parameter in the (optional) `args` object parameter of `PDFViewerApplication.open(file, args)` Since the very early days of the viewer, it's been possible to pass in a `scale` when opening a PDF file. However, most of the time it was/is actually being ignored, which limits its usefulness considerably. In older versions of the viewer, if a document hash was present (i.e. `PDFViewerApplication.initialBookmark` being set) or if the document existed in the `ViewHistory`, the `scale` passed to `PDFViewerApplication.open` would thus always be ignored. In addition to the above, in the current viewer there's even more cases where the `scale` parameter will be ignored: if a (valid) browser history entry exists on document load, or if the `defaultZoomValue` preference is set to a non-default value. Hence the result is that in most situation, a `scale` passed to `PDFViewerApplication.open` will be completely ignored. A much better, not to mention supported, way of setting the initial scale is by using the `defaultZoomLevel` preference. In comparision, this also has the advantage of being used in situations where the `scale` would be ignored. All in all this leads to the current situation where we have code which is essentially dead, since no part of the viewer (by default) relies on it. To clean up this code, and to avoid having to pass (basically) unused parameters around, I'd thus like to remove the ability to pass a `scale` to `PDFViewerApplication.open`.	8 years ago
Jonas Jenwald	fce31c3f83	Ensure that the loadingBar isn't displayed again when the entire file has already been fetched This could only (potentially) happen when `disableAutoFetch` is used.	8 years ago
Jonas Jenwald	20d6286cce	Add support for, the API property, PageMode in the viewer (issue 8657) Note that the PageMode, as specified in the API, will only be honoured when either: the user hasn't set the `sidebarViewOnLoad` preference to a non-default value, or a non-default `sidebarView` entry doesn't exist in the view history, or the "pagemode" hash parameter is included in the URL. Since this is new functionality, the patch also includes a preference (`disablePageMode`), to make it easy to opt-out of this functionality if the user/implementor so wishes.	8 years ago
Jonas Jenwald	f7c4ed4bc3	Refactor reading from the `ViewHistory` in `PDFViewerApplication.load`	8 years ago
Jonas Jenwald	49333ddd44	Move the `hasEqualPageSizes` getter from `PDFViewerApplication` and into `PDFViewer` instead Since the method needs to access properties that are directly available inside of `PDFViewer`, it seems simpler to just have it live there.	8 years ago
Christian Myksvoll	95093a5276	Check for undefined url (#8640 ) * Check for undefined new URL(file, window.location.href) throws the following error in IE11 + iPad Safari: Unable to get property 'replace' of undefined or null reference * Adapting previous change to pdf.js code standards Added curly braces * Moved check for undefined above try/catch	8 years ago
Jonas Jenwald	c253ee9ab8	Ensure that the document is rendered on load, no matter what happens, by always calling `PDFViewer.update` after the initial position has been set	8 years ago
Jonas Jenwald	8391aacb89	Remove the scale-not-initialized hack from `webViewerResize` (in app.js) Since we no longer, after PR 8555, allow changing the scale until the document is loaded, that hack is no longer necessary. Furthermore, no part of that event handling function needs to run unless a document is loaded. The reason that this hack was initially added, is that previously the `ViewHistory` might be updated before `PDFViewerApplication.setInitialView` had run (in some cases leading to incorrect inital document scale). Since that is no longer possible, this is now dead code.	8 years ago
Jonas Jenwald	d64ac95a91	ES6-ify the code in `web/app.js` and `web/viewer.js` The changes consist mostly of changing `var` to `let`/`const`, and using shorthand method signatures.	8 years ago
Jonas Jenwald	f6369fc87c	ES6-ify the code in `web/ui_utils.js` These changes consists mainly of replacing `var` with `let`/`const`, adding a couple of default parameters to function signatures, and finally converting `EventBus`/`ProgressBar` to proper classes.	8 years ago
Jonas Jenwald	83673a12d7	Stop tracking the rotation in `PDFViewerApplication` and directly use `PDFViewer.pagesRotation` instead Part of the rotation handling code, in what's now `web/app.js`, hasn't really changed since before the viewer was split into multiple files/components. Similar to other properties, such as current page/scale, we should probably avoid tracking state in multiple places. Hence I'm suggesting that we don't store the rotation in `PDFViewerApplication`, and access the value in `PDFViewer` instead. Since `PDFViewerApplication.pageRotation` has existed for a very long time, a getter was added to avoid outright breaking third-party code that may depend on it.	8 years ago
Jonas Jenwald	4aab3cef4a	Remove a redundant `PDFViewer.currentScale` call from `PDFViewerApplication.load` Since this call occurs before the `PDFViewer.setDocument` call, it won't actually cause any scale change. Furthermore, moving it should not be necessary, since the `scale` is already used as the fallback case in `PDFViewerApplication.setInitialView` (provided it's non-zero, which isn't even the case in the default viewer). Hence this patch should cause no functional changes at all, since it simply removes a piece of unnecessary code.	8 years ago
Jonas Jenwald	e4d032c5c7	Reset `pageRotation` and `downloadComplete` in `PDFViewerApplication.close` Currently, these properties are reset in what appears to be somewhat arbitrary locations (within the `load` and `open` methods respectively). The explanation is probably that both of these properties predates the existence of any centralized clean-up code in the viewer. Hence I think that it makes sense to move the resetting of these properties to the `close` method, since that improves the overview of what's actually cleaned-up/reset when changing documents in the viewer.	8 years ago
curiosity26	8326304271	Allow for unbinding of events in web application Hold bound event listeners for later unbinding ES6 styling More ES6 styling and code cleanup Remove 4 space indents and remove delete statements.	8 years ago
Jonas Jenwald	223c429357	Fix inconsistent spacing and trailing commas in objects in `web/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/web/pdf_thumbnail_view.js b/web/pdf_thumbnail_view.js index 002dbf29..1de4e530 100644 --- a/web/pdf_thumbnail_view.js +++ b/web/pdf_thumbnail_view.js @@ -420,8 +420,8 @@ var PDFThumbnailView = (function PDFThumbnailViewClosure() { setPageLabel: function PDFThumbnailView_setPageLabel(label) { this.pageLabel = (typeof label === 'string' ? label : null); - this.l10n.get('thumb_page_title', { page: this.pageId, }, 'Page {{page}}'). - then((msg) => { + this.l10n.get('thumb_page_title', { page: this.pageId, }, + 'Page {{page}}').then((msg) => { this.anchor.title = msg; }); diff --git a/web/secondary_toolbar.js b/web/secondary_toolbar.js index 160e0410..6495fc5e 100644 --- a/web/secondary_toolbar.js +++ b/web/secondary_toolbar.js @@ -65,7 +65,8 @@ class SecondaryToolbar { { element: options.printButton, eventName: 'print', close: true, }, { element: options.downloadButton, eventName: 'download', close: true, }, { element: options.viewBookmarkButton, eventName: null, close: true, }, - { element: options.firstPageButton, eventName: 'firstpage', close: true, }, + { element: options.firstPageButton, eventName: 'firstpage', + close: true, }, { element: options.lastPageButton, eventName: 'lastpage', close: true, }, { element: options.pageRotateCwButton, eventName: 'rotatecw', close: false, }, @@ -76,7 +77,7 @@ class SecondaryToolbar { { element: options.cursorHandToolButton, eventName: 'switchcursortool', eventDetails: { tool: CursorTool.HAND, }, close: true, }, { element: options.documentPropertiesButton, - eventName: 'documentproperties', close: true, } + eventName: 'documentproperties', close: true, }, ]; this.items = { firstPage: options.firstPageButton, ```	8 years ago
Jonas Jenwald	1d4e96b0b5	Add a stub `createL10n` to `DefaultExternalServices` in app.js It appears that this was simply forgotten in PR 8394.	8 years ago
Yury Delendik	5438ce9b98	Wraps mozL10n to async calls; splits firefox and generic l10n libs.	8 years ago
Yury Delendik	66c8893815	Removes last UMDs from the modules.	8 years ago
Tim van der Meij	e7a04fc82d	Convert the overlay manager to ES6 syntax	8 years ago
Jonas Jenwald	36c2791296	Unify handling of various cursor tools, e.g. the current Hand Tool and a possible future Zoom Tool, in a new `PDFCursorTools` module With the current way that the `HandTool` is implemented, if someone would try to also add a Zoom tool (as issue 1260 asks for) that probably wouldn't work very well given that you'd then have two cursor tools which may not play nice together. Hence this patch, which attempts to refactor things so that it should be simpler to add e.g. a Zoom tool as well (given that that issue is marked as "good-beginner-bug", and I'm not sure if that really applies considering the current state of the code). Note that I personally have no interest in implementing a Zoom tool (similar to Adobe Reader) since I wouldn't use it, but I figured that it can't hurt to make this code a bit more future proof.	8 years ago
Jonas Jenwald	240a3926f4	Replace unnecessary `var self = this` statements with arrow functions in `web/app.js` Also replaces `var` with `let` in the functions/methods that are touched in the patch. Please note that this should be completely safe, for two separate reasons, since trying to access `let` in a scope where it's not defined is first of all a runtime error and second of all an ESLint error (thanks to the `no-undef` rule).	8 years ago
Jonas Jenwald	7780fd5b98	Re-factor `PDFDocumentProperties` such that it's properly reset when a new PDF file is opened (issue 8371) This patch contains the following improvements: - Only fetch the various document properties once per PDF file opened, and cache the result (in a frozen object). - Always update the entire dialog at once, to prevent inconsistent UI state (issue 8371). - Ensure that the dialog, and all its internal properties, are reset when `PDFViewerApplication.close` is called. - Inline, and re-factor, the `getProperties` method in `open`, since that's the only call-site. - Always overwrite the fileSize with the value obtained from `pdfDocument.getDownloadInfo`, to ensure that it's correct. - ES6-ify the code that's touched in this patch. Fixes 8371.	8 years ago
Jonas Jenwald	f27b5013e2	Replace unnecessary `bind(this)` statements with arrow functions in `web/` files By using `let`, which is block-scoped, instead of `var` in a couple of places we're able to get rid of additional `bind` calls.	8 years ago
Jonas Jenwald	2a0207ccaf	Enable the `object-shorthand` ESLint rule in `web` Please see http://eslint.org/docs/rules/object-shorthand. For the most part, these changes are of the search-and-replace kind, and the previously enabled `no-undef` rule should complement the tests in helping ensure that no stupid errors crept into to the patch.	8 years ago
Jonas Jenwald	09edfb3dc0	Re-factor `ViewHistory` to make it properly asynchronous Rather than having to manually use `initializedPromise`, which really ought to be a private property, to ensure that setting/getting values in the `ViewHistory` works as intended, this re-factoring simply changes all of its methods to be asynchronous. Furthermore, a `getMultiple` method (mirroring the existing `setMultiple` one) is also added to `ViewHistory`. Finally, this patch also addresses an existing issue, where certain preferences (e.g. the default zoom level) would be ignored when calling `setInitialView` if reading from the `ViewHistory` fails for some reason.	8 years ago
Jonas Jenwald	c5f9193777	Convert the `Preferences` to an ES6 class	8 years ago
Yury Delendik	8e681ce3e2	Change amd to cjs path in ES6 modules	8 years ago
Jonas Jenwald	b2c3f8f081	Convert a number of `import * as pdfjsLib from 'pdfjs-web/pdfjs';` cases to only specify the necessary imports Rather than always importing everything from the `web/pdfjs.js`, similar to all other imports we can just choose what we actually need.	8 years ago
Jonas Jenwald	3b35c15d42	Convert the files in the `/web` folder to ES6 modules Note that as discussed on IRC, this makes the viewer slightly slower to load only in `gulp server` mode, however the difference seem slight enough that I think it will be fine.	8 years ago
Jonas Jenwald	313060aff5	Refactor the `DownloadManager` initialization in `GENERIC`/`CHROME` builds, to avoid issues when converting the code to ES6 modules	8 years ago
Jonas Jenwald	6d672c4ba6	[api-minor] Add a `pdfjsNext` parameter, and `PDFJS_NEXT` build flag, to allow backwards incompatible API changes	8 years ago
Yury Delendik	eb4c88cd44	Replacing custom bundling with webpack2.	8 years ago
Rob Wu	ece44d36e8	Allow automatic print rotation via enablePrintAutoRotate	8 years ago
Rob Wu	c67edabcb3	Set title using logic similar as download name The download method (and the PDF document properties) detect the file name using `getPDFFileNameFromURL`. The title ought to also display the PDF filename if available.	8 years ago
Rob Wu	228d253f30	Detect download filename based on full URL	8 years ago
Jonas Jenwald	a96b0f80dd	Convert the only remaining consumer (in `hand_tool.js`) of the 'localized' event to use the `localized` Promise instead, and only re-dispatch the 'localized' event on the `eventBus` for `GENERIC` builds Ideally we'd remove the 'localized' event from the `eventBus`, but for backwards compatibility we keep it in `GENERIC` builds. Note that while we want to ensure that the direction attribute of the HTML is updated as soon as the `localized` Promise is resolved, we purposely wait until the viewer has been initialized to ensure that the 'localized' event will always be dispatched.	8 years ago
Jonas Jenwald	648024f5d0	Don't call `bindEvents()` until `PDFViewerApplication` has been initialized, and move binding of `window` event listeners to a helper method, to prevent errors if an event manages to arrive too soon With `bindEvents()` now being called after the viewer has been initialized, we no longer need to have `PDFViewerApplication.initialized` checks in the event handler functions. Furthermore by moving the `window.addEventListener`s to a helper method, `PDFViewerApplication.initialized` checks are no longer necessary in the event handlers, hence we thus address part of issue 7797 here as well.	8 years ago
Jonas Jenwald	849f5dde9d	Move the `Preferences` initialization/fetching code to the top of `PDFViewerApplication.initialize`, to enable using them when initializing e.g. the viewer components Note that in quick testing using `console.time/timeEnd`, both locally and with the Firefox addon, the total run time of the entire `PDFViewerApplication.initialize` function does not seem to change with this patch.	8 years ago
Jonas Jenwald	2c1436f6cb	Refactor `PDFViewerApplication.initialize` into two methods, one that reads the Preferences and one that initializes the various viewer components	8 years ago
Jonas Jenwald	48696a8d06	Make the keyboard shortcuts `Ctrl + Up/Down` behave as `Home/End` (issue 7852) It seems that for normal web pages, at least in Firefox, the keyboard shortcuts <kbd>Ctrl</kbd> + <kbd>Up</kbd>/<kbd>Down</kbd> are functionally equivalent to <kbd>Home</kbd>/<kbd>End</kbd>. This is obviously an edge-case, but can be easily implemented by using the same logic as we do for <kbd>Home</kbd>/<kbd>End</kbd>. Fixes 7852. Please note: I'm finding it slightly difficult to interpret issue 7852, and bug 1285719, since among other things: the title includes the word "reverse" with no other mention of it, and the STR makes reference to print preview which doesn't seem applicable to the PDF viewer. However, compared to regular web pages in Firefox, I think the behavior of this patch makes sense here.	9 years ago

1 2 3