pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	52e0f51917	Enable the `no-unused-vars` ESLint rule Please see http://eslint.org/docs/rules/no-unused-vars; note that this patch purposely uses the same rule options as in `mozilla-central`, such that it fixes part of issue 7957. It wasn't, in my opinion, entirely straightforward to enable this rule compared to the already existing rules. In many cases a `var descriptiveName = ...` format was used (more or less) to document the code, and I choose to place the old variable name in a trailing comment to not lose that information. I welcome feedback on these changes, since it wasn't always entirely easy to know what changes made the most sense in every situation.	8 years ago
Jonas Jenwald	c850968fa7	Remove `globals` that are now unnecessary thanks to the use of various ESLint environments (e.g. Node, ShellJS, Jasmine)	8 years ago
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
Yury Delendik	0a700fa29d	Updates Jasmine version.	9 years ago
Manas	f6d28ca323	Refactors CMapFactory.create to make it async	9 years ago
Yury Delendik	85e95d34ed	Use RequireJS in the viewer, examples and tests.	9 years ago
Yury Delendik	6b60c8f4db	Adds UMD headers to core, display and shared files.	9 years ago
Tim van der Meij	91274d6d2d	Rename annotation_helper.js to annotation_layer.js	10 years ago
Yury Delendik	56ccaea99b	Move text layer building logic into src/display/text_layer.js	10 years ago
Manas	a2ba1b8189	Uses editorconfig to maintain consistent coding styles Removes the following as they unnecessary /* -- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -- / / vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */	10 years ago
Collin Anderson	54e984c763	cleaned whitespace	10 years ago
Jonas Jenwald	b201cc4940	Remove the remaining references to cidmaps.js from the test suite	11 years ago
Yury Delendik	bdeca30fbf	Splits shared/annotation.js into core/ and display/	11 years ago
Yury Delendik	fcc4dfd9b5	Moves shared/function.js to core/	11 years ago
Yury Delendik	7a19085159	Moves shared/colorspace.js into core/	11 years ago
Michał Gołębiowski	e625af3fef	Remove type="text/javascript" from script tags. "text/javascript" is not a correct MIME type (the correct one is "application/javascript") but it's not even needed; all browsers default to the correct type and treat it as executable JS when type is ommited. Since not all browsers recognize the "application/javascript" MIME type the only way to both stay compliant and to support all popular browsers is to omit the type. It's also shorter this way.	11 years ago
Thorben Bochenek	e8f0700bfa	Move the colour conversion to jpg.js Benchmarking shows that this improves performance for the invitation document from https://github.com/mozilla/pdf.js/issues/3809 by 35%	11 years ago
Yury Delendik	f57c6935d7	Implements WebGL support	11 years ago
Yury Delendik	63f438006b	Fixes lint for windows; adds test/font/fontutils.js	11 years ago
Yury Delendik	c2376e5cea	Migrating test.py to test.js	11 years ago
Brendan Dahl	b5b94a4af3	Use built in CMaps and unify the glyph mapping.	11 years ago
Brendan Dahl	fc0106822c	Change test font to one that works with ttx v2.4.	11 years ago
Yury Delendik	e9327050c3	Basic function.js split	11 years ago
Yury Delendik	bf432a37bb	Refactors shared/pattern.js into core/ and display/	11 years ago
Brendan Dahl	5ecce4996b	Split files into worker and main thread pieces.	12 years ago
Mack Duan	f8f4b3f45d	Refactor code for annotations	12 years ago
Mack Duan	ef423ef30c	Implement progressive loading of PDFs	12 years ago
mduan	5bffd2e7d8	Implement 9.6.6.4 of pdf spec for truetype fonts	12 years ago
Yury Delendik	0646d397eb	Rejects post table if maxp numGlyph does not match	13 years ago
Yury Delendik	05148e8e7d	Removes vtmx and vhea tables; sanitizes fpgm and prep	13 years ago
Yury Delendik	4da7be8d28	Verifies some of the OS2 font table fields	13 years ago
Yury Delendik	fbe3d71663	Re-creates invalid post table	13 years ago
Yury Delendik	5afec33956	Adds ttx test harness	13 years ago

33 Commits (6f0cf8c4cb15debe3616de6ddb9e642ff424ff23)