akira/pdfjs-dist - pdfjs-dist - Gitea: Git with a cup of tea

Tree: 77b7b84d1e

Author	SHA1	Message	Date
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
Yury Delendik	185a1f45e7	Fixes AMD name in the web/pdf_viewer.js.	9 years ago
Yury Delendik	7fd3db9977	Adds EventBus.	9 years ago
Yury Delendik	81fc46e666	Refactors FindController dependencies.	9 years ago
Yury Delendik	4165cedc9f	Replace pdfjsLib with module that represents pdf.js.	9 years ago
Yury Delendik	006e8fb59d	Introduces UMD headers to the web/ folder.	9 years ago
Yury Delendik	1e3e14e6b2	Exposes all functional members via lib exports and use them in viewer.	9 years ago
Tim van der Meij	0351c7eff4	Move the `getFileName` helper function to the core This is required to be able to use it in the annotation display code, where we now apply it to sanitize the filename of the FileAttachment annotation. The PDF file from https://bugzilla.mozilla.org/show_bug.cgi?id=1230933 has shown that some PDF generators include the path of the file rather than the filename, which causes filenames with weird initial characters. PDF viewers handle this differently (for example Foxit Reader just replaces forward slashes with spaces), but we think it's better to only show the filename as intended. Additionally we add unit tests for the `getFilenameFromUrl` helper function.	9 years ago
Tim van der Meij	6a33dfd13a	Implement support for FileAttachment annotations	9 years ago
Jonas Jenwald	3079dd937f	Remove a superfluous "s" in `AnnotationsLayerBuilder` from files in web/ This patch makes the naming consistent with the `TextLayerBuilder`, and also the new `AnnotationLayer`, and should thus help reduce possible confusion when working with the code. Please note that the files were renamed using `git mv`, in order to preserve blame.	9 years ago
Manas	a2ba1b8189	Uses editorconfig to maintain consistent coding styles Removes the following as they unnecessary /* -- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -- / / vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */	10 years ago
Yury Delendik	1b847df2f3	Using pdfjs-dist as a library for b2g viewer.	10 years ago
Yury Delendik	5cff06e52a	Refactors PDFHistory. # Conflicts: # extensions/b2g/viewer.js # web/pdf_history.js # web/pdf_viewer.component.js # web/viewer.js	10 years ago
Yury Delendik	0ef6212b64	Refactors PDFLinkService. # Conflicts: # web/viewer.js	10 years ago
Yury Delendik	513a3d8c91	Replaces text selection example	10 years ago
Yury Delendik	b16a406f3a	Packages PDFViewer as a UI component.	11 years ago
Yury Delendik	812c5accb2	Making sure we are not importing CRs and BOMs	11 years ago
Jonas Jenwald	c53bcb2992	Add a preference to set the sidebarView on load	11 years ago
Yury Delendik	30ab878835	Add enableWebGL to the preferences	11 years ago
Jonas Jenwald	42f9541081	Add preference to automatically enable the Hand Tool when the viewer loads	11 years ago
Jonas Jenwald	f6cfab0061	[Firefox] Stop importing default_preferences.js as a module and include it instead	11 years ago
Jonas Jenwald	60610cd625	Implement default preferences	12 years ago
Brendan Dahl	332ae4ce41	Change to the Apache v2 license.	13 years ago
Yury Delendik	1bb7a7ed1c	Adds stub PdfJs.jsm for FF15	13 years ago