pdfjs-dist

9287 Commits

1 Branch

1804 Tags

126 MiB

Tree: 86ba634c97

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	ae2cc9119b	Add a couple more, mostly `text`, reference tests for non-embedded symbolic fonts without included encoding information I've started to look into how we can fix issue 7580, but quickly became worried that fixing it could easily mean that we'd trade one fixed PDF file for a multitude of broken ones. Hence I started going through the history of the code that choose the fallback encoding, and noticed that it has been changed a number of times over the years to deal with various cases of weirdness/errors in non-embedded fonts. To my relief it turned out that almost all the PRs, please see a possibly incomplete [list here], that changed this code actually included `eq` test-cases. However, in one case it appears that a PR missed to add a test-case. Furthermore since the fallback encoding may also be the only source for creating a `toUnicode` map, changing the encoding could possibly regress only the text-selection despite a PDF file still rendering correctly. Therefore, this PR adds one new `eq` test, and also a number of additional `text` tests for PDF files already present in the test-suite. Note that it's obviously possible that there's a certain overlap between the added tests, but I'd be a whole lot more concerned with causing regressions.	9 years ago

Author

SHA1

Message

Date

Jonas Jenwald

ae2cc9119b

Add a couple more, mostly `text`, reference tests for non-embedded symbolic fonts without included encoding information

I've started to look into how we can fix issue 7580, but quickly became worried that fixing it could easily mean that we'd trade one fixed PDF file for a multitude of broken ones.

Hence I started going through the history of the code that choose the fallback encoding, and noticed that it has been changed a number of times over the years to deal with various cases of weirdness/errors in non-embedded fonts.
To my relief it turned out that almost all the PRs, please see a possibly incomplete [list here], that changed this code actually included `eq` test-cases.

However, in one case it appears that a PR missed to add a test-case. Furthermore since the fallback encoding may also be the only source for creating a `toUnicode` map, changing the encoding could possibly regress only the text-selection despite a PDF file still rendering correctly.
Therefore, this PR adds one new `eq` test, and also a number of additional `text` tests for PDF files already present in the test-suite.

Note that it's obviously possible that there's a certain overlap between the added tests, but I'd be *a whole lot* more concerned with causing regressions.

9 years ago

1 Commits (86ba634c97e60dee87fc1d5bd17867d062e40db4)