akira/pdfjs-dist - pdfjs-dist - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Jonas Jenwald	7780fd5b98	Re-factor `PDFDocumentProperties` such that it's properly reset when a new PDF file is opened (issue 8371) This patch contains the following improvements: - Only fetch the various document properties once per PDF file opened, and cache the result (in a frozen object). - Always update the entire dialog at once, to prevent inconsistent UI state (issue 8371). - Ensure that the dialog, and all its internal properties, are reset when `PDFViewerApplication.close` is called. - Inline, and re-factor, the `getProperties` method in `open`, since that's the only call-site. - Always overwrite the fileSize with the value obtained from `pdfDocument.getDownloadInfo`, to ensure that it's correct. - ES6-ify the code that's touched in this patch. Fixes 8371.	8 years ago
Tim van der Meij	6d7a0ff8f2	Convert the document properties to ES6 syntax	8 years ago
Jonas Jenwald	b0a4f6de8f	Use `createPromiseCapability` in `/web` files In various viewer files, there's a number of cases where we basically duplicate the functionality of `createPromiseCapability` manually. As far as I can tell, a couple of these cases have existed for a very long time, and notable even before the `createPromiseCapability` utility function existed. Also, since we can write ES6 code now, the patch also replaces a couple of `bind` usages with arrow functions in code that's touched in the patch.	8 years ago
Yury Delendik	8e681ce3e2	Change amd to cjs path in ES6 modules	8 years ago
Jonas Jenwald	3b35c15d42	Convert the files in the `/web` folder to ES6 modules Note that as discussed on IRC, this makes the viewer slightly slower to load only in `gulp server` mode, however the difference seem slight enough that I think it will be fine.	8 years ago
Jonas Jenwald	4046d67fde	Enable the `no-else-return` ESLint rule Using `else` after `return` is not necessary, and can often lead to unnecessarily cluttered code. By using the `no-else-return` rule in ESLint we can avoid this pattern, see http://eslint.org/docs/rules/no-else-return.	8 years ago
Jonas Jenwald	ad915f8af1	Fix errors reported by the `comma-spacing` ESLint rule http://eslint.org/docs/rules/comma-spacing	8 years ago
Yury Delendik	b6c74f2056	Moves all document.getElementById lookups into viewer.js	9 years ago
Yury Delendik	006e8fb59d	Introduces UMD headers to the web/ folder.	9 years ago
Tim van der Meij	df81b832bb	Remove unused variables	9 years ago
Manas	a2ba1b8189	Uses editorconfig to maintain consistent coding styles Removes the following as they unnecessary /* -- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -- / / vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */	10 years ago
Tim van der Meij	6abf3d6ba3	Simplify document properties field logic This patch: - Simplifies the way fields are passed to the document properties overlay - Simplifies the way fields are filled internally in the document properties overlay - Avoids passing a document properties reference to the secondary toolbar	10 years ago
Tim van der Meij	1a5de56675	Group public/private methods and add comments This patch: - Puts public methods at the top of the file - Puts private methods below the public methods and marks them with an underscore - Adds JSDoc comments to the class - Adds setDocumentAndUrl to avoid having to handle that in `viewer.js`	10 years ago
Tim van der Meij	7cf440c560	Refactor PDFDocumentProperties to be more class-like	10 years ago
Tim van der Meij	ca8f842d87	Rename DocumentProperties to PDFDocumentProperties	10 years ago
Jonas Jenwald	3974adcc22	Remove reference to GNUpdf from comment in \|DocumentProperties.parseDate\| Since the link is no longer valid, we should remove it from the comment. (Using the Internet Archive, it seems that the contents of that page was basically identical to the PDF specification.)	10 years ago
Collin Anderson	54e984c763	cleaned whitespace	10 years ago
Yury Delendik	44779f14b0	Renames and refactors PDFView to PDFViewerApplication.	11 years ago
yscumc	4acb744f77	Update document_properties.js Fix for minutes tz calculation	11 years ago
Jonas Jenwald	61e24c6f45	Small re-factoring of DocumentProperties With the changes made in PR 5169 to enable quicker display of the File size, `setFileSize()` can now be called during file loading. This function parses and localizes the file size, where the l10n is a synchronous operation. This patch: * Re-factors `setFileSize()` to only update `rawFileSize`, and moves parsing and fetching of the l10n string to a separate method that isn't called until the Document Properties dialog is actually opened. * Adds a couple of checks to make sure that `rawFileSize` is set to a positive number. * Removes the `fileName` and `fileSize` properties. Since they are parsed every time the Document Properties dialog is opened, it doesn't seem necessary to cache them.	11 years ago
Jonas Jenwald	3fd6c468b7	Attempt to display the File size quicker in the Document Properties dialog Currently the File size field in the Document Properties dialog isn't set until `PDFView.pdfDocument.getDownloadInfo()` is resolved. If the Document Properties dialog is opened while a PDF file is loading with range requests, this leads to the less desirable situation where all fields except File size are available. In cases where `PDFView.open()` is called with the `args` parameter defined, and `args` contains the property `length`, we actually know the File size when the PDF file begins to load. (This is usually the case when ranged loading is used in the Firefox addon/built-in version.) Hence we can use `args.length` to set the File size immediately when `PDFView.open()` is called, resulting in a better user experience.	11 years ago
Tim van der Meij	7ca6f0839f	Use strict equalities in web/document_properties.js	11 years ago
Jonas Jenwald	5cd6dddeee	Convert the existing overlays to use the OverlayManager	11 years ago
Jonas Jenwald	edfc78dfe7	Only update the Document Properties if the dialog is still visible when the dataAvailablePromise is resolved	11 years ago
Jonas Jenwald	c7a0b68d9a	Remove superfluous 'self' variable from web/document_properties.js	11 years ago
Jonas Jenwald	025f340228	Prevent the Document Properties from being empty when the dialog is opened before the file has started loading	11 years ago
Yury Delendik	e5e9c6e243	Fixes PDFDocumentProxy.getDownloadInfo API name (and refactoring)	11 years ago
Tim van der Meij	c952b6fb85	Miscellaneous improvements for the document properties dialog	11 years ago
Tim van der Meij	5f7ded4ff6	Document properties	11 years ago