pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Doug Thayer	0f9f0f8a9b	Cache PdfJs's enabled setting for delayed init See Bug 1389443 for more information. This allows us to register PdfJs without waiting for file IO in nsHandlerService to finish. Once that file IO is finished, we can set everything up properly and double-check the registration.	8 years ago
Jonas Jenwald	20d6286cce	Add support for, the API property, PageMode in the viewer (issue 8657) Note that the PageMode, as specified in the API, will only be honoured when either: the user hasn't set the `sidebarViewOnLoad` preference to a non-default value, or a non-default `sidebarView` entry doesn't exist in the view history, or the "pagemode" hash parameter is included in the URL. Since this is new functionality, the patch also includes a preference (`disablePageMode`), to make it easy to opt-out of this functionality if the user/implementor so wishes.	8 years ago
Rob Wu	19549bb7d6	[CRX] Integrate cursorToolOnLoad pref + migration logic Add UI for the cursorToolOnLoad pref in the UI of the Chrome extension. Add logic to migrate the enableHandToolOnLoad pref to cursorToolOnLoad. For past values in the mutable extension storage area: 1. If enableHandToolOnLoad=true, save cursorToolOnLoad=1. 2. Remove enableHandToolOnLoad. For the managed extension storage, which is immutable since it is based on administrative policies, use the following logic: 1. If enableHandToolOnLoad=true and cursorToolOnLoad=0 (default). set cursorToolOnLoad=0 and assume enableHandToolOnLoad=false. 2. As usual, managed preferences can (and will) be overridden by the user. The first migration logic is in extensions/chromium/options/migration.js and can be removed after a few months / less than many years. The second migration logic is in web/chromecom.js, and should be kept around for a long while (many years). The need for this migration logic arises from the change by: https://github.com/mozilla/pdf.js/pull/7635	8 years ago
Nimesh Solanki	e004b3cfab	update inconsistent names	8 years ago
Brendan Dahl	5834ef6ff2	Bug 1353029 - Pass PdfJs.enabled into child on change.	8 years ago
Jonas Jenwald	4f48c8198c	Fix inconsistent spacing and trailing commas in objects in `extensions/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/extensions/firefox/content/PdfStreamConverter.jsm b/extensions/firefox/content/PdfStreamConverter.jsm index ea91a71a..0d59dad1 100644 --- a/extensions/firefox/content/PdfStreamConverter.jsm +++ b/extensions/firefox/content/PdfStreamConverter.jsm @@ -773,7 +773,8 @@ class RequestListener { response = function sendResponse(aResponse) { try { var listener = doc.createEvent("CustomEvent"); - let detail = Cu.cloneInto({ response: aResponse, }, doc.defaultView); + let detail = Cu.cloneInto({ response: aResponse, }, + doc.defaultView); listener.initCustomEvent("pdf.js.response", true, false, detail); return message.dispatchEvent(listener); } catch (e) { ```	8 years ago
Yury Delendik	5438ce9b98	Wraps mozL10n to async calls; splits firefox and generic l10n libs.	8 years ago
Jonas Jenwald	36c2791296	Unify handling of various cursor tools, e.g. the current Hand Tool and a possible future Zoom Tool, in a new `PDFCursorTools` module With the current way that the `HandTool` is implemented, if someone would try to also add a Zoom tool (as issue 1260 asks for) that probably wouldn't work very well given that you'd then have two cursor tools which may not play nice together. Hence this patch, which attempts to refactor things so that it should be simpler to add e.g. a Zoom tool as well (given that that issue is marked as "good-beginner-bug", and I'm not sure if that really applies considering the current state of the code). Note that I personally have no interest in implementing a Zoom tool (similar to Adobe Reader) since I wouldn't use it, but I figured that it can't hurt to make this code a bit more future proof.	8 years ago
Jonas Jenwald	cbba74f474	Revert "Upstream changes from: Bug 1319111 - Expose result principal URL ("final channel URL") on LoadInfo, convert current consumers of LOAD_REPLACE"	8 years ago
Mark Banner	2e9ae50a3a	Use eslint-plugin-mozilla and the webextensions environment to avoid defining globals in each file.	8 years ago
Honza Bambas :mayhemer	20aa8d74e9	Upstream changes from: Bug 1319111 - Expose result principal URL ("final channel URL") on LoadInfo, convert current consumers of LOAD_REPLACE This is a downstream change introduced in [1]. That mozilla bug is adding a new property to channel's loadinfo object (nsILoadInfo) that protocol handlers has to set on channels when originalURI on the result channel is set to a different URI than the channel has been created for. Existence of the new property on nsILoadInfo depends on landing [1]. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1319111	8 years ago
Jonas Jenwald	8e976d7110	[Firefox addon] Replace a `bind(this)` statement with an arrow function in `PdfStreamConverter.jsm` (issue 8343) Please note that I used the addon debugger to set a breakpoint in the `unload` function, in order to ensure that `this` still correctly refers to the `FindEventManager` scope.	8 years ago
Jonas Jenwald	7560f12a17	Enable the `object-shorthand` ESLint rule Please see http://eslint.org/docs/rules/object-shorthand. Unfortunately, based on commit `9276d1dcd9`, it seems that we still need to maintain compatibility with old Node.js versions, hence certain files/directories that are executed in Node.js are currently exempt from this rule. Furthermore, since the files specific to the Chromium extension are not run through Babel, the `/extensions/chromium/` directory is also exempt from this rule.	8 years ago
Jonas Jenwald	b3582ccbad	Add the commit hash to the `README.mozilla` file (issue 8347)	8 years ago
Jonas Jenwald	3b59169ffc	[Firefox addon] Upstream changes from: Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales With [bug 1346616](https://bugzilla.mozilla.org/show_bug.cgi?id=1346616) and [this commit](https://hg.mozilla.org/mozilla-central/rev/39a903b099a6#l7.2), it's apparently no longer recommended to check the `general.useragent.locale` pref directly, but instead the `Services.locale.getRequestedLocale()` function should be used. In this case, it's at least really easy to feature detect this properly :-)	8 years ago
Jonas Jenwald	cf87c9bba2	[Firefox addon] Upstream changes from: Bug 1356569 - Remove optional trailing parameters (issue 8310) In https://bugzilla.mozilla.org/show_bug.cgi?id=1355216, the third parameter of `Services.obs.addObserver` was made optional. However, omitting it in Firefox versions without that patch causes failures that completely prevents the addon from working (it won't even load). As far as I can tell, there isn't any way to detect ahead of time if the third parameter can be safely omitted, hence we're forced to fallback to manually checking the version number :-( Note: Since the `PdfJs.jsm` file is only used in the `MOZCENTRAL` build, we at least don't need to add any compatibility hacks there.	8 years ago
Tim van der Meij	e7a3ea29aa	Firefox extension: remove unused preference cleanup from `bootstrap.js` The comment for the removal has been added three years ago, so we can safely remove this now.	8 years ago
Georg Fritzsche	4e8cd2b7d3	Rename PdfJsTelemetry-addon.jsm to PdfJsTelemetry-stub.jsm And remove unused linting comments.	8 years ago
Georg Fritzsche	788fe1f810	Stub out Firefox addon Telemetry wrapper We are planning to remove the addon histogram APIs from Firefox Telemetry. The easy solution here is to just stub out all calls that use them.	8 years ago
Andrew McCreight	071951d787	Lazily load NetUtil.jsm in PdfStreamConverter.jsm. This is one step towards not loading NetUtil.jsm at startup in a clean profile.	8 years ago
Andrew McCreight	740e1ab450	Skip PdfJs.enabled check in bootstrap-enabled. If we only invoke the bootstrap-enabled script when PdfJs.enabled is true, then we don't need to check it again in the script. This avoids a sync IPC call to the parent process. It also keeps PdfJs.jsm from importing PdfjsContentUtils.jsm in the child process until it is actually needed, which is one steps towards not loading it until it is really needed.	8 years ago
Andrew McCreight	d804881151	Split bootstrap script. pdfjschildbootstrap.js will always be run, but pdfjschildbootstrap-enabled.js will only be run if PdfJs.enabled is true. This will let us avoid some work in the child process in the next patch. This will need to be landed in the mozilla-central repository at the same time as a change to nsBrowserGlue.js. See bug 1352218.	8 years ago
Yury Delendik	25873e92f0	Enable babel translation to enable ES module support.	8 years ago
Jonas Jenwald	ebae24cacc	Upstream the changes from bug 1345294 - nsIPrefBranch should have methods to get/set unicode strings Note that in order to not break compatibility for the Firefox addon, the preprocessor is used. Re: [bug 1345294](https://bugzilla.mozilla.org/show_bug.cgi?id=1345294) and also [this commit](https://hg.mozilla.org/mozilla-central/rev/5a8192a650e9).	8 years ago
Jonas Jenwald	a7c19d9cbb	Adjust the `yoda` ESLint rule to apply to inequalities as well I happened to notice that some inequalities had the wrong order, and was surprised since I thought that the `yoda` rule should have caught that. However, reading http://eslint.org/docs/rules/yoda#options a bit more closely than previously, it's quite obvious that the `onlyEquality` option does exactly what its name suggests. Hence I think that it makes sense to adjust the options such that only ranges are allowed instead.	8 years ago
Rob Wu	ece44d36e8	Allow automatic print rotation via enablePrintAutoRotate	8 years ago
Jonas Jenwald	b898a453f0	[Firefox addon] Remove the unused `MOZ_CENTRAL` constant The last (and only) usage of `MOZ_CENTRAL` was removed in PR 3036, so it's been unused for almost four years now. If we need to have different code-paths for `FIREFOX`/`MOZCENTRAL` builds, the preprocessor should (and has) been used instead.	8 years ago
Rob Wu	d9f90d595d	[CRX] Recognize blob and data-URLs in the router When a blob or data-URL is opened with the extension, viewer.html rewrites the URL. But when the viewer is refreshed (e.g. F5), Chrome would fail to display the viewer because the extension router was not set up to recognize such URLs. Now it is.	8 years ago
Jonas Jenwald	7e1d92461a	[Firefox addon] Enable the `consistent-return` ESLint rule (issue 7957) See http://eslint.org/docs/rules/consistent-return; it appears that I overlooked this rule in PR 7982. Also adds the http://eslint.org/docs/rules/no-nested-ternary rule, which didn't require any code changes, since that rule is being enforced in mozilla-central. Re: issue 7957.	8 years ago
Jonas Jenwald	a5d5b970af	[Firefox addon] Enforce double quotes, using ESLint, to avoid linting errors in mozilla-central (issue 7957) Given that this patch causes a lot of churn in the addon code, I wouldn't really mind if we ultimately decide against doing this and just add a rule exception in mozilla-central instead.[1] --- [1] Note that I used the ESLint `--fix` option, hence writing this commit message actually took longer time than the creation of the patch :-)	8 years ago
Jonas Jenwald	f000417ce0	[Firefox addon] Stop bundling `src/core/network.js` into the `FIREFOX`/`MOZCENTRAL` builds (PR 7322 follow-up) PR 7322 added the `PdfJsNetwork.jsm` file, instead of the general `src/core/network.js` file for the Firefox addon. However, `make.js` wasn't updated to actually stop including the now obsolete network file.	8 years ago
Jonas Jenwald	3ec99f0e12	[Firefox addon] Convert the code to be ES6 friendly, in order to better agree with mozilla-central coding conventions (issue 7957) Please note: ignoring whitespace changes is most likely necessary for the diff to be readable. This patch addresses all the current, in `mozilla-central`, linting failures in the addon. It should thus be possible to change the `.eslintignore` entry for PDF.js in `mozilla-central` from `browser/extensions/pdfjs/` to `browser/extensions/pdfjs/build/` and `browser/extensions/pdfjs/web/**` instead. Note that we cannot, for backwards compatibility reason of the general PDF.js library, at this time make similar changes for files residing in the `build` and `web` directories in `mozilla-central`. The main changes in this patch are that we now use [classes](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes) instead of our previous "class-like" functions, and also use the more compact [object shorthand notation](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Operators/Object_initializer#New_notations_in_ECMAScript_2015). A couple of functions were also converted to [arrow functions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions), to reduced usages of `bind(this)` and `var self = this`. One caveat with ES6 classes is that it's not (yet) possible to define private constants/helper functions within them, which is why the `NetworkManagerClosure` was kept to not change the visibility of those constant/functions. Besides testing in Firefox Nightly 53, this patch has also been tested in Firefox ESR 45 and SeaMonkey 2.46. However, I'd gladly welcome help with testing the patch more, to ensure that nothing has gone wrong during the refactoring. Fixes the first bullet point of issue 7957.	8 years ago
Jonas Jenwald	0dff8f3600	Adjust the `space-unary-ops` ESLint rule to comply with mozilla-central lint rules See http://eslint.org/docs/rules/space-unary-ops; a very small part of issue 7957.	8 years ago
Jonas Jenwald	54a64863e2	[Bug 1330147] removeObserver calls should not supply a third parameter This is yet another very recent change that we were not notified about. Upstream changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1330147, specifically https://hg.mozilla.org/mozilla-central/rev/8e0b7bc5fd71.	8 years ago
Yury Delendik	1f424e561d	[Bug 1329182] remove trailing newURI null parameters	8 years ago
Jonas Jenwald	4046d67fde	Enable the `no-else-return` ESLint rule Using `else` after `return` is not necessary, and can often lead to unnecessarily cluttered code. By using the `no-else-return` rule in ESLint we can avoid this pattern, see http://eslint.org/docs/rules/no-else-return.	8 years ago
Jonas Jenwald	15f75a5585	[Firefox addon] Remove the `registerAddonHistogram` fallback code for Firefox versions 36 (and below) from `PdfJsTelemetry-addon.jsm` Given that the addon doesn't even work in Firefox versions prior to 38, this is just dead code that can now be removed.	8 years ago
Jonas Jenwald	9434c023ab	[Firefox addon] Change the minimum supported version to Firefox 45, i.e. the current ESR version, and remove no longer necessary fallback code According to https://wiki.mozilla.org/RapidRelease/Calendar#Past_branch_dates: The last ESR version of Firefox 38 was released in April this year, and since June the only available ESR version has been based on Firefox 45. Now that Seamonkey has finally released a new version, i.e. 2.46 which should correspond to Firefox 49, there doesn't seem to be any reason to keep the fallback code around in the addon anymore.	8 years ago
Jonas Jenwald	c850968fa7	Remove `globals` that are now unnecessary thanks to the use of various ESLint environments (e.g. Node, ShellJS, Jasmine)	8 years ago
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
Jonas Jenwald	28e50cfa21	Fix errors reported by the `space-infix-ops` ESLint rule http://eslint.org/docs/rules/space-infix-ops	8 years ago
Jonas Jenwald	aae27e76bb	Fix errors reported by the `no-multiple-empty-lines` ESLint rule http://eslint.org/docs/rules/no-multiple-empty-lines	8 years ago
Jonas Jenwald	ad915f8af1	Fix errors reported by the `comma-spacing` ESLint rule http://eslint.org/docs/rules/comma-spacing	8 years ago
Yury Delendik	f7d6f3a739	Adds SVG rendering capabilities to the PDFViewer.	9 years ago
Yury Delendik	a4402c84de	Refactor toolbar (and secondary toolbar).	9 years ago
Jonas Jenwald	f461fd64aa	Add support for PageLabels in the viewer This patch implements the page label functionality in a similar way as Adobe Reader. For documents with page labels, if a non-existent page label is entered we'll try to fallback to the page number instead. The patch also includes a preference (`disablePageLabels`), to make it easy to opt-out of using page labels if the user/implementor so wishes. The way that `get/set currentPageLabel` is implemented in `PDFViewer`, is as wrappers for the corresponding `get/set currentPageNumber` functions, since that seemed like the cleanest solution. The page labels are purposely only added to the page controls in the viewer UI, and not stored in e.g. the `ViewHistory`. Since doing so would mean adding unnecessary code complexity, without any real added value, and would also mean delaying the inital loading of PDF documents. Note that this patch will ignore page labels if they are identical to standard page numbering, since in this case displaying the page labels adds no value (but only UI noise). The reason for handling this case specially, is that in practice a surprising number of PDF files include "pointless" page labels.	9 years ago
Yury Delendik	0576c9c6c6	Replaces all preprocessor directives with PDFJSDev calls.	9 years ago
Rob Wu	ae74e1bbd6	Deduct file type from content-disposition A user encountered a response that looks like: URL: some gibberish Headers: Content-Type: application/octet-stream Content-Disposition: attachment; filename="something.pdf" In the Chrome extension, the "attachment" content disposition is almost always ignored (i.e. the PDF Viewer will try to view it anyway). So we need to fall back to the Content-Disposition header if the URL check is inconclusive.	9 years ago
Yury Delendik	503bf45eca	Drops unneeded HTTP refresh header for the extension. Some sites doing that by mistake. Aligning the extension functionality with behavior of other browsers/plugins..	9 years ago
Jonas Jenwald	e12c48b73f	Add a `enhanceTextSelection` preference Please note that this is a hack, but I think that it should be OK for now to atleast get the preference landed. Refer to the code comment for further information. Re: issue 7584 and PR 7586.	9 years ago

1 2 3 4 5 ...

493 Commits (c2f1ff48d574a00f7f7d60e2edb0fa3020370cd8)