pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Brendan Dahl	5834ef6ff2	Bug 1353029 - Pass PdfJs.enabled into child on change.	8 years ago
Jonas Jenwald	4f48c8198c	Fix inconsistent spacing and trailing commas in objects in `extensions/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/extensions/firefox/content/PdfStreamConverter.jsm b/extensions/firefox/content/PdfStreamConverter.jsm index ea91a71a..0d59dad1 100644 --- a/extensions/firefox/content/PdfStreamConverter.jsm +++ b/extensions/firefox/content/PdfStreamConverter.jsm @@ -773,7 +773,8 @@ class RequestListener { response = function sendResponse(aResponse) { try { var listener = doc.createEvent("CustomEvent"); - let detail = Cu.cloneInto({ response: aResponse, }, doc.defaultView); + let detail = Cu.cloneInto({ response: aResponse, }, + doc.defaultView); listener.initCustomEvent("pdf.js.response", true, false, detail); return message.dispatchEvent(listener); } catch (e) { ```	8 years ago
Mark Banner	2e9ae50a3a	Use eslint-plugin-mozilla and the webextensions environment to avoid defining globals in each file.	8 years ago
Jonas Jenwald	cf87c9bba2	[Firefox addon] Upstream changes from: Bug 1356569 - Remove optional trailing parameters (issue 8310) In https://bugzilla.mozilla.org/show_bug.cgi?id=1355216, the third parameter of `Services.obs.addObserver` was made optional. However, omitting it in Firefox versions without that patch causes failures that completely prevents the addon from working (it won't even load). As far as I can tell, there isn't any way to detect ahead of time if the third parameter can be safely omitted, hence we're forced to fallback to manually checking the version number :-( Note: Since the `PdfJs.jsm` file is only used in the `MOZCENTRAL` build, we at least don't need to add any compatibility hacks there.	8 years ago
Jonas Jenwald	ebae24cacc	Upstream the changes from bug 1345294 - nsIPrefBranch should have methods to get/set unicode strings Note that in order to not break compatibility for the Firefox addon, the preprocessor is used. Re: [bug 1345294](https://bugzilla.mozilla.org/show_bug.cgi?id=1345294) and also [this commit](https://hg.mozilla.org/mozilla-central/rev/5a8192a650e9).	8 years ago
Jonas Jenwald	7e1d92461a	[Firefox addon] Enable the `consistent-return` ESLint rule (issue 7957) See http://eslint.org/docs/rules/consistent-return; it appears that I overlooked this rule in PR 7982. Also adds the http://eslint.org/docs/rules/no-nested-ternary rule, which didn't require any code changes, since that rule is being enforced in mozilla-central. Re: issue 7957.	8 years ago
Jonas Jenwald	a5d5b970af	[Firefox addon] Enforce double quotes, using ESLint, to avoid linting errors in mozilla-central (issue 7957) Given that this patch causes a lot of churn in the addon code, I wouldn't really mind if we ultimately decide against doing this and just add a rule exception in mozilla-central instead.[1] --- [1] Note that I used the ESLint `--fix` option, hence writing this commit message actually took longer time than the creation of the patch :-)	8 years ago
Jonas Jenwald	3ec99f0e12	[Firefox addon] Convert the code to be ES6 friendly, in order to better agree with mozilla-central coding conventions (issue 7957) Please note: ignoring whitespace changes is most likely necessary for the diff to be readable. This patch addresses all the current, in `mozilla-central`, linting failures in the addon. It should thus be possible to change the `.eslintignore` entry for PDF.js in `mozilla-central` from `browser/extensions/pdfjs/` to `browser/extensions/pdfjs/build/` and `browser/extensions/pdfjs/web/**` instead. Note that we cannot, for backwards compatibility reason of the general PDF.js library, at this time make similar changes for files residing in the `build` and `web` directories in `mozilla-central`. The main changes in this patch are that we now use [classes](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes) instead of our previous "class-like" functions, and also use the more compact [object shorthand notation](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Operators/Object_initializer#New_notations_in_ECMAScript_2015). A couple of functions were also converted to [arrow functions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions), to reduced usages of `bind(this)` and `var self = this`. One caveat with ES6 classes is that it's not (yet) possible to define private constants/helper functions within them, which is why the `NetworkManagerClosure` was kept to not change the visibility of those constant/functions. Besides testing in Firefox Nightly 53, this patch has also been tested in Firefox ESR 45 and SeaMonkey 2.46. However, I'd gladly welcome help with testing the patch more, to ensure that nothing has gone wrong during the refactoring. Fixes the first bullet point of issue 7957.	8 years ago
Jonas Jenwald	54a64863e2	[Bug 1330147] removeObserver calls should not supply a third parameter This is yet another very recent change that we were not notified about. Upstream changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1330147, specifically https://hg.mozilla.org/mozilla-central/rev/8e0b7bc5fd71.	8 years ago
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
Jonas Jenwald	aae27e76bb	Fix errors reported by the `no-multiple-empty-lines` ESLint rule http://eslint.org/docs/rules/no-multiple-empty-lines	8 years ago
Brendan Dahl	815c3a822f	Bug 1291709 - PdfjsChromeUtils.jsm leaks browser.xul windows.	9 years ago
Jonas Jenwald	d3d3bb9695	[Firefox addon] Change the minimum supported version to Firefox 38 and remove a bunch old no longer necessary fallback code From the discussion in issue 7386, it wasn't really clear if we can restrict addon support to Firefox `45` (i.e. the version that corresponds to the current ESR version). However, we have a bunch of code for very old Firefox versions. Hence this patch changes the minimum supported version to Firefox `38` (which was released on `2015-05-12`, and correspond to the previous ESR version), and removes code that only applies to old Firefox versions. Regardless what we end up deciding regarding addon support for previous Firefox versions, given the amount of code that even the Firefox `>= 38` condition lets us remove, I certainly think that there is value in doing this.	9 years ago
Yury Delendik	df10513e10	Moves DEFAULT_PREFENCES into JSON format.	9 years ago
Manas	a2ba1b8189	Uses editorconfig to maintain consistent coding styles Removes the following as they unnecessary /* -- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -- / / vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */	10 years ago
Jonas Jenwald	49389c2d30	Follow-up to PR 6489 - Upstream changes from Bug 1202902 I somehow managed miss including one of the upstream changes in PR 6489; hence this patch. Sorry about the unnecessary churn in this code!	10 years ago
Jonas Jenwald	26ec36ba4c	Upstream changes from Bug 1202902 - Give loader scripts and XUL frame scripts a lexical scope that doesn't break everything? One of the patches in https://bugzilla.mozilla.org/show_bug.cgi?id=1202902, specifically [`Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff)`](https://hg.mozilla.org/mozilla-central/rev/380817d573cd), touches PDF.js code. Unfortunately it was landed upstream without, as far as I can tell, notifying us about it. This patch uplifts the relevant changes to avoid future merge conflicts, and for consistency also tweaks `PdfJs-stub.jsm`.	10 years ago
Jonas Jenwald	c82fa16dd2	[Firefox] Re-add _getTabForBrowser compatibility hack for the addon This should enable Find to work again in the current ESR version (31).	10 years ago
Jonas Jenwald	93a65921da	[Firefox] Replace the CPOW with asynchronous messages for the Fallback bar This patch removes the only remaining CPOW usage from the code-base, and should thus fix https://bugzilla.mozilla.org/show_bug.cgi?id=1071082. Note: This will not fix the "Open With Different Viewer" button in e10s, since clicking it still fails with `frontWindow is null` in the console, but I do believe that that issue is somewhat orthogonal to the current patch.	10 years ago
Jonas Jenwald	9f63fa4b07	Address review comments from Bug 1148192 - Update pdf.js to version 1.1.24 See https://bugzilla.mozilla.org/show_bug.cgi?id=1148192#c3.	10 years ago
Gabor Krizsanits	595be5cb4f	Bug 1072350 - Removing CPOWs used by Find events.	10 years ago
Jonas Jenwald	3370b18e0b	Fix code style in extensions/firefox/content/PdfjsChromeUtils.jsm	11 years ago
Jonas Jenwald	a34e7aa8fe	[Firefox] Use getTabForBrowser instead of _getTabForBrowser if possible	11 years ago
Jim Mathies	b399f19426	Bug 1064496 review changes	11 years ago
Jonas Jenwald	8d27f38c64	Rename \|_isPrefAllowed\| to \|_ensurePreferenceAllowed\| in extensions/firefox/content/PdfjsChromeUtils.jsm	11 years ago
Jonas Jenwald	3ac9bd063d	Fix setPreferences regression from the e10s patch (PR 5115)	11 years ago
Yury Delendik	7ae7fd3d1a	Adds DEFAULT_PREFERENCES to the PdfjsChromeUtils	11 years ago
Jim Mathies	f2096fe23f	Firefox pdf viewer support for e10s (Bug 942707).	11 years ago

29 Commits (c2f1ff48d574a00f7f7d60e2edb0fa3020370cd8)