pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Rob Wu	c67edabcb3	Set title using logic similar as download name The download method (and the PDF document properties) detect the file name using `getPDFFileNameFromURL`. The title ought to also display the PDF filename if available.	8 years ago
Rob Wu	228d253f30	Detect download filename based on full URL	8 years ago
Rob Wu	5fdc908f02	Recognize file name in reference fragment in getPDFFileNameFromURL The regular expression incorrectly marked a group as capturing. For `http://example.com/#file.pdf`, the expected result is "file.pdf", but instead "document.pdf" was returned.	8 years ago
Jonas Jenwald	c102232275	Append the contents of `FileAttachment` annotations to the attachments view of the sidebar, for easier access to the embedded files Other PDF viewers, e.g. Adobe Reader, seem to append `FileAttachment`s to their attachments views. One obvious difference in PDF.js is that we cannot append all the annotations on document load, since that would require parsing every page. Despite that, it still seems like a good idea to add `FileAttachment`s, since it's thus possible to access all the various types of attachments from a single place. Note: With the previous patch we display a notification when a `FileAttachment` is added to the sidebar, which thus makes appending the contents of these annotations to the sidebar slightly more visible/useful.	8 years ago
Jonas Jenwald	616e5fadff	Display a notification on the `sidebarToggle` button for PDF documents with outline/attachments A longstanding issue with the viewer is that you cannot tell if a PDF document includes an outline and/or attachments without actually opening the sidebar. This patch contains a suggested solution for that, by displaying an hide-on-interaction notification on the `sidebarToggle` button (and the relevant sidebar view buttons). Note that this was inspired by e.g. the update notification that is displayed on the menu button in Firefox. For an initial implementation, I've tried to do this in such a way that the notification isn't too distracting. Without being an UX expert, I don't think that we'd want something too in-your-face, in order to keep the viewer toolbars reasonable clean. (We probably do not want e.g. an entire notification bar in these situations, since that would take up unnecessary screen space and require actions from the user to close.) However it's certainly possible that the current notification might simply be too inconspicuous to be truly helpful to users, but we could probably iterate on that if the feature itself is deemed useful.	8 years ago
Jonas Jenwald	52e0f51917	Enable the `no-unused-vars` ESLint rule Please see http://eslint.org/docs/rules/no-unused-vars; note that this patch purposely uses the same rule options as in `mozilla-central`, such that it fixes part of issue 7957. It wasn't, in my opinion, entirely straightforward to enable this rule compared to the already existing rules. In many cases a `var descriptiveName = ...` format was used (more or less) to document the code, and I choose to place the old variable name in a trailing comment to not lose that information. I welcome feedback on these changes, since it wasn't always entirely easy to know what changes made the most sense in every situation.	8 years ago
Yury Delendik	a9cf281723	Fixes IE9 document.readyState and input.type=number issues.	8 years ago
Dave House	52360694b0	Remove ids from viewer page and thumbnail divs The id, and parsing it for the page number, is replaced by the data-page-number attribute (added here for thumbnails).	8 years ago
Jonas Jenwald	9eb9065c79	Ensure that we use the correct `paintedViewport` in `PDFPageView.cssTransform`, to avoid visual glitches on quick rotations (PR 7738 follow-up) This fixes a regression from commit `c9a0955c9c`, i.e. PR 7738. Currently if you quickly rotate a document at least twice,[1] such that rendering of a page hasn't finished for the first rotation before the last rotation is triggered, the `cssTransform` method can fail to update the page correctly leading to it looking temporarily distorted. The reason why things break is that previously we stored the `viewport` on the canvas DOM element, meaning that when it was accessed in `cssTransform` is was guaranteed to point to the `viewport` of the `zoomLayer` canvas. Generally you want to avoid storing data on DOM elements this way, and during the `PDFPageView` refactoring needed to support SVG rendering, the previous `viewport` was instead stored directly on `PDFPageView`. However, the problem is first of all that the `paintedViewport` only stores the last `viewport` computed, and second of all that there're no guarantees that it actually applies to the current `zoomLayer` canvas. If a document is rotated slowly enough that rendering finishes before the next rotation then this problem doesn't exist, but for sufficiently quick rotations rendering will be cancelled at least once and the `paintedViewport` could thus be bogus. The solution for the above problems is to ensure that we track the correct `viewport` for each DOM element (canvas or svg),[2] which seemed easist to do with a `WeakMap`.[3] --- [1] I'm able to reproduce this using the `tracemonkey` file, but please note that for pages with few operations, i.e. that render very quickly, the effect may be hard to spot. [2] One other possible solution that I briefly considered, was to wait until rendering finished before storing the current `viewport`. However, that would have caused issues with rotating a page before the first rendering operation had finished. [3] This regression took me way longer to both figure out, and fix, than I'd like to admit :-)	8 years ago
Jonas Jenwald	82ea7e6e6e	Enable the `no-unsafe-finally`/`no-octal`/`no-useless-call` ESLint rules http://eslint.org/docs/rules/no-unsafe-finally, there's just one violation which in this case can actually be ignored since there's nothing `return`ed there. http://eslint.org/docs/rules/no-octal, there're no violations in the code-base. http://eslint.org/docs/rules/no-useless-call, there's just one violation that needs to be fixed.	8 years ago
Jonas Jenwald	4626fc8342	Enable the `spaced-comment` ESLint rule Please see http://eslint.org/docs/rules/spaced-comment. Note that the exceptions added for `line` comments are intended to still allow use of the old preprocessor without linting errors. Also, I took the opportunity to improve the grammar slightly (w.r.t. capitalization and punctuation) for comments touched in the patch.	8 years ago
Jonas Jenwald	70c1a6b120	[Bug 1331081] omit addEventListener/removeEventListener's third parameter when it's false Upstream changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1331081; this patch also covers one file, `pdf_print_service.js`, that's not present in mozilla-central. Fixes 7962.	8 years ago
Yury Delendik	930a28d879	Better DOMContentLoaded handling.	8 years ago
Yury Delendik	ac2d4abf39	Removes web/default_preferences.js file.	8 years ago
Yury Delendik	77b7b84d1e	Removes rest of 'no-else-return' comments.	8 years ago
Jonas Jenwald	4046d67fde	Enable the `no-else-return` ESLint rule Using `else` after `return` is not necessary, and can often lead to unnecessarily cluttered code. By using the `no-else-return` rule in ESLint we can avoid this pattern, see http://eslint.org/docs/rules/no-else-return.	8 years ago
Jonas Jenwald	73e0daed6c	Let `finishPaintTask` in pdf_page_view.js return a promise instead, to avoid having to throw in the `paintTask.promise` rejection handler, and don't reject the `PDFPageView_draw` promise when rendering is `cancelled` As mentioned on IRC yesterday, we currently throw even when rendering is `cancelled`, which is annoying when the devtools are active. Furthermore, since `cancelled` isn't really an error, rejecting the `PDFPageView_draw` promise seems somewhat strange in that case.	8 years ago
Tim van der Meij	a428899b3c	Button widget annotations: improve unit tests, simplify code and remove labels Modern browsers support styling radio buttons and checkboxes with CSS. This makes the implementation much easier, and the fallback for older browsers is still decent.	8 years ago
Tim van der Meij	0c9a06c020	Button widget annotations: implement reference testing Moreover, ensure that the read-only state is respected and improve CSS names.	8 years ago
benweet	ba012c7a68	Button widget annotations: implement checkboxes and radio buttons	8 years ago
Jonas Jenwald	c850968fa7	Remove `globals` that are now unnecessary thanks to the use of various ESLint environments (e.g. Node, ShellJS, Jasmine)	8 years ago
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
Jonas Jenwald	a96b0f80dd	Convert the only remaining consumer (in `hand_tool.js`) of the 'localized' event to use the `localized` Promise instead, and only re-dispatch the 'localized' event on the `eventBus` for `GENERIC` builds Ideally we'd remove the 'localized' event from the `eventBus`, but for backwards compatibility we keep it in `GENERIC` builds. Note that while we want to ensure that the direction attribute of the HTML is updated as soon as the `localized` Promise is resolved, we purposely wait until the viewer has been initialized to ensure that the 'localized' event will always be dispatched.	8 years ago
Jonas Jenwald	648024f5d0	Don't call `bindEvents()` until `PDFViewerApplication` has been initialized, and move binding of `window` event listeners to a helper method, to prevent errors if an event manages to arrive too soon With `bindEvents()` now being called after the viewer has been initialized, we no longer need to have `PDFViewerApplication.initialized` checks in the event handler functions. Furthermore by moving the `window.addEventListener`s to a helper method, `PDFViewerApplication.initialized` checks are no longer necessary in the event handlers, hence we thus address part of issue 7797 here as well.	8 years ago
Jonas Jenwald	849f5dde9d	Move the `Preferences` initialization/fetching code to the top of `PDFViewerApplication.initialize`, to enable using them when initializing e.g. the viewer components Note that in quick testing using `console.time/timeEnd`, both locally and with the Firefox addon, the total run time of the entire `PDFViewerApplication.initialize` function does not seem to change with this patch.	8 years ago
Jonas Jenwald	2c1436f6cb	Refactor `PDFViewerApplication.initialize` into two methods, one that reads the Preferences and one that initializes the various viewer components	8 years ago
Jonas Jenwald	c36468cbce	Fix errors reported by the `keyword-spacing` ESLint rule http://eslint.org/docs/rules/keyword-spacing	8 years ago
Jonas Jenwald	86ba634c97	Fix errors reported by the `key-spacing` ESLint rule http://eslint.org/docs/rules/key-spacing	8 years ago
Jonas Jenwald	ad915f8af1	Fix errors reported by the `comma-spacing` ESLint rule http://eslint.org/docs/rules/comma-spacing	8 years ago
Jonas Jenwald	3820946301	Fix (most) errors reported by the `no-multi-spaces` ESLint rule http://eslint.org/docs/rules/no-multi-spaces	8 years ago
Jonas Jenwald	328e7397ea	Fix errors reported by the `no-extra-bind` ESLint rule http://eslint.org/docs/rules/no-extra-bind	8 years ago
Jonas Jenwald	fb5e756683	Fix errors reported by the `no-cond-assign` ESLint rule http://eslint.org/docs/rules/no-cond-assign	8 years ago
Yury Delendik	7b6ba5e9fd	Don't fail if mozL10n is not present.	9 years ago
Jonas Jenwald	48696a8d06	Make the keyboard shortcuts `Ctrl + Up/Down` behave as `Home/End` (issue 7852) It seems that for normal web pages, at least in Firefox, the keyboard shortcuts <kbd>Ctrl</kbd> + <kbd>Up</kbd>/<kbd>Down</kbd> are functionally equivalent to <kbd>Home</kbd>/<kbd>End</kbd>. This is obviously an edge-case, but can be easily implemented by using the same logic as we do for <kbd>Home</kbd>/<kbd>End</kbd>. Fixes 7852. Please note: I'm finding it slightly difficult to interpret issue 7852, and bug 1285719, since among other things: the title includes the word "reverse" with no other mention of it, and the STR makes reference to print preview which doesn't seem applicable to the PDF viewer. However, compared to regular web pages in Firefox, I think the behavior of this patch makes sense here.	9 years ago
Tim van der Meij	14d7e2f29c	Viewer: remove unused CSS rule This appears to have been part of the first mock-up of the viewer, but hasn't been used since.	9 years ago
Tim van der Meij	cf3a7425b6	Compatibility: refactor user agent detection This patch moves the user agent checks to the top of the file to reduce duplication and to provide a clear overview of which user agent we are detecting. Moreover, we extract inline user agent checks as well and use existing checks in more places. Finally, we fix the indenting in one place for consistency.	9 years ago
Tim van der Meij	0b0e18f05c	Compatibility: disable range request for iOS Fixes #7815.	9 years ago
Jonas Jenwald	0af42f1ca7	Rename the `ViewHistory` localStorage (and sessionStorage) key from `database` to `pdfjs.history`, and migrate existing data on read (issue 7760) For consistency, I also renamed the `FIREFOX/MOZCENTRAL` sessionStorage key, but given that sessionStorage is a lot less permanent than localStorage it didn't seem necessary to migrate any existing values. Fixes 7760.	9 years ago
Jonas Jenwald	9872660a95	Return a mock object in `paintOnSvg` when SVG rendering is not supported, to prevent `TypeError`s in the addons Currently if you try to enable SVG rendering in the addons, a `TypeError` is thrown by the browser since we have code that depends on what `paintOnCanvas`/`paintOnSvg` (should) return.	9 years ago
Jonas Jenwald	7272bb4894	Prevent "unreachable code after return statement" warnings from `PDFPageView_paintOnSvg` in the addons Follow-up to PR 7738.	9 years ago
Yury Delendik	f7d6f3a739	Adds SVG rendering capabilities to the PDFViewer.	9 years ago
Yury Delendik	c9a0955c9c	Refactors PDFPageView_draw.	9 years ago
Yury Delendik	a4402c84de	Refactor toolbar (and secondary toolbar).	9 years ago
Jonas Jenwald	db2ce3ff64	Replace the Safari detection in `checkRangeRequests` in compatibility.js with a regular expression According to e.g. issue 7754, it appears that the current `isSafari` check is failing in newer version of the browser. Despite the fact that checking the userAgent is an anti-pattern, which should be avoided, it's currently the simplest solution.	9 years ago
Jonas Jenwald	a97bc16fbc	Make the `customScaleOption` disabled to prevent it being keyboard accessible (bug 1315608) Given that the `customScaleOption` should already be hidden, provided that the browser supports that, this patch also prevents it from being accessible via the keyboard. As far as my testing goes in various browsers, this doesn't seem to have any ill effects, and note that we're already explicitly ignoring the `custom` value in the `select` event handler. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1315608.	9 years ago
Tim van der Meij	f95915fc73	Viewer: amend `.sidebarOpen` responsiveness rules with rules for `.sidebarMoving`	9 years ago
Tim van der Meij	28ef012727	Viewer: improve responsiveness and clean up CSS This patch resolves the responsiveness issues for the toolbar in the viewer. Depending on the language (for example the Dutch language), elements could overlap when the viewport size is reduced. The main issue here is that the CSS rules are unnecessarily complex and handle lots of different cases (LTR/RTL, displacements for specific viewport widths, et cetera). By removing this complexity and letting the browser handle the responsiveness, we not only get simpler CSS rules and HTML mark-up, but the responsiveness issues are mostly fixed at the same time. We no longer have to position the elements manually (by setting their `left` attribute value) anymore.	9 years ago
Shain Lafazan	7fec8de502	Additional check to ensure pdfViewer object is defined before handleMouseWheel event accesses its property isInPresentationMode	9 years ago
Rob Wu	594592216c	Refactor printing: startPrint -> performPrint - Renamed startPrint to performPrint to emphasize that the method does not start the print process (preparing pages for the printer), but that it does the actual printing (sending pages off to the printer). - Put performPrint in the PDFPrintService, so that it can be overridden if needed.	9 years ago
Rob Wu	d3b13e36d3	Refactor page printing logic on the web - Move the global scratchCanvas to PDFPrintService. This is mainly to make it easier to reason about the state of scratchCanvas. In practice there is no difference because only one PDFPrintService instance can be instantiated at any given time. - Move all logic of using the rendered page to one location. This makes it easier to replace the printing logic later, when I add special handling to out-of-process frames in the Chrome extension.	9 years ago

1 2 3 4 5 ...

1904 Commits (c67edabcb3a566a97c9610a93aa04284b10aadc7)