akira/pdfjs-dist - pdfjs-dist - Gitea: Git with a cup of tea

Tree: d0e93721ae

Author	SHA1	Message	Date
Jonas Jenwald	223c429357	Fix inconsistent spacing and trailing commas in objects in `web/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/web/pdf_thumbnail_view.js b/web/pdf_thumbnail_view.js index 002dbf29..1de4e530 100644 --- a/web/pdf_thumbnail_view.js +++ b/web/pdf_thumbnail_view.js @@ -420,8 +420,8 @@ var PDFThumbnailView = (function PDFThumbnailViewClosure() { setPageLabel: function PDFThumbnailView_setPageLabel(label) { this.pageLabel = (typeof label === 'string' ? label : null); - this.l10n.get('thumb_page_title', { page: this.pageId, }, 'Page {{page}}'). - then((msg) => { + this.l10n.get('thumb_page_title', { page: this.pageId, }, + 'Page {{page}}').then((msg) => { this.anchor.title = msg; }); diff --git a/web/secondary_toolbar.js b/web/secondary_toolbar.js index 160e0410..6495fc5e 100644 --- a/web/secondary_toolbar.js +++ b/web/secondary_toolbar.js @@ -65,7 +65,8 @@ class SecondaryToolbar { { element: options.printButton, eventName: 'print', close: true, }, { element: options.downloadButton, eventName: 'download', close: true, }, { element: options.viewBookmarkButton, eventName: null, close: true, }, - { element: options.firstPageButton, eventName: 'firstpage', close: true, }, + { element: options.firstPageButton, eventName: 'firstpage', + close: true, }, { element: options.lastPageButton, eventName: 'lastpage', close: true, }, { element: options.pageRotateCwButton, eventName: 'rotatecw', close: false, }, @@ -76,7 +77,7 @@ class SecondaryToolbar { { element: options.cursorHandToolButton, eventName: 'switchcursortool', eventDetails: { tool: CursorTool.HAND, }, close: true, }, { element: options.documentPropertiesButton, - eventName: 'documentproperties', close: true, } + eventName: 'documentproperties', close: true, }, ]; this.items = { firstPage: options.firstPageButton, ```	8 years ago
Yury Delendik	5438ce9b98	Wraps mozL10n to async calls; splits firefox and generic l10n libs.	8 years ago
Yury Delendik	66c8893815	Removes last UMDs from the modules.	8 years ago
Tim van der Meij	e7a04fc82d	Convert the overlay manager to ES6 syntax	8 years ago
Jonas Jenwald	f27b5013e2	Replace unnecessary `bind(this)` statements with arrow functions in `web/` files By using `let`, which is block-scoped, instead of `var` in a couple of places we're able to get rid of additional `bind` calls.	8 years ago
Jonas Jenwald	2a0207ccaf	Enable the `object-shorthand` ESLint rule in `web` Please see http://eslint.org/docs/rules/object-shorthand. For the most part, these changes are of the search-and-replace kind, and the previously enabled `no-undef` rule should complement the tests in helping ensure that no stupid errors crept into to the patch.	8 years ago
Yury Delendik	8e681ce3e2	Change amd to cjs path in ES6 modules	8 years ago
Jonas Jenwald	b2c3f8f081	Convert a number of `import * as pdfjsLib from 'pdfjs-web/pdfjs';` cases to only specify the necessary imports Rather than always importing everything from the `web/pdfjs.js`, similar to all other imports we can just choose what we actually need.	8 years ago
Jonas Jenwald	3b35c15d42	Convert the files in the `/web` folder to ES6 modules Note that as discussed on IRC, this makes the viewer slightly slower to load only in `gulp server` mode, however the difference seem slight enough that I think it will be fine.	8 years ago
Rob Wu	775441b7c6	Refactor: configurable page rotation in print job Determine the page rotation at the same place as where the page size is determined. This allows us to implement custom print page rotation logic in one place, in the future.	8 years ago
Jonas Jenwald	52e0f51917	Enable the `no-unused-vars` ESLint rule Please see http://eslint.org/docs/rules/no-unused-vars; note that this patch purposely uses the same rule options as in `mozilla-central`, such that it fixes part of issue 7957. It wasn't, in my opinion, entirely straightforward to enable this rule compared to the already existing rules. In many cases a `var descriptiveName = ...` format was used (more or less) to document the code, and I choose to place the old variable name in a trailing comment to not lose that information. I welcome feedback on these changes, since it wasn't always entirely easy to know what changes made the most sense in every situation.	8 years ago
Jonas Jenwald	82ea7e6e6e	Enable the `no-unsafe-finally`/`no-octal`/`no-useless-call` ESLint rules http://eslint.org/docs/rules/no-unsafe-finally, there's just one violation which in this case can actually be ignored since there's nothing `return`ed there. http://eslint.org/docs/rules/no-octal, there're no violations in the code-base. http://eslint.org/docs/rules/no-useless-call, there's just one violation that needs to be fixed.	8 years ago
Jonas Jenwald	4626fc8342	Enable the `spaced-comment` ESLint rule Please see http://eslint.org/docs/rules/spaced-comment. Note that the exceptions added for `line` comments are intended to still allow use of the old preprocessor without linting errors. Also, I took the opportunity to improve the grammar slightly (w.r.t. capitalization and punctuation) for comments touched in the patch.	8 years ago
Jonas Jenwald	70c1a6b120	[Bug 1331081] omit addEventListener/removeEventListener's third parameter when it's false Upstream changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1331081; this patch also covers one file, `pdf_print_service.js`, that's not present in mozilla-central. Fixes 7962.	8 years ago
Rob Wu	594592216c	Refactor printing: startPrint -> performPrint - Renamed startPrint to performPrint to emphasize that the method does not start the print process (preparing pages for the printer), but that it does the actual printing (sending pages off to the printer). - Put performPrint in the PDFPrintService, so that it can be overridden if needed.	9 years ago
Rob Wu	d3b13e36d3	Refactor page printing logic on the web - Move the global scratchCanvas to PDFPrintService. This is mainly to make it easier to reason about the state of scratchCanvas. In practice there is no difference because only one PDFPrintService instance can be instantiated at any given time. - Move all logic of using the rendered page to one location. This makes it easier to replace the printing logic later, when I add special handling to out-of-process frames in the Chrome extension.	9 years ago
Rob Wu	0c21ebf9f3	Close overlay if print service was not initialized Fixes #7720	9 years ago
Rob Wu	1c869906c8	Strictly manage lifetime of PDFPrintService Make sure that the print service is stopped as soon as possible when aborted, and that it is not possible for a (slow) promise to accidentally wipe the state of a print job that was started later.	9 years ago
Yury Delendik	1a056caf88	Localization of the print dialog.	9 years ago
Yury Delendik	c09f634bb6	Removes mozPrintCallback polyfill, converts canvas to PNG.	9 years ago