pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Tim van der Meij	db52e4fb73	Merge pull request #8536 from Snuffleupagus/refactor-ObjectLoader Refactor `ObjectLoader` to use `Dict`s correctly, rather than abusing their internal properties	8 years ago
Tim van der Meij	a6311471a7	Merge pull request #8539 from Snuffleupagus/rm-load-currentScale-call Remove a redundant `PDFViewer.currentScale` call from `PDFViewerApplication.load`	8 years ago
Jonas Jenwald	4aab3cef4a	Remove a redundant `PDFViewer.currentScale` call from `PDFViewerApplication.load` Since this call occurs before the `PDFViewer.setDocument` call, it won't actually cause any scale change. Furthermore, moving it should not be necessary, since the `scale` is already used as the fallback case in `PDFViewerApplication.setInitialView` (provided it's non-zero, which isn't even the case in the default viewer). Hence this patch should cause no functional changes at all, since it simply removes a piece of unnecessary code.	8 years ago
Tim van der Meij	8e9b4b5ff2	Merge pull request #8535 from Snuffleupagus/app-close-pageRotation-downloadComplete Reset `pageRotation` and `downloadComplete` in `PDFViewerApplication.close`	8 years ago
Tim van der Meij	7215e9c52e	Merge pull request #8525 from curiosity26/master Allow for unbinding of events in web application	8 years ago
Jonas Jenwald	73234577e1	Rename `map` to `_map` inside of `Dict`, to make it clearer that it should be regarded as a "private" property	8 years ago
Jonas Jenwald	e4d032c5c7	Reset `pageRotation` and `downloadComplete` in `PDFViewerApplication.close` Currently, these properties are reset in what appears to be somewhat arbitrary locations (within the `load` and `open` methods respectively). The explanation is probably that both of these properties predates the existence of any centralized clean-up code in the viewer. Hence I think that it makes sense to move the resetting of these properties to the `close` method, since that improves the overview of what's actually cleaned-up/reset when changing documents in the viewer.	8 years ago
Jonas Jenwald	3a20fd165f	Refactor `ObjectLoader` to use `Dict`s correctly, rather than abusing their internal properties The `ObjectLoader` currently takes an Object as input, despite actually working with `Dict`s internally. This means that at the (two) existing call-sites, we're passing in the "private" `Dict.map` property directly. Doing this seems like an anti-pattern, and we could (and even should) simply provide the actual `Dict` when creating an `ObjectLoader` instance. Accessing properties stored in the `Dict` is now done using the intended methods instead, in particular `getRaw` which (as the name suggests) doesn't do any de-referencing, thus maintaining the current functionality of the code. The only functional change in this patch is that `ObjectLoader.load` will now ignore empty nodes, such that `ObjectLoader._walk` only needs to deal with nodes that are known to contain data. (This lets us skip, among other checks, meaningless `addChildren` function calls.)	8 years ago
Jonas Jenwald	f2fc9ee281	Slightly refactor and ES6-ify the code in `ObjectLoader` This patch changes all `var` to `let`, and caches the array lengths in all loops. Also removes two unnecessary temporary variable assignments.	8 years ago
Yury Delendik	0c93dee0de	Merge pull request #8515 from yurydelendik/bloborigin Adds special case for origin of blob to the compatibility URL.	8 years ago
Yury Delendik	209751346c	Merge pull request #8531 from Snuffleupagus/rm-updatePosition Remove `PDFPageView.updatePosition` since it's not actually necessary	8 years ago
curiosity26	8326304271	Allow for unbinding of events in web application Hold bound event listeners for later unbinding ES6 styling More ES6 styling and code cleanup Remove 4 space indents and remove delete statements.	8 years ago
Jonas Jenwald	70d6550002	Remove `PDFPageView.updatePosition` since it's not actually necessary This method is currently called from `PDFViewer._scrollUpdate` on every scroll event in the viewer. However, I cannot see why this code is now necessary (assuming that it once was), since text-selection and searching still works exactly the same way with this patch as with the current `master`. When `PDFPageView.updatePosition` is called, the page can be in either of these states: 1. The page hasn't been rendered, in which case the `textLayer` property doesn't exist yet. 2. The page is currently rendering, meaning that the `textLayer` property exists. Given that the `textContent` won't be fetched until the page has been successfully rendered, `TextLayerBuilder.render` will return immediately and effectively be a no-op (since there's nothing to render yet). 3. The has been been rendered, and the `textLayer` is currently rendering. 4. The page, and its `textLayer`, has been completely rendered. In this case, `TextLayerBuilder.render` will return immediately and effectively be a no-op. Here, only the third case seem to require any further analysis: When scrolling occurs while the `textLayer` is rendering, `TextLayerBuilder.render` will via a helper method call `TextLayerRenderTask.cancel` (in src/display/text_layer.js) to stop processing. However, due to the run-to-completion nature of JavaScript, once `TextLayerRenderTask._render` has been invoked `appendText` will always run.[1] So even though we cancel rendering of pending `textLayer`s during scrolling, via the repeated `TextLayerBuilder.render` calls from within the `PDFPageView.updatePosition` method, that does not prevent us from running the code inside of `TextLayerRenderTask._render` over and over for the same page; which all seems very inefficient to me.[2] All this will thus have the effect of delaying the actual rendering of a `textLayer` ever so slightly while scrolling in the viewer. However, it does so at the expense of potentially hundreds of unnecessary `appendText` calls.[3] Hence it seems to me that it's less resource intensive overall to simply let rendering of the `textLayer` complete, once it has started. Obviously, we still abort all rendering of a page, and its `textLayer`, when it's being destroyed (e.g. by being evicted from the page cache). In case that there's any worry that the patch could affect e.g. highlighting of search results, please note that the existing code in `TextLayerBuilder.render` already calls `updateMatches` when the `TextLayerTask` resolves successfully. I'm sorry that this became quite long, but to try and summarize: `PDFPageView.updatePosition` doesn't actually do anything in most cases. In the one case where it matters, it seems that it's actually doing more harm than good; which is why I'm proposing that we just remove it. --- [1] Although we may be able to skip the `render` call, provided that it happens after a `timeout` (as is the case in the default viewer). [2] With current work being done to support streaming of `TextContent`, we'd also need to add just as many duplicate API calls to `PDFPageView.updatePosition`. [3] The number of duplicate `appendText` calls is directly proportional not only to the scroll speed, but also to the number of pages in the document.	8 years ago
Yury Delendik	82f3145a5d	Merge pull request #8522 from yurydelendik/weakmapfix Fixes WeakMap polyfill (and improves PDFWorker port check).	8 years ago
Yury Delendik	631e6bebff	Fixes WeakMap polyfill (and improves PDFWorker port check).	8 years ago
Yury Delendik	b44848b918	Adds special case for origin of blob to the compatibility URL.	8 years ago
Jonas Jenwald	e5ac64f81f	Merge pull request #8519 from yurydelendik/issue8476 Preventing from using the same canvas for multiple render()	8 years ago
Yury Delendik	24f14d44cb	Preventing from using the same canvas for multiple render()	8 years ago
Tim van der Meij	c26e497244	Merge pull request #8401 from yurydelendik/dist-install Adds gulp dist-install command; using pdfjs-dist package in examples.	8 years ago
Jonas Jenwald	0ca6132ad2	Merge pull request #8517 from yurydelendik/global2.0 Additional check in globalScope detections	8 years ago
Yury Delendik	a18caa730d	Adds gulp dist-install command; using pdfjs-dist package in examples.	8 years ago
Yury Delendik	db7a770542	Additional check in globalScope detections	8 years ago
Jonas Jenwald	c2641045e6	Update l10n files	8 years ago
Yury Delendik	08c6437196	Merge pull request #8510 from Snuffleupagus/zoom-dropdown-glitches Prevent the Zoom dropdown from intermittently displaying an incorrect custom scale in Firefox (PR 8394 follow-up)	8 years ago
Jonas Jenwald	1766fe8184	Merge pull request #8508 from yurydelendik/issue8246 Fixes duplicate creation of PDFWorker for the same port.	8 years ago
Jonas Jenwald	75edb859ce	Refactor the `selectScaleOption` function, in `Toolbar._updateUIState`, to prevent any possible future display glitches Since the localization service is now asynchronous, depending on the load the browser is under, there's a small risk that the lookup of the 'page_scale_percent' string could be delayed slightly. If the scale would change a couple of times in very quick succession, there's perhaps a theoretical possibility that the Zoom dropdown would display an incorrect value. Consider the following, somewhat contrived, theoretical example of two zoom commands being executed right after one another: ```javascript PDFViewerApplication.pdfViewer.currentScale = 1.23; PDFViewerApplication.pdfViewer.currentScaleValue = 'page-width'; ``` Only the `currentScale` call will currently trigger a l10n lookup in `selectScaleOption`. However, as far as I understand, there's no guarantee that the l10n string is resolved before `selectScaleOption` is called again as a result of the `currentScaleValue` call. This thus has the possibility of putting the Zoom dropdown into an inconsistent state, since it's currently updated synchronously for one code-path and asynchronously for another. To avoid these issues, I'm proposing that we always update the Zoom dropdown asynchronously, such that we can guarantee that the ordering is correct.	8 years ago
Jonas Jenwald	2971f522d4	Prevent the Zoom dropdown from intermittently displaying an incorrect custom scale in Firefox (PR 8394 follow-up) After PR 8394, at least in Firefox, the Zoom dropdown now frequently displays an old custom scale instead of the correct one. To see this behaviour, the following STR works for me: 1. Open https://mozilla.github.io/pdf.js/web/viewer.html. 2. Zoom in, by clicking on the corresponding button in the toolbar. 3. Run `PDFViewerApplication.pdfViewer.currentScaleValue` in the console. 4. Compare what's displayed in the Zoom dropdown with what's printed in the console. (If no difference can be observed, try repeating steps 2 through 4 a couple of times.) I really don't understand why this happens, but it seems that waiting until a custom scale has been set before selecting it fixes things in Firefox (and works fine in e.g. Chrome as well). Note that this patch thus makes this particular piece of the code consistent with the state prior to PR 8394.	8 years ago
Yury Delendik	69c804a0f4	Fixes duplicate creation of PDFWorker for the same port.	8 years ago
Jonas Jenwald	f34d692758	Merge pull request #8441 from Snuffleupagus/issue-8330 Ensure that `TilingPattern`s have valid (non-zero) /BBox arrays (issue 8330)	8 years ago
Jonas Jenwald	e589834f13	Ensure that `TilingPattern`s have valid (non-zero) /BBox arrays (issue 8330) Fixes 8330.	8 years ago
Yury Delendik	9342054502	Merge pull request #8430 from mukulmishra18/sendWithStream Adds sendWithStream method in MessageHandler.	8 years ago
Tim van der Meij	e6f5b3e37e	Merge pull request #8499 from Snuffleupagus/issue-8498 Prevent console errors when clicking to change page while in Presentation Mode (issue 8498)	8 years ago
Mukul Mishra	bbd9968f76	Added sendWithStream method in MessageHandler. Adds functionality to accept Queueing Strategy in sendWithStream method. Using Queueing Strategy we can control the data that is enqueued into the sink, and hence regulated the flow of chunks from worker to main thread. Adds capability in pull and cancel methods. Adds ready and desiredSize property in streamSink. Adds unit test for ReadableStream and sendWithStream.	8 years ago
Jonas Jenwald	3f2d5cfcc3	Prevent console errors when clicking to change page while in Presentation Mode (issue 8498) The click handler used in Presentation Mode didn't check if the first/last page was already reached, which after PR 7529 now causes an unnecessary console error. Hence we should simply use the already existing `_goToPreviousPage`/`_goToNextPage` methods instead, since they do the necessary bounds checking. Fixes 8498.	8 years ago
Brendan Dahl	edd7d89fe5	Merge pull request #8467 from mozilla/bug1353029 Bug 1353029 - Pass PdfJs.enabled into child on change.	8 years ago
Brendan Dahl	5834ef6ff2	Bug 1353029 - Pass PdfJs.enabled into child on change.	8 years ago
Jonas Jenwald	e696589a09	Update l10n files	8 years ago
Jonas Jenwald	fccb0b5cf8	Merge pull request #8483 from timvandermeij/es6-find-controller Convert the find controller to ES6 syntax	8 years ago
Tim van der Meij	9a95d91b92	Convert the find controller to ES6 syntax Moreover, rename `FindStates` to `FindState` since enumeration names are usually not in plural, for readability and consistency with the ones in `src/shared/util.js`.	8 years ago
Tim van der Meij	8654635b0b	Merge pull request #8482 from timvandermeij/es6-thumbnails Convert the thumbnail view/viewer to ES6 syntax	8 years ago
Tim van der Meij	733a58a315	Convert the thumbnail view to ES6 syntax	8 years ago
Tim van der Meij	a682d77e71	Convert the thumbnail viewer to ES6 syntax	8 years ago
Tim van der Meij	63b89c1100	Merge pull request #8478 from Snuffleupagus/ESLint-object-styles Fix the remaining cases of inconsistent spacing and trailing commas in objects, and enable the `comma-dangle` and `object-curly-spacing` ESLint rules	8 years ago
Jonas Jenwald	4a906955c4	Fix the remaining cases of inconsistent spacing and trailing commas in objects, and enable the `comma-dangle` and `object-curly-spacing` ESLint rules http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/gulpfile.js b/gulpfile.js index d18b9c58..7d47fd8d 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -1247,7 +1247,8 @@ gulp.task('gh-pages-git', ['gh-pages-prepare', 'wintersmith'], function () { var reason = process.env['PDFJS_UPDATE_REASON']; safeSpawnSync('git', ['init'], { cwd: GH_PAGES_DIR, }); - safeSpawnSync('git', ['remote', 'add', 'origin', REPO], { cwd: GH_PAGES_DIR, }); + safeSpawnSync('git', ['remote', 'add', 'origin', REPO], + { cwd: GH_PAGES_DIR, }); safeSpawnSync('git', ['add', '-A'], { cwd: GH_PAGES_DIR, }); safeSpawnSync('git', [ 'commit', '-am', 'gh-pages site created via gulpfile.js script', ```	8 years ago
Tim van der Meij	a3fae906a6	Merge pull request #8474 from Snuffleupagus/ESLint-object-styles-src-core Fix inconsistent spacing and trailing commas in objects in `src/core/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on	8 years ago
Tim van der Meij	4c6c61419b	Merge pull request #8475 from Snuffleupagus/ESLint-object-styles-src Fix inconsistent spacing and trailing commas in objects in remaining `src/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on	8 years ago
Tim van der Meij	02971892af	Merge pull request #8477 from Snuffleupagus/ESLint-object-styles-test Fix inconsistent spacing and trailing commas in objects in `test/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on	8 years ago
Jonas Jenwald	efbd68efef	Fix inconsistent spacing and trailing commas in objects in `test/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/test/chromium/test-telemetry.js b/test/chromium/test-telemetry.js index cc412a31..2e5bdfa1 100755 --- a/test/chromium/test-telemetry.js +++ b/test/chromium/test-telemetry.js @@ -324,7 +324,7 @@ var tests = [ var window = createExtensionGlobal(); telemetryScript.runInNewContext(window); window.chrome.runtime.getManifest = function() { - return { version: '1.0.1', }; + return { version: '1.0.1', }; }; window.Date.test_now_value += 12 * 36E5; telemetryScript.runInNewContext(window); diff --git a/test/unit/api_spec.js b/test/unit/api_spec.js index 1f00747a..f22988e7 100644 --- a/test/unit/api_spec.js +++ b/test/unit/api_spec.js @@ -503,8 +503,9 @@ describe('api', function() { it('gets destinations, from /Dests dictionary', function(done) { var promise = doc.getDestinations(); promise.then(function(data) { - expect(data).toEqual({ chapter1: [{ gen: 0, num: 17, }, { name: 'XYZ', }, - 0, 841.89, null], }); + expect(data).toEqual({ + chapter1: [{ gen: 0, num: 17, }, { name: 'XYZ', }, 0, 841.89, null], + }); done(); }).catch(function (reason) { done.fail(reason); diff --git a/test/unit/function_spec.js b/test/unit/function_spec.js index 66441212..62127eb9 100644 --- a/test/unit/function_spec.js +++ b/test/unit/function_spec.js @@ -492,9 +492,11 @@ describe('function', function() { it('check compiled mul', function() { check([0.25, 0.5, 'mul'], [], [0, 1], [{ input: [], output: [0.125], }]); check([0, 'mul'], [0, 1], [0, 1], [{ input: [0.25], output: [0], }]); - check([0.5, 'mul'], [0, 1], [0, 1], [{ input: [0.25], output: [0.125], }]); + check([0.5, 'mul'], [0, 1], [0, 1], + [{ input: [0.25], output: [0.125], }]); check([1, 'mul'], [0, 1], [0, 1], [{ input: [0.25], output: [0.25], }]); - check([0, 'exch', 'mul'], [0, 1], [0, 1], [{ input: [0.25], output: [0], }]); + check([0, 'exch', 'mul'], [0, 1], [0, 1], + [{ input: [0.25], output: [0], }]); check([0.5, 'exch', 'mul'], [0, 1], [0, 1], [{ input: [0.25], output: [0.125], }]); check([1, 'exch', 'mul'], [0, 1], [0, 1], ```	8 years ago
Jonas Jenwald	f20d2cd2ae	Fix inconsistent spacing and trailing commas in objects in remaining `src/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/src/display/canvas.js b/src/display/canvas.js index 5739f6f2..4216b2d2 100644 --- a/src/display/canvas.js +++ b/src/display/canvas.js @@ -2071,7 +2071,7 @@ var CanvasGraphics = (function CanvasGraphicsClosure() { var map = []; for (var i = 0, ii = positions.length; i < ii; i += 2) { map.push({ transform: [scaleX, 0, 0, scaleY, positions[i], - positions[i + 1]], x: 0, y: 0, w: width, h: height, }); + positions[i + 1]], x: 0, y: 0, w: width, h: height, }); } this.paintInlineImageXObjectGroup(imgData, map); }, diff --git a/src/display/svg.js b/src/display/svg.js index 9eb05dfa..2aa21482 100644 --- a/src/display/svg.js +++ b/src/display/svg.js @@ -458,7 +458,11 @@ SVGGraphics = (function SVGGraphicsClosure() { for (var x = 0; x < fnArrayLen; x++) { var fnId = fnArray[x]; - opList.push({ 'fnId': fnId, 'fn': REVOPS[fnId], 'args': argsArray[x], }); + opList.push({ + 'fnId': fnId, + 'fn': REVOPS[fnId], + 'args': argsArray[x], + }); } return opListToTree(opList); }, ```	8 years ago
Jonas Jenwald	a8c87f8019	Fix inconsistent spacing and trailing commas in objects in `src/core/` files, so we can enable the `comma-dangle` and `object-curly-spacing` ESLint rules later on Unfortunately this patch is fairly big, even though it only covers the `src/core` folder, but splitting it even further seemed difficult. http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing Given that we currently have quite inconsistent object formatting, fixing this in one big patch probably wouldn't be feasible (since I cannot imagine anyone wanting to review that); hence I've opted to try and do this piecewise instead. Please note: This patch was created automatically, using the ESLint --fix command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/src/core/evaluator.js b/src/core/evaluator.js index abab9027..dcd3594b 100644 --- a/src/core/evaluator.js +++ b/src/core/evaluator.js @@ -2785,7 +2785,8 @@ var EvaluatorPreprocessor = (function EvaluatorPreprocessorClosure() { t['Tz'] = { id: OPS.setHScale, numArgs: 1, variableArgs: false, }; t['TL'] = { id: OPS.setLeading, numArgs: 1, variableArgs: false, }; t['Tf'] = { id: OPS.setFont, numArgs: 2, variableArgs: false, }; - t['Tr'] = { id: OPS.setTextRenderingMode, numArgs: 1, variableArgs: false, }; + t['Tr'] = { id: OPS.setTextRenderingMode, numArgs: 1, + variableArgs: false, }; t['Ts'] = { id: OPS.setTextRise, numArgs: 1, variableArgs: false, }; t['Td'] = { id: OPS.moveText, numArgs: 2, variableArgs: false, }; t['TD'] = { id: OPS.setLeadingMoveText, numArgs: 2, variableArgs: false, }; diff --git a/src/core/jbig2.js b/src/core/jbig2.js index 5a17d482..71671541 100644 --- a/src/core/jbig2.js +++ b/src/core/jbig2.js @@ -123,19 +123,22 @@ var Jbig2Image = (function Jbig2ImageClosure() { { x: -1, y: -1, }, { x: 0, y: -1, }, { x: 1, y: -1, }, { x: -2, y: 0, }, { x: -1, y: 0, }], [{ x: -3, y: -1, }, { x: -2, y: -1, }, { x: -1, y: -1, }, { x: 0, y: -1, }, - { x: 1, y: -1, }, { x: -4, y: 0, }, { x: -3, y: 0, }, { x: -2, y: 0, }, { x: -1, y: 0, }] + { x: 1, y: -1, }, { x: -4, y: 0, }, { x: -3, y: 0, }, { x: -2, y: 0, }, + { x: -1, y: 0, }] ]; var RefinementTemplates = [ { coding: [{ x: 0, y: -1, }, { x: 1, y: -1, }, { x: -1, y: 0, }], - reference: [{ x: 0, y: -1, }, { x: 1, y: -1, }, { x: -1, y: 0, }, { x: 0, y: 0, }, - { x: 1, y: 0, }, { x: -1, y: 1, }, { x: 0, y: 1, }, { x: 1, y: 1, }], + reference: [{ x: 0, y: -1, }, { x: 1, y: -1, }, { x: -1, y: 0, }, + { x: 0, y: 0, }, { x: 1, y: 0, }, { x: -1, y: 1, }, + { x: 0, y: 1, }, { x: 1, y: 1, }], }, { - coding: [{ x: -1, y: -1, }, { x: 0, y: -1, }, { x: 1, y: -1, }, { x: -1, y: 0, }], - reference: [{ x: 0, y: -1, }, { x: -1, y: 0, }, { x: 0, y: 0, }, { x: 1, y: 0, }, - { x: 0, y: 1, }, { x: 1, y: 1, }], + coding: [{ x: -1, y: -1, }, { x: 0, y: -1, }, { x: 1, y: -1, }, + { x: -1, y: 0, }], + reference: [{ x: 0, y: -1, }, { x: -1, y: 0, }, { x: 0, y: 0, }, + { x: 1, y: 0, }, { x: 0, y: 1, }, { x: 1, y: 1, }], } ]; ```	8 years ago

1 2 3 4 5 ...

9873 Commits (db52e4fb73dcb0eb47d88a7a09ec82c3374fe052) All Branches Search

9873 Commits (db52e4fb73dcb0eb47d88a7a09ec82c3374fe052)

All Branches