pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	fa341169a2	Add (and adjust) a couple of findbar `title` attributes, in `viewer.html`, that doesn't agree with the `l10n/en-US/viewer.properties` file The point of this patch is to fix a couple of inconsistencies in `viewer.html`, compared to the locale files, such that the viewer would work correctly even without the `l10n/` files present. Note: Since this isn't changing any of the locale files, we should not need to update any of the string names. Looking through the history of the findbar code, it seems that the `findPrevious`/`findNext` buttons have never had a `title` set (note PR 2168, which was the initial findbar implementation). Furthermore, the `placeholder` of the `findInput` didn't agree 100% with locale file either, so this is also adjusted.	8 years ago
River Lune	3aeef8402b	Changing the order of logical conditions to prefer 'window' in the case where webpack is not used. Updating brace style. Updating to throw new error vs. throwing a string.	8 years ago
Jonas Jenwald	8f96909e97	Remove unnecessary `.toolbarButton.group` CSS class I noticed that we have a `.toolbarButton.group` CSS class, which is currently applied to some buttons in the viewer. Since it attempts to adjust the `margin-right` property, I was initially a bit puzzled as to why there wasn't different rules for LTR/RTL locales. However, checking the viewer with the DevTools inspector, in both LTR and RTL locales, I quickly found that the rule in question is always being overridden by other CSS rules. It thus seem to me that while this rule was probably useful at some point, it has been dead for years and could now be removed.	8 years ago
Jonas Jenwald	b151666c53	Viewer: consistently wrap find bar elements for small screen sizes This patch ensures that the find bar is not extended to the window width when element wrapping occurs on small screens.	8 years ago
Tim van der Meij	87a30a7ee1	Viewer: enable find functionality for small devices The find functionality is currently not available for small devices because the find dialog is not responsive. This patch fixes that. To achieve this goal, the HTML is changed to always show the find button. To prevent issues because of the addition of an extra button for small views, the previous/next page buttons are hidden if the view becomes small. These buttons are not useful anyway because on small devices navigation is usually done via scrolling. The find functionality is much more useful to have in this case. Moreover, we wrap the existing elements into separate `div`s so that the browser can position the elements itself when the view becomes smaller and logically connected elements stay together when this happens. In the CSS, extra rules for the find bar have been added to ensure that the dialog's doorhanger is always below the find button. All findbar `div`s are forced to be 32 pixels high to prevent the find message text being aligned under the checkboxes. Finally, the find message is only visible when there is actually text to display. This prevents wrapping issues because, by default, the label has padding and margin even if there is no text.	8 years ago
Jonas Jenwald	c79e5b3f17	Viewer: replace find label with placeholder/tooltip This is common in the rest of the UI and helps us prevent responsiveness issues for different length strings in different locales.	8 years ago
Jonas Jenwald	468ed1b9a1	Ensure that the `outlineWithDeepNesting` CSS class is removed when resetting `PDFOutlineViewer`, to prevent incorrect alignment if a new document is opened	8 years ago
Jonas Jenwald	e07cb8638e	Get rid of `element.removeChild(element.firstChild)` usage (bug 1345253) Instead of just upstreaming the changes from [bug 1345253](https://bugzilla.mozilla.org/show_bug.cgi?id=1345253) as-is, it seemed better to simply get rid of the loops altogether and use the same approach as in `PDFViewer`/`PDFThumbnailViewer`.	8 years ago
Jonas Jenwald	37d596e00d	Get rid of a couple `eslint-disable` statements in `web/download_manager.js` by instead relying on the preprocessor dead-code removal added in PR 7942	8 years ago
Yury Delendik	5b50e0d414	Replaces RequireJS to SystemJS.	8 years ago
Yury Delendik	facefb0c79	Move compatibility code to the shared/compatibility.js.	8 years ago
Daniel Johnson	4fc64ceb76	iOS Chrome: Fix broken download button The download button in pdf.js doesn't work in iOS Chrome. - It appears to be an issue with URLs from URL.createObjectURL. The URL is correct, but iOS Chrome won't even load the URL when `a.click()` is called in `download_manager.js`. Even if you manually visit the URL, you get a blank page. - Fix this by detecting iOS Chrome and disabling createObjectURL. The `download_manager.js` `download` method wasn't checking `PDFJS.disableCreateObjectURL`, so check it there, too. - Move the navigator.msSaveBlob check earlier, so that this doesn't change IE10 / IE11 behavior. - Remove the !URL check since pdf.js has a URL polyfill now.	8 years ago
Yury Delendik	bc288141be	Allows to pull pdf.js from pdf_viewer using require().	8 years ago
Jonas Jenwald	63f13773e7	Use `ChildNode.remove` instead of `ChildNode.ParentNode.removeChild` in a couple of places (bug 1334831, issue 8008) Re: [bug 1334831](https://bugzilla.mozilla.org/show_bug.cgi?id=1334831) and issue 8008. Note that according to the specification, see https://dom.spec.whatwg.org/#interface-childnode, the `remove` method shouldn't throw. This is also consistent with e.g. the Firefox implementation, see http://searchfox.org/mozilla-central/rev/d3307f19d5dac31d7d36fc206b00b686de82eee4/dom/base/nsINode.cpp#1852. Obviously this isn't supported in IE (because that would be too easy), however we can easily polyfill it to avoid having to WONTFIX the bug/issue.	8 years ago
Jonas Jenwald	190c8398ba	[Chromium addon] Prevent errors that break the addon, caused by the `DEFAULT_URL` constant being replaced by a `defaultUrl` viewer configuration parameter (PR 8046 follow-up) I missed this during review, sorry about that! Fixes 8051.	8 years ago
Yury Delendik	eb4c88cd44	Replacing custom bundling with webpack2.	8 years ago
Rob Wu	ece44d36e8	Allow automatic print rotation via enablePrintAutoRotate	8 years ago
Rob Wu	f6548e463f	Open PDF attachments in the viewer instead of download If users want to download, they can quickly click on the Download button in the newly opened viewer. The blobUrl logic for Firefox relies on `disableCreateObjectURL` is never false in Firefox. If the assumption is invalid, then PDF attachments at the attachment view will not correctly be displayed, because a data-URL will be generated and `?<filename>` is treated as part of the data:-URL.	8 years ago
Rob Wu	775441b7c6	Refactor: configurable page rotation in print job Determine the page rotation at the same place as where the page size is determined. This allows us to implement custom print page rotation logic in one place, in the future.	8 years ago
Rob Wu	c67edabcb3	Set title using logic similar as download name The download method (and the PDF document properties) detect the file name using `getPDFFileNameFromURL`. The title ought to also display the PDF filename if available.	8 years ago
Rob Wu	228d253f30	Detect download filename based on full URL	8 years ago
Jonas Jenwald	bc736fdc7d	Adjust the `brace-style` ESLint rule to disallow single lines (and also enable `no-iterator`) See http://eslint.org/docs/rules/brace-style. Having the opening/closing braces on the same line can often make the code slightly more difficult to read, in particular for `if`/`else if` statements, compared to using new lines. This patch also, for consistency with `mozilla-central`, enables the [`no-iterator`](http://eslint.org/docs/rules/no-iterator) rule. Note that this rule didn't require a single code change.	8 years ago
Rob Wu	5fdc908f02	Recognize file name in reference fragment in getPDFFileNameFromURL The regular expression incorrectly marked a group as capturing. For `http://example.com/#file.pdf`, the expected result is "file.pdf", but instead "document.pdf" was returned.	8 years ago
Jonas Jenwald	c102232275	Append the contents of `FileAttachment` annotations to the attachments view of the sidebar, for easier access to the embedded files Other PDF viewers, e.g. Adobe Reader, seem to append `FileAttachment`s to their attachments views. One obvious difference in PDF.js is that we cannot append all the annotations on document load, since that would require parsing every page. Despite that, it still seems like a good idea to add `FileAttachment`s, since it's thus possible to access all the various types of attachments from a single place. Note: With the previous patch we display a notification when a `FileAttachment` is added to the sidebar, which thus makes appending the contents of these annotations to the sidebar slightly more visible/useful.	8 years ago
Jonas Jenwald	616e5fadff	Display a notification on the `sidebarToggle` button for PDF documents with outline/attachments A longstanding issue with the viewer is that you cannot tell if a PDF document includes an outline and/or attachments without actually opening the sidebar. This patch contains a suggested solution for that, by displaying an hide-on-interaction notification on the `sidebarToggle` button (and the relevant sidebar view buttons). Note that this was inspired by e.g. the update notification that is displayed on the menu button in Firefox. For an initial implementation, I've tried to do this in such a way that the notification isn't too distracting. Without being an UX expert, I don't think that we'd want something too in-your-face, in order to keep the viewer toolbars reasonable clean. (We probably do not want e.g. an entire notification bar in these situations, since that would take up unnecessary screen space and require actions from the user to close.) However it's certainly possible that the current notification might simply be too inconspicuous to be truly helpful to users, but we could probably iterate on that if the feature itself is deemed useful.	8 years ago
Jonas Jenwald	52e0f51917	Enable the `no-unused-vars` ESLint rule Please see http://eslint.org/docs/rules/no-unused-vars; note that this patch purposely uses the same rule options as in `mozilla-central`, such that it fixes part of issue 7957. It wasn't, in my opinion, entirely straightforward to enable this rule compared to the already existing rules. In many cases a `var descriptiveName = ...` format was used (more or less) to document the code, and I choose to place the old variable name in a trailing comment to not lose that information. I welcome feedback on these changes, since it wasn't always entirely easy to know what changes made the most sense in every situation.	8 years ago
Yury Delendik	a9cf281723	Fixes IE9 document.readyState and input.type=number issues.	8 years ago
Dave House	52360694b0	Remove ids from viewer page and thumbnail divs The id, and parsing it for the page number, is replaced by the data-page-number attribute (added here for thumbnails).	8 years ago
Jonas Jenwald	9eb9065c79	Ensure that we use the correct `paintedViewport` in `PDFPageView.cssTransform`, to avoid visual glitches on quick rotations (PR 7738 follow-up) This fixes a regression from commit `c9a0955c9c`, i.e. PR 7738. Currently if you quickly rotate a document at least twice,[1] such that rendering of a page hasn't finished for the first rotation before the last rotation is triggered, the `cssTransform` method can fail to update the page correctly leading to it looking temporarily distorted. The reason why things break is that previously we stored the `viewport` on the canvas DOM element, meaning that when it was accessed in `cssTransform` is was guaranteed to point to the `viewport` of the `zoomLayer` canvas. Generally you want to avoid storing data on DOM elements this way, and during the `PDFPageView` refactoring needed to support SVG rendering, the previous `viewport` was instead stored directly on `PDFPageView`. However, the problem is first of all that the `paintedViewport` only stores the last `viewport` computed, and second of all that there're no guarantees that it actually applies to the current `zoomLayer` canvas. If a document is rotated slowly enough that rendering finishes before the next rotation then this problem doesn't exist, but for sufficiently quick rotations rendering will be cancelled at least once and the `paintedViewport` could thus be bogus. The solution for the above problems is to ensure that we track the correct `viewport` for each DOM element (canvas or svg),[2] which seemed easist to do with a `WeakMap`.[3] --- [1] I'm able to reproduce this using the `tracemonkey` file, but please note that for pages with few operations, i.e. that render very quickly, the effect may be hard to spot. [2] One other possible solution that I briefly considered, was to wait until rendering finished before storing the current `viewport`. However, that would have caused issues with rotating a page before the first rendering operation had finished. [3] This regression took me way longer to both figure out, and fix, than I'd like to admit :-)	8 years ago
Jonas Jenwald	82ea7e6e6e	Enable the `no-unsafe-finally`/`no-octal`/`no-useless-call` ESLint rules http://eslint.org/docs/rules/no-unsafe-finally, there's just one violation which in this case can actually be ignored since there's nothing `return`ed there. http://eslint.org/docs/rules/no-octal, there're no violations in the code-base. http://eslint.org/docs/rules/no-useless-call, there's just one violation that needs to be fixed.	8 years ago
Jonas Jenwald	4626fc8342	Enable the `spaced-comment` ESLint rule Please see http://eslint.org/docs/rules/spaced-comment. Note that the exceptions added for `line` comments are intended to still allow use of the old preprocessor without linting errors. Also, I took the opportunity to improve the grammar slightly (w.r.t. capitalization and punctuation) for comments touched in the patch.	8 years ago
Jonas Jenwald	70c1a6b120	[Bug 1331081] omit addEventListener/removeEventListener's third parameter when it's false Upstream changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1331081; this patch also covers one file, `pdf_print_service.js`, that's not present in mozilla-central. Fixes 7962.	8 years ago
Yury Delendik	930a28d879	Better DOMContentLoaded handling.	8 years ago
Yury Delendik	ac2d4abf39	Removes web/default_preferences.js file.	8 years ago
Yury Delendik	77b7b84d1e	Removes rest of 'no-else-return' comments.	8 years ago
Jonas Jenwald	4046d67fde	Enable the `no-else-return` ESLint rule Using `else` after `return` is not necessary, and can often lead to unnecessarily cluttered code. By using the `no-else-return` rule in ESLint we can avoid this pattern, see http://eslint.org/docs/rules/no-else-return.	8 years ago
Jonas Jenwald	73e0daed6c	Let `finishPaintTask` in pdf_page_view.js return a promise instead, to avoid having to throw in the `paintTask.promise` rejection handler, and don't reject the `PDFPageView_draw` promise when rendering is `cancelled` As mentioned on IRC yesterday, we currently throw even when rendering is `cancelled`, which is annoying when the devtools are active. Furthermore, since `cancelled` isn't really an error, rejecting the `PDFPageView_draw` promise seems somewhat strange in that case.	8 years ago
Tim van der Meij	a428899b3c	Button widget annotations: improve unit tests, simplify code and remove labels Modern browsers support styling radio buttons and checkboxes with CSS. This makes the implementation much easier, and the fallback for older browsers is still decent.	8 years ago
Tim van der Meij	0c9a06c020	Button widget annotations: implement reference testing Moreover, ensure that the read-only state is respected and improve CSS names.	8 years ago
benweet	ba012c7a68	Button widget annotations: implement checkboxes and radio buttons	8 years ago
Jonas Jenwald	c850968fa7	Remove `globals` that are now unnecessary thanks to the use of various ESLint environments (e.g. Node, ShellJS, Jasmine)	8 years ago
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
Jonas Jenwald	a96b0f80dd	Convert the only remaining consumer (in `hand_tool.js`) of the 'localized' event to use the `localized` Promise instead, and only re-dispatch the 'localized' event on the `eventBus` for `GENERIC` builds Ideally we'd remove the 'localized' event from the `eventBus`, but for backwards compatibility we keep it in `GENERIC` builds. Note that while we want to ensure that the direction attribute of the HTML is updated as soon as the `localized` Promise is resolved, we purposely wait until the viewer has been initialized to ensure that the 'localized' event will always be dispatched.	8 years ago
Jonas Jenwald	648024f5d0	Don't call `bindEvents()` until `PDFViewerApplication` has been initialized, and move binding of `window` event listeners to a helper method, to prevent errors if an event manages to arrive too soon With `bindEvents()` now being called after the viewer has been initialized, we no longer need to have `PDFViewerApplication.initialized` checks in the event handler functions. Furthermore by moving the `window.addEventListener`s to a helper method, `PDFViewerApplication.initialized` checks are no longer necessary in the event handlers, hence we thus address part of issue 7797 here as well.	8 years ago
Jonas Jenwald	849f5dde9d	Move the `Preferences` initialization/fetching code to the top of `PDFViewerApplication.initialize`, to enable using them when initializing e.g. the viewer components Note that in quick testing using `console.time/timeEnd`, both locally and with the Firefox addon, the total run time of the entire `PDFViewerApplication.initialize` function does not seem to change with this patch.	8 years ago
Jonas Jenwald	2c1436f6cb	Refactor `PDFViewerApplication.initialize` into two methods, one that reads the Preferences and one that initializes the various viewer components	8 years ago
Jonas Jenwald	c36468cbce	Fix errors reported by the `keyword-spacing` ESLint rule http://eslint.org/docs/rules/keyword-spacing	8 years ago
Jonas Jenwald	86ba634c97	Fix errors reported by the `key-spacing` ESLint rule http://eslint.org/docs/rules/key-spacing	8 years ago
Jonas Jenwald	ad915f8af1	Fix errors reported by the `comma-spacing` ESLint rule http://eslint.org/docs/rules/comma-spacing	8 years ago
Jonas Jenwald	3820946301	Fix (most) errors reported by the `no-multi-spaces` ESLint rule http://eslint.org/docs/rules/no-multi-spaces	8 years ago

1 2 3 4 5 ...

1930 Commits (e229c21ce194b05ec12b2bbb51c3a88c90bad632)