pdfjs-dist

10068 Commits

1 Branch

1804 Tags

126 MiB

Tree: e9ba54940d

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	a494e33776	Update `JpegImage.getData` to support `forceRGBoutput` for images with `numComponents === 1` (issue 6066) A more robust solution for issue 6066. As a temporary work-around for (the upstream) [bug 1164199](https://bugzilla.mozilla.org/show_bug.cgi?id=1164199), we parsed all images in the Firefox addon during a short time. Doing so uncovered an issue with our image handling (see 6066), for JPEG images with a `DeviceGray` ColorSpace and `bpc !== 1` (bits per component). As long as we let the browser handle image decoding in this case, this isn't going to be an issue, but I do think that we should proactively fix this to avoid future issues if we change where the images are decoded (in `jpg.js` vs in browser). Also, we currently don't seem to have a test-case for that kind of image data.	9 years ago

Author

SHA1

Message

Date

Jonas Jenwald

a494e33776

Update `JpegImage.getData` to support `forceRGBoutput` for images with `numComponents === 1` (issue 6066)

*A more robust solution for issue 6066.*

As a temporary work-around for (the upstream) [bug 1164199](https://bugzilla.mozilla.org/show_bug.cgi?id=1164199), we parsed *all* images in the Firefox addon during a short time.
Doing so uncovered an issue with our image handling (see 6066), for JPEG images with a `DeviceGray` ColorSpace *and* `bpc !== 1` (bits per component).

As long as we let the browser handle image decoding in this case, this isn't going to be an issue, but I do think that we should proactively fix this to avoid future issues if we change where the images are decoded (in `jpg.js` vs in browser).
Also, we currently don't seem to have a test-case for that kind of image data.

9 years ago

1 Commits (e9ba54940d6fc3bd81b11ffafdb9137114798292)