akira/pdfjs-dist - pdfjs-dist - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
Jonas Jenwald	6111c17c8a	Use `Dict_getArray` in more places in `src/core/` to avoid issues when Arrays contain indirect objects As evident from e.g. PRs 6485 and 7118, some bad PDF generators unfortunately create Arrays where some elements are indirect objects (i.e. `Ref`s). This seems to mostly affect Arrays that contain numbers, such as e.g. `Matrix/FontMatrix/BBox/FontBBox/Rect/Color/...`, and has manifested itself in PDF files that fail to render correctly (some elements are missing). The problem in both the cases above, besides broken rendering, was that there were no errors/warnings that indicated what the problem was, making it difficult to pinpoint the issue. Hence this patch, where I've audited all usages of `Dict_get` in `src/core/` files, and replaced it with `Dict_getArray` where appropriate to try and prevent unnecessary future bugs.	9 years ago
Daan Sprenkels	90ec2c9294	shading-pattern: Decreased `Shadings.SMALL_NUMBER` and added a test case for #6298	9 years ago
Yury Delendik	6b60c8f4db	Adds UMD headers to core, display and shared files.	9 years ago
Yury Delendik	c9cb6a3025	Replaces UnsupportedManager with callback.	10 years ago
Daan Sprenkels	6ce83d3290	apply transformation matrix to RadialGradient radiuses, not only to circle origin points fix for #6006	10 years ago
Manas	a2ba1b8189	Uses editorconfig to maintain consistent coding styles Removes the following as they unnecessary /* -- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -- / / vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */	10 years ago
Tilman Hausherr	6d1e0f7e8d	fix handling of flags 1-3 in tensor shading pi is an index in the stream and is explained on page 201 of the 32000-spec (however 1-based there), and ps is an index to something in PDF.js. I used the code from flag 0 (which works) to understand which is which. It is also important to understand that for flags 1,2 and 3, the stream is always assigned to the same coordinates and colors. What changes is which "old" coordinates and colors are assigned to what is "missing" in the stream. This is why for these flags, the code is identical except for the assignments in the first "row". (Same principle as in #6304). Note that this change will not improve the lamp_cairo.pdf file, only the two files mentioned in #6305.	10 years ago
Tilman Hausherr	c85fa00d62	fix handling of flags 1-3 in coons shading Short story: somebody got lost in two different indices. pi is an index in the stream and is explained on page 198 of the 32000-spec (however 1-based there), and ps is an index to something in PDF.js. I used the code from flag 0 (which works) to understand which is which. It is also important to understand that for flags 1,2 and 3, the stream is always assigned to the same coordinates and colors. What changes is which "old" coordinates and colors are assigned to what is "missing" in the stream. This is why for these flags, the code is identical except for the assignments in the first "row".	10 years ago
Jonas Jenwald	1d65daf5e5	Correctly access `colorSpace.numComps` in `MeshStreamReader` (issue 6287) This regressed in `f750e35224`.	10 years ago
Jonas Jenwald	7fe2442a18	Ensure that we don't use the same typed array for both `coords` and `colors` in Mesh `figures` (issue 6287) This regressed in `1e8d70af98`.	10 years ago
Jonas Jenwald	55bc98a8b0	Rename `PatternType` to `ShadingType` to avoid confusion The current name is somewhat confusing, since the specification calls it `ShadingType`, see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.4044105 and http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.3882826. The real problem, however, is that there is actually another property called `PatternType`, which makes the current code very confusing, see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.1850929. Since `ShadingType` is only relevant for shading patterns (i.e. `PatternType === 2`), and not for tiling patterns (i.e `PatternType === 1`), this patch should help reduce confusion when reading the code.	10 years ago
Fabian Lange	ceffeab1de	Use 3 param method for converting r,g,b into css string. This avoids creation of temporary arrays to pass them into the util method. Also using "arguments" is more expensive then passing in 3 parameters.	11 years ago
Jonas Jenwald	78d0d269dc	Fallback to the \|Dummy\| Pattern when we fail to parse a Shading Pattern (issue 5509)	11 years ago
Yury Delendik	f750e35224	Optimizes functions to not create arrays	11 years ago
Jonas Jenwald	ee371fe6b2	Add strict equalities in src/core/pattern.js	11 years ago
Rob Wu	2e97c0d085	Remove some unused variables from src/ Only obviously useless, local variables have been removed.	11 years ago
Tim van der Meij	df91acf239	Fixes lint warning W004 in src/core	11 years ago
Yury Delendik	1e8d70af98	Prescales shading pattern packed data indices	11 years ago
Yury Delendik	561683d2e9	Dynamically determines how to split patch into triangles	11 years ago
Yury Delendik	a583c319a1	Implements shading types 4-7	11 years ago
Yury Delendik	bf432a37bb	Refactors shared/pattern.js into core/ and display/	11 years ago