pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	1b50932eaa	Don't show thumbnails until the `canvas` to `image` conversion is done (issue 6442)	10 years ago
Jonas Jenwald	d7a90d83de	Delete, and clear, the `image` in `PDFThumbnailView_reset` Follow-up to PR 6299.	10 years ago
Jonas Jenwald	555c7925a0	Prevent `setImage` from failing to display small thumbnails, by adding a missing `canvas` to `image` conversion Follow-up to PR 6299.	10 years ago
Jonas Jenwald	ebce928149	Extract the conversion from `canvas` to `image` into a helper function in `PDFThumbnailView` Follow-up to PR 6299. This patch reduces unnecessary code duplication for the `canvas` to `image` conversion. It also does a bit of re-ordering (and adds new lines) in `_getPageDrawContext`, since that function currently is a bit hard to read.	10 years ago
Jonas Jenwald	b7d1bed463	Add a utility function, for the viewer, that removes `null` (\x00) characters (issue 6416) Since some browsers render `null` characters, and others don't, this patch adds a way to remove them to prevent display issues in the viewer UI. Given that documents may contain very long outlines, I've added a utility function to avoid creating a lot of unnecessary `RegExp` objects. To avoid any future issues, this utility function is used for both the outline and the attachments. Fixes 6416.	10 years ago
Rob Wu	9f80060a18	Add mirrored triangle (TOC item icon)	10 years ago
Jonas Jenwald	da1b9df74a	Adjust the `min-width` of outline items and use more consistent `border-radius` (PR 6242 follow-up) Prior to PR 6242, the width of all outline items was set such that their right (or left, in RTL locales) edges lined up vertically. In my opinion that looked more consistent, therefore this patch adjusts the CSS to make sure that this will be the case again. The patch also makes the `border-radius` values of outline items a bit more consistent.	10 years ago
Jonas Jenwald	59548921d1	For documents with different page sizes, ensure that the correct page becomes visible on load when e.g. the 'page' hash parameter was provided (bug 1191279, issue 6393) This issue is actually, in a sense, "caused" by the fact that the API/viewer supports partial loading/rendering. Previously when the entire document was always fetched before rendering begun, we knew all page sizes in advance and this issue didn't exist. Now we use the size of one page in order to set the initial size of every page, until we've fetched the pages and thus know their correct sizes. This means that during loading the size of the pages can change, which may cause the initial position to become scrolled out of view. The most naive solution to this problem would perhaps be to delay setting the initial position on load for all documents, until all pages are fetched. However I think that would be a really bad idea, since doing so would make the initial rendering slower and make it feel sluggish for most documents. Since there is generally no way of knowing if a document has different sized pages prior to loading it, we can only check once the pages are available. Hence this patch, which treats documents with different sized pages as a special case, by re-applying the initial position when all pages have become available.	10 years ago
Fabian Lange	063ca95f5f	Remove TryCatch in canvas fill As verified by @Rob--W, the evenodd fill rule works correctly in all supported browsers. This now allows optimization by JS engines. This fixes #5458	10 years ago
awang	161def7f4e	Convert canvas thumbnails to PNG #6299	10 years ago
Jonas Jenwald	2df1b7b3cd	Switch `expanded/collapsed` in the names of the `treeitem-*` assets It appears to me that the `expanded/collapsed` part of the names got switched around, since I'd expect the following convention: - `v` == expanded - `>` == collapsed	10 years ago
Jonas Jenwald	b1950d3657	Use the Retina assets for `outlineItemToggler` when in HiDPI mode	10 years ago
Rob Wu	7c992243fd	Allow outline to be collapsed / shown via icon. - This commit adds a '>' before every outline item that has subitems. - Click on the '>' to collapse all subitems under that item (which turns the '>' in a 'v'). - Shift + click expands/collapses all descendant items under that tree. - Double-clicking on the "Show Document Outline" button in the toolbar expands/collapses all outline items.	10 years ago
Jonas Jenwald	a6d10af3b4	Add `disableStream` to the list of preferences read by `PDFViewerApplication.initialize` (issue 6361) Fixes 6361.	10 years ago
Rob Wu	4ac8863e30	Restore extension tab after reload Work-around for https://crbug.com/511670	10 years ago
Rob Wu	cf1d398bd2	Add translations of "Allow access to file URLs" The JSON file is generated as follows. 1. Go to the src/chrome/app/resources directory of Chromium's source. 2. Find the translation ID of the "Allow access to file URLs" string: grep 'Allow access to file URLs' generated_resources_en-GB.xtb 3. With the ID that you've found, locate the other translations. grep 3341703758641437857 generated_resources_.xtb 4. If the result looks OK, serialize the result as JSON and save it. > path/to/pdf.js/web/chrome-i18n-allow-access-to-file-urls.json \ python -c "import json;print(json.dumps({ \ $(grep 3341703758641437857 generated_resources_.xtb \| \ sed "s@generated_resources_$[^.]\+$\.xtb:<translation[^>]\+>$.\+$</translation>@'\1':'''\2''',@" \ )}, sort_keys=True, indent=2))" (Strings are taken from Chromium 45.0.2448.0 (ccrev.com/337313).	10 years ago
Rob Wu	775d4e69cf	Teach users how to enable access to local files.	10 years ago
Jonas Jenwald	f063c78cbf	Prevent switching to disabled views (i.e. outline or attachments) in the sidebar Currently in `switchSidebarView` there is code that attempts to handle the `outline` or `attachments` being disabled. However, given the placement of it, that code does not actually accomplish anything. Even more strange is the fact that the way that the buttons are disabled, that code won't ever be hit. (Looking back with `git blame`, it seems that it has never worked as you'd expect.) Hence this patch, which correctly disables switching to the `outline` or `attachments` views when they are disabled. Once PR 6314 restores the 'pagemode' hash parameter, this patch thus makes it impossible to switch to a disabled sidebar view by modifying the 'pagemode' hash of an already loaded document.	10 years ago
Jonas Jenwald	76cfd106d5	Fix 'namedaction' regression that breaks the 'Find' action This regressed in `0ef6212b64`.	10 years ago
Jonas Jenwald	5c26e5e2cd	Move handling of the 'pagemode' hash parameter into `viewer.js` to restore the functionality This regressed in `0ef6212b64`. Since the 'pagemode' hash parameter requires certain viewer functionality (e.g. thumbnails and an outline) in order to work, it seemed reasonable to move the functionality from `pdf_link_service.js` into `viewer.js`. Similar to `namedaction`, this patch makes use of an event to forward the 'pagemode' parameter.	10 years ago
Daan Sprenkels	c3b7ed4541	Apply hover style to .overlayButton not only when hovered, but also when focused (issue #6261 )	10 years ago
Tim van der Meij	a9d0e42871	Keep the Link annotation's data URL on one line Fixes #6278.	10 years ago
Rob Wu	47f2c14723	Optimize text layer: Avoid unneeded .textContent Built-in DOM properties are slower than plain JS properties. A few lines before, textContent is assigned as follows: textDiv.textContent = geom.str; So replacing textDiv.textContent.length with geom.str.length slightly improves performance without side effects.	10 years ago
Tim van der Meij	9c510bd6e6	Remove unused globals and updateViewarea function from viewer.js	10 years ago
Jonas Jenwald	8275dff1b1	Reduce code duplication in the 'keydown' event handler in `viewer.js`, by re-factoring the code which ensures that the `viewerContainer` is focused	10 years ago
Jonas Jenwald	d5232f5b5a	Ensure that the viewer always receives focus when the HOME/END keys are pressed (bug 1186842) It appears that I broke this with PR 4941. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1186842.	10 years ago
Jonas Jenwald	fa53cd6ca3	Use `DEFAULT_SCALE_VALUE` as default when fetching the `zoom` parameter from `PDFViewerApplication.store` (i.e. `ViewHistory`) Since the zoom value should be in percent, using `PDFViewer.currentScale` will be wrong by a factor of 100, potentially causing the zoom level of the document to become wrong on load.	10 years ago
Jonas Jenwald	299d05eaa5	Prevent documents from intermittently opening with the zoom level set to 1% (issue 6253) This fixes a regression from PR 6192. Under some circumstances, the `resize` event handler in `viewer.js` is fired before the scale has been set. This can lead to PDF documents being rendered at the wrong zoom level when they are opened. It seems that a way to reliably trigger this is to, using the Firefox addon, open a PDF file that triggers the `fallback` bar, in a new background tab (i.e. middle clicking on a link, or use the context menu). Prior to PR 6192, we checked the selected option in the `scaleSelect` dropdown instead. Since `pageAutoOption` is selected by default in `viewer.html`, this should explain why the issue wasn't visible previously.	10 years ago
Rob Wu	c676ecb5a0	Detect scripted auto-print requests Fixes #6106 To avoid future regressions, two new unit tests were added: 1. A new PDF based on the report from #6106, which contains an OpenAction of type JavaScript and a string "this.print({...}". 2. An existing PDF from https://bugzil.la/1001080 (from #4698). Although it does not matter, since we don't execute the JavaScript code, I have also changed "print(true)" to "print({})" since the print method takes an object (not a boolean). See "Printing PDF documents", page 62: http://adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/js_developer_guide.pdf	10 years ago
Jonas Jenwald	93d82e21d5	Move handling of the 'custom' scale value from pdf_viewer.js to viewer.js The special handling of the 'custom' scale value is only relevant for the `scaleSelect` dropdown in the standard viewer, hence I think that it should be placed in `viewer.js` instead.	10 years ago
Rob Wu	2d6b15d0d9	[CRX] Do not load local files in non-local frames Ordinarily, local files cannot be embedded in a non-local website. Until this commit, the extension allowed websites to embed local PDF files on non-local (e.g. http(s)) websites. This unintended feature is now disabled, to align better with Chrome's existing security policies (=local file:-URLs cannot be loaded in a tab unless expicitly allowed).	10 years ago
Will Herrmann	cbc715ed0f	Fixing find toolbar checkboxes not being accessible through keyboard navigation	10 years ago
Jonas Jenwald	0c08113e39	Remove `PDFViewerApplication.setScale` and further simplify the `scalechange` event handler (issue 6158) This finally fixes 6158.	10 years ago
Rob Wu	3e363ae307	scrollIntoView: Skip overflow:hidden elements	10 years ago
Jonas Jenwald	2608757620	Simplify the code that resets the value of the `pageNumber` element in `PDFViewerApplication.setInitialView` After the creation of `PDFViewer`, its `_resetView` method takes care of resetting, among other things, the page number property. Hence we don't need to set `pdfViewer.currentPageNumber = 1;` here any more, and the comment is no longer accurate either.	10 years ago
Jonas Jenwald	5cb15874fa	Remove `PDFViewerApplication.updateScaleControls` (issue 6158) With this patch we're getting very close to fixing 6158. The only use-case for `PDFViewerApplication.updateScaleControls` is to try and avoid calling `selectScaleOption` from the `scalechange` event handler in viewer.js. This will only happen when the user has manually changed the scale by using the `<select>` dropdown, which means that in reality this is just a micro optimization. Furthermore, `selectScaleOption` is only skipped for the "named" scale values (e.g. `auto`, `page-actual`, `page-fit`, `page-width`), thus further reducing the value of this code. Also, since we're updating the scale `<select>` dropdown from an event handler, we're currently depending on the event being dispatched (and handled) completely before the next `scalechange` event. Relying on the execution order of the code in this way, even though it currently works, seems unfortunate since it could potentially cause the internal scale value and the UI from getting out of sync.	10 years ago
Jonas Jenwald	35ee1e1b0a	Refactor the 'resize' event handler in viewer.js (issue 6158) This is the next step towards fixing 6158. This patch removes the dependency on the state of the scale `<select>` dropdown from the `resize` event handler, and instead uses the (in `PDFViewer`) stored `currentScaleValue`. I believe that the way this code is currently written is purely for historical reasons, since originally only the numerical scale was stored internally (hence there was no other way to access the scale value). However, since we now store the scale value, we should use it instead of quering the DOM. This helps ensure that the internally stored scale value is always accurately displayed in the UI (which should be good since, after the creation of `PDFViewer`, the `<select>` DOM element is now updated by an event handler).	10 years ago
Jonas Jenwald	1c0115a7e4	Remove the `currentScaleValue` getter from `PDFViewerApplication` (issue 6158) The next step towards fixing issue 6158. We can just as well access `pdfViewer.currentScaleValue` directly in `PDFViewerApplication`, instead of having a helper function which just acts as a wrapper for it.	10 years ago
Jonas Jenwald	d0c071a40d	Prevent re-rendering of pages because of rounding errors when computing the scale value Currently if the zoom level is reset multiple times in a row, i.e. by pressing <kbd>Ctrl</kbd>+<kbd>0</kbd>, the pages can be re-rendered each time even though their size shouldn't change. Whether this happens can depend on the size of the viewer, but documents with pages in landscape mode seem to be very susceptible to this. (An example is: https://wiki.mozilla.org/images/5/55/MobileOpportunity.pdf.) This can also effect documents with pages in portrait mode, when they are displayed in Presentation Mode. The reason for this unnecessary re-rendering is that due to limited numerical precision, the new scale value may change in only the last decimal place.	10 years ago
Jonas Jenwald	d9975ea778	Move annotation related CSS rules from pdf_viewer.css to its own file This is similar to the already existing, separate, CSS file used for the `textLayer`, and it's necessary in order for the `pageviewer` components example to actually show annotations correctly.	10 years ago
Jonas Jenwald	4364b37e55	Simplify the SimpleLinkService and use it to pass in a linkService instance in DefaultAnnotationsLayerFactory Considering that most methods of `SimpleLinkService` are complete stubs, or practically "useless" considering what they return, we can actually simplify it even more. Note: This depends on the previous patch, that did a small amount of refactoring of `PDFViewer_scrollPageIntoView`, since `PDFViewer.linkService.page` is no longer accessed. ---------- Currently the `pageviewer` components example doesn't work correctly (an error is printed in the console), since no `linkService` is present when the `AnnotationsLayerBuilder` is created. Note: Given that this uses the `SimpleLinkService`, clicking on e.g. internal links won't actually do anything. However, given that internal links (and similar features) are pretty much useless when only one page is loaded the `pageviewer` example, I don't think that really matters. Also, using the complete `PDFLinkService` would require a `PDFViewer` instance. That would significantly complicate the example, thus making it both less clear and less self contained.	10 years ago
Jonas Jenwald	ac3233bfa4	Use "private" properties in PDFViewer_scrollPageIntoView Currently in `PDFViewer_scrollPageIntoView`, we're accessing a number of properties in an indirect and overly complicated way. In particular, using `this.linkService.page` is a very roundabout way to access `this.currentPageNumber`. The reason for this appears to be entirely historical, since prior to PR 5361 the code was placed in `PDFPageView` (or `PageView` as it was called at the time).	10 years ago
Jonas Jenwald	6b2810f1f0	Pass in a `PDFViewer` instance to `PDFPresentationMode` and use it to eliminate all references to `PDFViewerApplication` This patch is the the first step towards to addressing issue 6158, which will be done by refactoring the code for setting/getting the current scale in `viewer.js`.	10 years ago
Rob Wu	2932f7c676	Zoom relative to cursor position via mouse wheel Before this patch, zooming in/out via the scroll wheel caused the page to be zoomed relative to the upper-left corner of the page, i.e. the upper-left corner of the page stays at a fixed position. After this patch, the page is zoomed relative to the cursor position, i.e. after zooming in/out, the part under the cursor 'has not moved'. This only applies when the page does not fit in the viewport, because pages smaller than the viewpoer are always centered.	10 years ago
Yury Delendik	f3c3b1fc2d	Removes B2G preprocessing directives.	10 years ago
Yury Delendik	1b847df2f3	Using pdfjs-dist as a library for b2g viewer.	10 years ago
Jonas Jenwald	d940078d95	Make sure that the document is rendered on zooming and rotation for `PDFViewer` instances using the `defaultRenderingQueue` In `viewer.js` we have code that ensures that the document is re-rendered on zooming and rotation. However, for `components` based viewers this might not work correctly, since there's currently no code which handles that. Note that there is a good chance that this "just works" in many `components` viewers already, thanks to the `watchScroll` function. The explanation is that zooming or rotation, most of the time, causes the viewer to change its (scrollable) size, thus triggering `PDFViewer_update` through `PDFViewer_scrollUpdate`. However, in general there's no guarantee that this will actually work (since zooming and rotation doesn't necessarily change the size of the viewer for all documents), and requiring every viewer `components` implementer to provide methods for this doesn't seem like a great idea.	10 years ago
Timothy Gu	a5cfb0a73b	Update Adobe CMaps URL and license They are now using Apache 2.0 as well.	10 years ago
Jonas Jenwald	ffeba9c630	Move the page switching code into `set currentPageNumber` in `PDFViewer` instead of placing it in the `pagechange` event handler The reason that this code can be moved is that the `if (this.loading && page === 1)` check, in the `pagechange` event handler in viewer.js, is never satisfied since `this.loading` is not defined in that scope. This could be considered a regression from PR 5295, since prior to that `this.loading` was using the `PDFViewerApplication` scope (or `PDFView` as it were). However, I don't think that we need to fix that since we've been shipping this code in no less than three Firefox releases (uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1084158), without breaking the world. An explanation of why the `pagechange` code works, despite `this.loading === undefined`, is that `set currentPageNumber` (in `PDFViewer`) returns early whenever `this.pdfDocument` isn't set. This check is, for all intents and purposes, functionally equivalent to checking `PDFViewerApplication.loading`. Hence we can move the page switching code into `PDFViewer`, and also remove `PDFViewerApplication.loading` since it's not used any more. (The `this.loading` property was added in PR 686, which was before the current viewer even existed.) Note: The changes in this patch should also be beneficial to the viewer `components`, since requiring every implementer to provide their own `pagechange` event handler just to get `PDFViewer.currentPageNumber` to actually work seems like an unnecessary complication.	10 years ago
Jonas Jenwald	633d51fc22	[Firefox] Handle the user modifying the "mousewheel.with_meta.action" and "mousewheel.with_control.action" prefs (bug 1170063) Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1170063. The bug only mentions the <kbd>Meta</kbd> key, but given that a similar situation can occur for <kbd>Ctrl</kbd>, it seemed reasonable to also handle that case in the same patch. The only possible caveat with the patch is that because of the use of `shadow`, things won't work perfectly if either of the prefs are changed while the viewer is active. In this case a reload is required in order for it to work correctly, but given that the issue this patch fixes should be quite rare anyway, that seems OK.	10 years ago

1 2 3 4 5 ...

1684 Commits (f340dd5cd5bbbe78b71862a0c561d02dd25e0f14)