pdfjs-dist

10235 Commits

1 Branch

1804 Tags

126 MiB

Tree: fab59e0f91

Commit Graph

Author	SHA1	Message	Date
Jonas Jenwald	b8ec518a1e	Split the existing `PDFFunction` in two classes, a private `PDFFunction` and a public `PDFFunctionFactory``, and utilize the latter in `PDFDocument` to allow various code to access the methods of `PDFFunction` Follow-up to PR 8909. This requires us to pass around `pdfFunctionFactory` to quite a lot of existing code, however I don't see another way of handling this while still guaranteeing that we can access `PDFFunction` as freely as in the old code. Please note that the patch passes all tests locally (unit, font, reference), and I very much hope that we have sufficient test-coverage for the code in question to catch any typos/mistakes in the re-factoring.	8 years ago
Tim van der Meij	ab820438ae	Move the `XRefMock` in the unit tests to a central location This patch helps to avoid code duplication for this mock since more unit tests are depending on it.	8 years ago
Apoorv Mishra	a129de7bd1	Add unit-tests for colorspace.js Added unit-tests for DeviceGray, DeviceRGB and DeviceCMYK Added unit-tests for CalGray Added unit-tests for CalRGB Removed redundant code Added unit-tests for LabCS Added unit-tests for IndexedCS Update comment Change lookup to Uint8Array as mentioned in pdf specs(these tests will pass after PR #8666 is merged). Added unit-tests for AlternateCS Resolved code-style issues Fixed code-style issues Addressed issues pointed out in https://github.com/mozilla/pdf.js/pull/8611#pullrequestreview-52865469	8 years ago

Author

SHA1

Message

Date

Jonas Jenwald

b8ec518a1e

Split the existing `PDFFunction` in two classes, a private `PDFFunction` and a public `PDFFunctionFactory``, and utilize the latter in `PDFDocument` to allow various code to access the methods of `PDFFunction`

*Follow-up to PR 8909.*

This requires us to pass around `pdfFunctionFactory` to quite a lot of existing code, however I don't see another way of handling this while still guaranteeing that we can access `PDFFunction` as freely as in the old code.

Please note that the patch passes all tests locally (unit, font, reference), and I *very* much hope that we have sufficient test-coverage for the code in question to catch any typos/mistakes in the re-factoring.

8 years ago

Tim van der Meij

ab820438ae

Move the `XRefMock` in the unit tests to a central location

This patch helps to avoid code duplication for this mock since more unit
tests are depending on it.

8 years ago

Apoorv Mishra

a129de7bd1

Add unit-tests for colorspace.js

Added unit-tests for DeviceGray, DeviceRGB and DeviceCMYK

Added unit-tests for CalGray

Added unit-tests for CalRGB

Removed redundant code

Added unit-tests for LabCS

Added unit-tests for IndexedCS

Update comment

Change lookup to Uint8Array as mentioned in pdf specs(these tests will pass after PR #8666 is merged).

Added unit-tests for AlternateCS

Resolved code-style issues

Fixed code-style issues

Addressed issues pointed out in https://github.com/mozilla/pdf.js/pull/8611#pullrequestreview-52865469

8 years ago

3 Commits (fab59e0f917fce12c4e92fbb2129a72037cdb290)