pdfjs-dist

Commit Graph

Author	SHA1	Message	Date
Mukul Mishra	41d092d04b	Fixes behaviour of DOMCanvasFactory to return {canvas, context}.	8 years ago
Jonas Jenwald	9c34d0aa8c	[api-minor] Add a `getDocument` parameter that allows disabling of the `NativeImageDecoder` (e.g. for use with Node.js) Note that I initially tried to add this as a parameter to the `PDFPageProxy.render` method, such that it could be passed to `PartialEvaluator.getOperatorList`. However, given all the different code-paths that call `getOperatorList` (there's a bunch only in `annotation.js`), this seemed to very quickly become unwieldy and thus difficult to maintain compared to simply using the existing `evaluatorOptions`.	8 years ago
Mukul Mishra	32817633c9	Fix #7798 : Refactor scratch canvas usage. Fixes extra canvas create calls. Fixes unnecessary call of `new DOMCanvasFactory`. Fixes undefined error of DOMCanvasFactory. Fixes failures in some of the tests. Fixes expected behaviour. Remove unused vars.	8 years ago
Jonas Jenwald	e416032b38	Prevent browser console errors during testing The `Driver._cleanup` method is removing all stylesheets between test runs, which causes "TypeError: styleElement.parentNode is null" console errors in `FontLoader.clear`. As can also be seen during various tests, some of the changes I made in PR 7972 unfortunately causes console errors. It seems that I didn't test this properly, since it should have been obvious to me that while tests are triggered using Node.js, the files in question are run within the browser. My apologies for not testing this thoroughly, and for causing unnecessary churn in the code!	8 years ago
Jonas Jenwald	bc736fdc7d	Adjust the `brace-style` ESLint rule to disallow single lines (and also enable `no-iterator`) See http://eslint.org/docs/rules/brace-style. Having the opening/closing braces on the same line can often make the code slightly more difficult to read, in particular for `if`/`else if` statements, compared to using new lines. This patch also, for consistency with `mozilla-central`, enables the [`no-iterator`](http://eslint.org/docs/rules/no-iterator) rule. Note that this rule didn't require a single code change.	8 years ago
Jonas Jenwald	f7d99ccc26	Remove the unused `isStream` property on various `Stream`s This property was added all the way back in PR 542, but hasn't actually been relied upon ever since PR 692. Note that there's a `isStream()` utility function which replaced the property years ago, hence the `isStream` property is now dead code.	8 years ago
Jonas Jenwald	c102232275	Append the contents of `FileAttachment` annotations to the attachments view of the sidebar, for easier access to the embedded files Other PDF viewers, e.g. Adobe Reader, seem to append `FileAttachment`s to their attachments views. One obvious difference in PDF.js is that we cannot append all the annotations on document load, since that would require parsing every page. Despite that, it still seems like a good idea to add `FileAttachment`s, since it's thus possible to access all the various types of attachments from a single place. Note: With the previous patch we display a notification when a `FileAttachment` is added to the sidebar, which thus makes appending the contents of these annotations to the sidebar slightly more visible/useful.	8 years ago
Tim van der Meij	95732279b6	Remove usage of `mozFillRule` The non-standard `mozFillRule` has been removed in Firefox 51 [1, 2]. Instead, a parameter of the standard methods should be used. Note that this is supported in all major browsers for a long time now, so there should be no need keeping this Firefox-specific code around. [1] https://developer.mozilla.org/en-US/Firefox/Releases/51 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=826619	8 years ago
Jonas Jenwald	52e0f51917	Enable the `no-unused-vars` ESLint rule Please see http://eslint.org/docs/rules/no-unused-vars; note that this patch purposely uses the same rule options as in `mozilla-central`, such that it fixes part of issue 7957. It wasn't, in my opinion, entirely straightforward to enable this rule compared to the already existing rules. In many cases a `var descriptiveName = ...` format was used (more or less) to document the code, and I choose to place the old variable name in a trailing comment to not lose that information. I welcome feedback on these changes, since it wasn't always entirely easy to know what changes made the most sense in every situation.	8 years ago
Jonas Jenwald	50c2856097	Move `EOF`/`isEOF` from core/parser.js to core/primitives.js Given the nature of `EOF` and `isEOF`, it seems to me that they really ought to be placed in `core/primitives.js` instead. In general, it doesn't seem great to have to depend on the entire `core/parser.js` file for such simple primitives/helper functions. In particular, while `core/ps_parser.js` is completely separate from `core/parser.js` with regards to its function, it still depends on the latter for just one primitive. Note that compared to e.g. PR 7389, this will not reduce the number of dependencies for `core/ps_parser`, however the new dependency IMHO makes more sense.	8 years ago
Jonas Jenwald	f000417ce0	[Firefox addon] Stop bundling `src/core/network.js` into the `FIREFOX`/`MOZCENTRAL` builds (PR 7322 follow-up) PR 7322 added the `PdfJsNetwork.jsm` file, instead of the general `src/core/network.js` file for the Firefox addon. However, `make.js` wasn't updated to actually stop including the now obsolete network file.	8 years ago
Jonas Jenwald	f77c52291e	Enable the `no-empty-pattern`/`no-floating-decimal`/`no-self-compare`/`no-delete-var`/`no-new-object` ESLint rules The following rules required no code changes: http://eslint.org/docs/rules/no-empty-pattern http://eslint.org/docs/rules/no-floating-decimal http://eslint.org/docs/rules/no-delete-var http://eslint.org/docs/rules/no-new-object There was just one change needed in order to enable: http://eslint.org/docs/rules/no-self-compare; which I think helps readability a lot, since that comparison makes no sense until you realize that we push `NaN` onto the `stack` in some cases and furthermore that `NaN !== NaN`.	8 years ago
Yury Delendik	fc2d8c15e8	Adds noopener and nofollow to rel attribute of hyperlinks.	8 years ago
Mukul Mishra	4e38200030	Fix #7978 : Fixes ESLint yoda rule for the URL polyfill.	8 years ago
Jonas Jenwald	82ea7e6e6e	Enable the `no-unsafe-finally`/`no-octal`/`no-useless-call` ESLint rules http://eslint.org/docs/rules/no-unsafe-finally, there's just one violation which in this case can actually be ignored since there's nothing `return`ed there. http://eslint.org/docs/rules/no-octal, there're no violations in the code-base. http://eslint.org/docs/rules/no-useless-call, there's just one violation that needs to be fixed.	8 years ago
Jonas Jenwald	4626fc8342	Enable the `spaced-comment` ESLint rule Please see http://eslint.org/docs/rules/spaced-comment. Note that the exceptions added for `line` comments are intended to still allow use of the old preprocessor without linting errors. Also, I took the opportunity to improve the grammar slightly (w.r.t. capitalization and punctuation) for comments touched in the patch.	8 years ago
Syed Abdullah	857a5da8f1	Fix inverted calculation of RTL text percentage in bidi.	8 years ago
jazzchipc	493853031b	Fixes issue #6071 . Corrects readBlockTiff() case for 1-bit depth and 1 color TIFF images incorporated in the PDF. Adds reference test for PDF used to fix this issue.	8 years ago
Yury Delendik	77b7b84d1e	Removes rest of 'no-else-return' comments.	8 years ago
Jonas Jenwald	642d8621ef	Replace direct lookup of `uniquePrefix`/`idCounters`, in `Page` instances, with an `idFactory` containing an `createObjId` method instead We're currently making use of `uniquePrefix`/`idCounters` in multiple files, to create unique object id's, and adding a new occurrence of them requires some care to ensure that an object id isn't accidentally reused. Furthermore, having to pass around multiple parameters as we currently do seem like something you want to avoid. Instead, this patch adds a factory which means that there's only one thing that needs to be passed around. And since it's now only necessary to call a method in order to obtain a unique object id, the details are thus abstracted away at the call-sites which avoids accidental reuse of object id's. To test that this works as expected a very simple `Page` unit-test is added, and the existing `Annotation layer` tests are also adjusted slightly.	8 years ago
Jonas Jenwald	4046d67fde	Enable the `no-else-return` ESLint rule Using `else` after `return` is not necessary, and can often lead to unnecessarily cluttered code. By using the `no-else-return` rule in ESLint we can avoid this pattern, see http://eslint.org/docs/rules/no-else-return.	8 years ago
Jonas Jenwald	14b8523314	Refactor the `password` handling so that it's stored in the `PdfManager`s, instead of in the `XRef` We're already passing in a, currently unused, `PdfManager` instance when initializing the `XRef`. To avoid having to pass a single `password` parameter around, we could thus simply get the `password` through the `PdfManager` instance instead.	8 years ago
Jonas Jenwald	27513cd23b	[api-minor] Ensure that the `getDocument` Promise is rejected if the `loadingTask` is destroyed, or an `Error` is thrown, inside of the `onPassword` callback (issue 7806) This patch also removes the `UpdatePassword` message, in favour of using the `sendWithPromise` method of `MessageHandler`. Furthermore, the patch also refactors the `BasePdfManager_updatePassword`/`BasePdfManager_passwordChanged` methods (in pdf_manager.js), and the `pdfManagerReady` function (in worker.js).	8 years ago
Jonas Jenwald	ddea9a6b04	Improve the handling of `Encoding` dictionary, with `Differences` array, in `PartialEvaluator_preEvaluateFont` I recently happened to look at the code I wrote for PR 5964, which fixed [bug 1157493](https://bugzilla.mozilla.org/show_bug.cgi?id=1157493), and I quickly realized that the solution is way too simplistic. The fact that only using the `length` of a `Differences` array worked seems more like a happy accident for a particular set of font data, but could just as easily be incorrect for other PDF files. Note that in practice, the case where the `Encoding` entry is a regular `Dict` (and not a `Ref` or `Name`) is very rare, hence I don't think that we really need to worry about having to reparse this data. Also, the performance of this code-block is quite a bit better by updating the `hash` with the data from the entire `Differences` array, instead of at every loop iteration.	8 years ago
Jonas Jenwald	e963971244	Further adjust the heuristics used to detect OpenType font files with CFF data, to ensure that all Type0 fonts are handled the same way regardless of font Subtype (issue 7901) Changing this particular code makes me somewhat nervous about regressions, since PR 5770 necessitated the follow-up PR 6270. However, the patch passes all tests added in those PRs (and obviously all other tests). Furthermore, I've manually checked all the issues/bugs referenced in PRs 5770 and 6270 without finding any issues. Please note: This patch fixes only the font bug, not the SVG conversion, present on pages two and three of the PDF file in issue 7901.	8 years ago
Tim van der Meij	a428899b3c	Button widget annotations: improve unit tests, simplify code and remove labels Modern browsers support styling radio buttons and checkboxes with CSS. This makes the implementation much easier, and the fallback for older browsers is still decent.	8 years ago
Tim van der Meij	77148c7880	Button widget annotations: implement radio button value fetching according to the specification	8 years ago
Tim van der Meij	0c9a06c020	Button widget annotations: implement reference testing Moreover, ensure that the read-only state is respected and improve CSS names.	8 years ago
benweet	ba012c7a68	Button widget annotations: implement checkboxes and radio buttons	8 years ago
Jonas Jenwald	bd91f34513	Ensure that we handle indirect objects in all types of `Opt` entries in `ChoiceWidget` annotation dictionaries I haven't got an example where the current code breaks, but given all the previous cases we've seen where PDF generators use indirect objects in Arrays it makes sense to fix this pro-actively. I've modified the relevant unit-tests slightly, and they would not pass without the code changes in this patch. Note: `Dict_getArray` only dereferences Array elements on the "top-level", to avoid recursion issues. Furthermore if you have to loop through the Array at the call-site anyway, then using `Dict_get` in combination with `XRef_fetchIfRef` is a tiny bit more efficient.	8 years ago
Jonas Jenwald	c850968fa7	Remove `globals` that are now unnecessary thanks to the use of various ESLint environments (e.g. Node, ShellJS, Jasmine)	8 years ago
Jonas Jenwald	2f3805efbc	Switch to using ESLint, instead of JSHint, for linting Please note that most of the necessary code adjustments were made in PR 7890. ESLint has a number of advantageous properties, compared to JSHint. Among those are: - The ability to find subtle bugs, thanks to more rules (e.g. PR 7881). - Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint. - Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary). - The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. Note: in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage. - More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead. By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want. Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much. I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors and various style guide violations. Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%). A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible: - `comma-dangle`, controls trailing commas in Objects and Arrays (among others). - `object-curly-spacing`, controls spacing inside of Objects. - `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.) Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed. Useful links: - http://eslint.org/docs/user-guide/configuring - http://eslint.org/docs/rules/	8 years ago
Ross Johnson	4537590033	Consitently apply textAdvanceScale during building of textContentItems for improved highlighting. Fixes #7878 .	8 years ago
Jonas Jenwald	28e50cfa21	Fix errors reported by the `space-infix-ops` ESLint rule http://eslint.org/docs/rules/space-infix-ops	8 years ago
Jonas Jenwald	68bf47d55d	Fix errors reported by the `space-before-function-paren` ESLint rule http://eslint.org/docs/rules/space-before-function-paren	8 years ago
Jonas Jenwald	551eb263e3	Fix errors reported by the `semi-spacing` ESLint rule http://eslint.org/docs/rules/semi-spacing	8 years ago
Jonas Jenwald	efbb1e9b1c	Fix errors reported by the `new-cap` ESLint rule http://eslint.org/docs/rules/new-cap	8 years ago
Jonas Jenwald	c36468cbce	Fix errors reported by the `keyword-spacing` ESLint rule http://eslint.org/docs/rules/keyword-spacing	8 years ago
Jonas Jenwald	86ba634c97	Fix errors reported by the `key-spacing` ESLint rule http://eslint.org/docs/rules/key-spacing	8 years ago
Jonas Jenwald	ad915f8af1	Fix errors reported by the `comma-spacing` ESLint rule http://eslint.org/docs/rules/comma-spacing	8 years ago
Jonas Jenwald	66d2637b3f	Fix errors reported by the `yoda` ESLint rule http://eslint.org/docs/rules/yoda	8 years ago
Jonas Jenwald	3820946301	Fix (most) errors reported by the `no-multi-spaces` ESLint rule http://eslint.org/docs/rules/no-multi-spaces	8 years ago
Jonas Jenwald	25bf5db47e	Fix errors reported by the `no-extra-boolean-cast` ESLint rule http://eslint.org/docs/rules/no-extra-boolean-cast	8 years ago
Jonas Jenwald	fb5e756683	Fix errors reported by the `no-cond-assign` ESLint rule http://eslint.org/docs/rules/no-cond-assign	8 years ago
Tim van der Meij	3800b5e463	Document: extract `CropBox` fetching and validation into a getter This patch refactors the `CropBox` code to combine fetching and validation code in a getter, like we already did for the `MediaBox` property. Combined with variable name changes, this improves readability of the code and makes the `view` getter simpler as well.	8 years ago
Jonas Jenwald	9be3aee9c9	Add a parameter to `Page_getInheritedPageProp` to make it possible to fetch (and dereference) Arrays, and use that for the `MediaBox`/`CropBox` getters (issue 7872)	8 years ago
Jonas Jenwald	b4ac6bd2f6	Ensure that we resolve indirect objects in `Filter` and `DecodeParms` arrays in `parser.js` I've not actually, thus far, come across a PDF file that this patch fixes. However, given the string of recent patches that has fixed issues with indirect objects in arrays, I think that it makes sense to proactively avoid any issues in this code.	8 years ago
Jonas Jenwald	77bcc9232e	Remove a misplaced `false` from a condition in `fixMetadata`, in `metadata.js`, since it currently short circuits the entire condition This looks to me like a simple oversight, which has existed ever since PR 1598 all the way back in 2012.	8 years ago
Tim van der Meij	90d94815ad	Colorspace: miscellaneous improvements - Remove an unnecessary check and assignment. - Clean up code regarding mode setting (no need for a member variable). - Indent two methods correctly.	9 years ago
Tim van der Meij	c5c0a00dca	Colorspace: reduce duplication in `AlternateCS.getRgbBuffer`	9 years ago

1 2 3 4 5 ...

2716 Commits (fd4428136b6a2dffb31b88f9b6da724623c5e8c5)